Files
eslint/tests/lib/rules/no-useless-call.js

288 lines
5.6 KiB
JavaScript

/**
* @fileoverview Tests for no-useless-call rule.
* @author Toru Nagashima
*/
"use strict";
//------------------------------------------------------------------------------
// Requirements
//------------------------------------------------------------------------------
const rule = require("../../../lib/rules/no-useless-call");
const RuleTester = require("../../../lib/rule-tester/rule-tester");
//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------
const ruleTester = new RuleTester();
ruleTester.run("no-useless-call", rule, {
valid: [
// `this` binding is different.
"foo.apply(obj, 1, 2);",
"obj.foo.apply(null, 1, 2);",
"obj.foo.apply(otherObj, 1, 2);",
"a.b(x, y).c.foo.apply(a.b(x, z).c, 1, 2);",
"foo.apply(obj, [1, 2]);",
"obj.foo.apply(null, [1, 2]);",
"obj.foo.apply(otherObj, [1, 2]);",
"a.b(x, y).c.foo.apply(a.b(x, z).c, [1, 2]);",
"a.b.foo.apply(a.b.c, [1, 2]);",
// ignores variadic.
"foo.apply(null, args);",
"obj.foo.apply(obj, args);",
// ignores computed property.
"var call; foo[call](null, 1, 2);",
"var apply; foo[apply](null, [1, 2]);",
// ignores incomplete things.
"foo.call();",
"obj.foo.call();",
"foo.apply();",
"obj.foo.apply();",
// Optional chaining
{
code: "obj?.foo.bar.call(obj.foo, 1, 2);",
languageOptions: { ecmaVersion: 2020 },
},
// Private members
{
code: "class C { #call; wrap(foo) { foo.#call(undefined, 1, 2); } }",
languageOptions: { ecmaVersion: 2022 },
},
],
invalid: [
// call.
{
code: "foo.call(undefined, 1, 2);",
errors: [
{
messageId: "unnecessaryCall",
data: { name: "call" },
},
],
},
{
code: "foo.call(void 0, 1, 2);",
errors: [
{
messageId: "unnecessaryCall",
data: { name: "call" },
},
],
},
{
code: "foo.call(null, 1, 2);",
errors: [
{
messageId: "unnecessaryCall",
data: { name: "call" },
},
],
},
{
code: "obj.foo.call(obj, 1, 2);",
errors: [
{
messageId: "unnecessaryCall",
data: { name: "call" },
},
],
},
{
code: "a.b.c.foo.call(a.b.c, 1, 2);",
errors: [
{
messageId: "unnecessaryCall",
data: { name: "call" },
},
],
},
{
code: "a.b(x, y).c.foo.call(a.b(x, y).c, 1, 2);",
errors: [
{
messageId: "unnecessaryCall",
data: { name: "call" },
},
],
},
// apply.
{
code: "foo.apply(undefined, [1, 2]);",
errors: [
{
messageId: "unnecessaryCall",
data: { name: "apply" },
},
],
},
{
code: "foo.apply(void 0, [1, 2]);",
errors: [
{
messageId: "unnecessaryCall",
data: { name: "apply" },
},
],
},
{
code: "foo.apply(null, [1, 2]);",
errors: [
{
messageId: "unnecessaryCall",
data: { name: "apply" },
},
],
},
{
code: "obj.foo.apply(obj, [1, 2]);",
errors: [
{
messageId: "unnecessaryCall",
data: { name: "apply" },
},
],
},
{
code: "a.b.c.foo.apply(a.b.c, [1, 2]);",
errors: [
{
messageId: "unnecessaryCall",
data: { name: "apply" },
},
],
},
{
code: "a.b(x, y).c.foo.apply(a.b(x, y).c, [1, 2]);",
errors: [
{
messageId: "unnecessaryCall",
data: { name: "apply" },
},
],
},
{
code: "[].concat.apply([ ], [1, 2]);",
errors: [
{
messageId: "unnecessaryCall",
data: { name: "apply" },
},
],
},
{
code: "[].concat.apply([\n/*empty*/\n], [1, 2]);",
errors: [
{
messageId: "unnecessaryCall",
data: { name: "apply" },
},
],
},
{
code: 'abc.get("foo", 0).concat.apply(abc . get("foo", 0 ), [1, 2]);',
errors: [
{
messageId: "unnecessaryCall",
data: { name: "apply" },
},
],
},
// Optional chaining
{
code: "foo.call?.(undefined, 1, 2);",
languageOptions: { ecmaVersion: 2020 },
errors: [{ messageId: "unnecessaryCall", data: { name: "call" } }],
},
{
code: "foo?.call(undefined, 1, 2);",
languageOptions: { ecmaVersion: 2020 },
errors: [{ messageId: "unnecessaryCall", data: { name: "call" } }],
},
{
code: "(foo?.call)(undefined, 1, 2);",
languageOptions: { ecmaVersion: 2020 },
errors: [{ messageId: "unnecessaryCall", data: { name: "call" } }],
},
{
code: "obj.foo.call?.(obj, 1, 2);",
languageOptions: { ecmaVersion: 2020 },
errors: [
{
messageId: "unnecessaryCall",
data: { name: "call" },
},
],
},
{
code: "obj?.foo.call(obj, 1, 2);",
languageOptions: { ecmaVersion: 2020 },
errors: [
{
messageId: "unnecessaryCall",
data: { name: "call" },
},
],
},
{
code: "(obj?.foo).call(obj, 1, 2);",
languageOptions: { ecmaVersion: 2020 },
errors: [
{
messageId: "unnecessaryCall",
data: { name: "call" },
},
],
},
{
code: "(obj?.foo.call)(obj, 1, 2);",
languageOptions: { ecmaVersion: 2020 },
errors: [
{
messageId: "unnecessaryCall",
data: { name: "call" },
},
],
},
{
code: "obj?.foo.bar.call(obj?.foo, 1, 2);",
languageOptions: { ecmaVersion: 2020 },
errors: [
{
messageId: "unnecessaryCall",
data: { name: "call" },
},
],
},
{
code: "(obj?.foo).bar.call(obj?.foo, 1, 2);",
languageOptions: { ecmaVersion: 2020 },
errors: [
{
messageId: "unnecessaryCall",
data: { name: "call" },
},
],
},
{
code: "obj.foo?.bar.call(obj.foo, 1, 2);",
languageOptions: { ecmaVersion: 2020 },
errors: [
{
messageId: "unnecessaryCall",
data: { name: "call" },
},
],
},
],
});