mirror of
https://github.com/hanzoai/eslint.git
synced 2026-10-30 19:38:10 +00:00
220 lines
4.4 KiB
JavaScript
220 lines
4.4 KiB
JavaScript
/**
|
|
* @fileoverview Tests for no-useless-throw rule
|
|
* @author Teddy Katz
|
|
* @author Alex Grasley
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Requirements
|
|
//------------------------------------------------------------------------------
|
|
|
|
const rule = require("../../../lib/rules/no-useless-catch"),
|
|
RuleTester = require("../../../lib/rule-tester/rule-tester");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Tests
|
|
//------------------------------------------------------------------------------
|
|
|
|
const ruleTester = new RuleTester();
|
|
|
|
ruleTester.run("no-useless-catch", rule, {
|
|
valid: [
|
|
`
|
|
try {
|
|
foo();
|
|
} catch (err) {
|
|
console.error(err);
|
|
}
|
|
`,
|
|
`
|
|
try {
|
|
foo();
|
|
} catch (err) {
|
|
console.error(err);
|
|
} finally {
|
|
bar();
|
|
}
|
|
`,
|
|
`
|
|
try {
|
|
foo();
|
|
} catch (err) {
|
|
doSomethingBeforeRethrow();
|
|
throw err;
|
|
}
|
|
`,
|
|
`
|
|
try {
|
|
foo();
|
|
} catch (err) {
|
|
throw err.msg;
|
|
}
|
|
`,
|
|
`
|
|
try {
|
|
foo();
|
|
} catch (err) {
|
|
throw new Error("whoops!");
|
|
}
|
|
`,
|
|
`
|
|
try {
|
|
foo();
|
|
} catch (err) {
|
|
throw bar;
|
|
}
|
|
`,
|
|
`
|
|
try {
|
|
foo();
|
|
} catch (err) { }
|
|
`,
|
|
{
|
|
code: `
|
|
try {
|
|
foo();
|
|
} catch ({ err }) {
|
|
throw err;
|
|
}
|
|
`,
|
|
languageOptions: { ecmaVersion: 6 },
|
|
},
|
|
{
|
|
code: `
|
|
try {
|
|
foo();
|
|
} catch ([ err ]) {
|
|
throw err;
|
|
}
|
|
`,
|
|
languageOptions: { ecmaVersion: 6 },
|
|
},
|
|
{
|
|
code: `
|
|
async () => {
|
|
try {
|
|
await doSomething();
|
|
} catch (e) {
|
|
doSomethingAfterCatch();
|
|
throw e;
|
|
}
|
|
}
|
|
`,
|
|
languageOptions: { ecmaVersion: 8 },
|
|
},
|
|
{
|
|
code: `
|
|
try {
|
|
throw new Error('foo');
|
|
} catch {
|
|
throw new Error('foo');
|
|
}
|
|
`,
|
|
languageOptions: { ecmaVersion: 2019 },
|
|
},
|
|
],
|
|
invalid: [
|
|
{
|
|
code: `
|
|
try {
|
|
foo();
|
|
} catch (err) {
|
|
throw err;
|
|
}
|
|
`,
|
|
errors: [
|
|
{
|
|
messageId: "unnecessaryCatch",
|
|
line: 2,
|
|
column: 17,
|
|
endLine: 6,
|
|
endColumn: 18,
|
|
},
|
|
],
|
|
},
|
|
{
|
|
code: `
|
|
try {
|
|
foo();
|
|
} catch (err) {
|
|
throw err;
|
|
} finally {
|
|
foo();
|
|
}
|
|
`,
|
|
errors: [
|
|
{
|
|
messageId: "unnecessaryCatchClause",
|
|
line: 4,
|
|
column: 19,
|
|
endLine: 6,
|
|
endColumn: 18,
|
|
},
|
|
],
|
|
},
|
|
{
|
|
code: `
|
|
try {
|
|
foo();
|
|
} catch (err) {
|
|
/* some comment */
|
|
throw err;
|
|
}
|
|
`,
|
|
errors: [
|
|
{
|
|
messageId: "unnecessaryCatch",
|
|
line: 2,
|
|
column: 17,
|
|
endLine: 7,
|
|
endColumn: 18,
|
|
},
|
|
],
|
|
},
|
|
{
|
|
code: `
|
|
try {
|
|
foo();
|
|
} catch (err) {
|
|
/* some comment */
|
|
throw err;
|
|
} finally {
|
|
foo();
|
|
}
|
|
`,
|
|
errors: [
|
|
{
|
|
messageId: "unnecessaryCatchClause",
|
|
line: 4,
|
|
column: 19,
|
|
endLine: 7,
|
|
endColumn: 18,
|
|
},
|
|
],
|
|
},
|
|
{
|
|
code: `
|
|
async () => {
|
|
try {
|
|
await doSomething();
|
|
} catch (e) {
|
|
throw e;
|
|
}
|
|
}
|
|
`,
|
|
languageOptions: { ecmaVersion: 8 },
|
|
errors: [
|
|
{
|
|
messageId: "unnecessaryCatch",
|
|
line: 3,
|
|
column: 21,
|
|
endLine: 7,
|
|
endColumn: 22,
|
|
},
|
|
],
|
|
},
|
|
],
|
|
});
|