* feat: allow conditional revalidation for QUERY requests
req.fresh only validated freshness for GET and HEAD, so QUERY responses never returned 304 despite a matching If-None-Match. QUERY is a safe, idempotent, cacheable method that supports conditional requests, so include it in the freshness check.
* docs: include history
---------
Co-authored-by: Sebastian Beltran <[email protected]>
* fix(respond): add Content-Length header only if Transfer-Encoding is not present
* fix(response): used get('Transfer-Encoding')
* test(res.send): covered Transfer-Encoding and Content-Length headers logic
* chore(response): removed comment
* chore(res.redirect): revert changes to focus on res.send
* test(res.send): added tests for all transfer encodings
* docs: update History.md to include bug fix for HTTP header conflict in res.send()
---------
Co-authored-by: Sebastian Beltran <[email protected]>
* fix: allow null options in app.render
* fix: ensure options are initialized to an empty object in app.render
* docs: add history entry
---------
Co-authored-by: Sebastian Beltran <[email protected]>
* fix: improve content-type handling in res.send method
* fix: ensure content-type is a string before setting charset in res.send
* fix: refactor content-type handling in res.send to use const and improve clarity
* Apply suggestion from @bjohansebas
* docs: update History.md
* structure the DOM body
* structure the DOM body
* test: add html title to redirect test
* fix: update HTML structure for include body and head tags
* docs: improve HTML structure in res.redirect() responses for better browser compatibility
---------
Co-authored-by: Sebastian Beltran <[email protected]>
Refactored `req.acceptsLanguages` to use the spread operator for passing arguments directly to `accept.languages`, eliminating the need for `.apply`. This approach improves readability and streamlines the function call.
This patch introduces the ability to control the ETag generation
through the `res.sendFile` function. Specifically, the ETag option
is wired to the application's configuration, allowing it to be
enabled or disabled based on the app's settings.
Fixes: https://github.com/expressjs/express/issues/2294
Signed-off-by: Juan José Arboleda <[email protected]>
Unified usage of ArrayBuffer.isView to comprehend Buffer and removed isView function check
Co-authored-by: Wes Todd <[email protected]>
Added Uint8Array test with encoding
fix: added history.md entry
* add test for removing user provided expires
* rework impl and tests to ignore maxAge, do not set it
this is to take into account the built-in relative expires when passing
a maxAge to res.cookie
I realized that using maxAge to invalidate cookies inherrently hit this
relativee expires behavior, and the goal of this PR is not to rework
that relative expires behavior w/ maxAge, but to prevent users from
overwriting these values by accident when clearing cookies
* update history.md
* explicitly delete maxAge instead of setting as undefined
* drop the spread, use object.assign
* wording, review comment on history.md
Co-authored-by: Chris de Almeida <[email protected]>
* ♻️ use spread, update supported ecmascript version
---------
Co-authored-by: Chris de Almeida <[email protected]>
* check status code is integer, or string integer, in range
* fix tests, update jsdoc comment for res.status
* throw if number is string
* narrow valid range to between 1xx and 5xx
* disambiguate the error message
* update skipped tests, remove invalid string test
* remove invalid float test
* fixup! remove invalid float test
* fix invalid range tests error assertions
* remove unused deprecate function
* add test to assert on 200.00 coming through as 200
this is the behavior of node's underlying HTTP module
* revert back to throwing only on > 999 and < 100
* update implementation for > 999
* add test for 700 status code
* update history with change
* update jsdoc
* clarify jsdoc comment
* one more round of jsdoc
* update 501 test
* add invalid status code test for res.sendStatus
* add test describe block for valid range
* fixup! add test describe block for valid range
* reduce the describe nesting
* switch to testing status 100, to avoid 100-continue behavior
* fix 900 test
* stringify code in thrown RangeError message
* remove accidentally duplicated res.status method
* fix error range message
Co-authored-by: Chris de Almeida <[email protected]>
* update sendStatus invalid code test to use sendStatus
---------
Co-authored-by: Chris de Almeida <[email protected]>
* add deprecation notice for res.clearCookie maxAge/expires
* update History.md for clearCookie deprecation change
* add tests to codify deprecated behavior
Co-authored-by: Chris de Almeida <[email protected]>
---------
Co-authored-by: Chris de Almeida <[email protected]>
`app.cache`, `app.engines`, and `app.settings` are now created with
`Object.create(null)` instead of `{}`.
This also updates a test to ensure that `app.locals` is created the same
way.
