mirror of
https://github.com/hanzoai/forge.git
synced 2026-10-30 15:00:39 +00:00
zeekayandHanzo Dev
ee51373566
Path parameters were read through chi from all over the codebase. They are read
through modules/web.RouteContext now, and chi is confined to five files.
The realisation that made this small: chi was never doing the hard part.
router_path.go has always compiled our own patterns to regexps and captured
groups itself — the 48 regex-constrained routes ({sha:([a-f0-9]{7,64})},
{ball_type:tarball|zipball|bundle}) are ours, not chi features. chi was holding
three fields on the way through: routed method, captured params, matched
patterns. Depending on a router for those made the router look load-bearing.
modules/web/route_context.go the type: method, params, patterns
router_path.go matchPath fills it directly; chi-free
base_path.go PathParam/SetPathParam read and write it —
the choke point every handler goes through
qos, blockexpensive, tracing read RoutePattern from it
contexttest builds one, so a mock request looks routed
RoutePattern collapses the "/*" each Mount contributes, which is what chi did
and what makes the value the pattern a person would have written — logs and
metrics group by it.
What is still chi, and honestly: the mux in modules/web/router.go, the route
tables that feed it, and one BeforeRouting middleware that sets the path the mux
routes ON. Replacing it means a router for 1333 routes including those 48 regex
patterns — stdlib ServeMux cannot express them, and zip is fiber/fasthttp, so
zip-native means moving the whole web layer off net/http. That is a real
decision, not a rename, and it is now a decision about one file.
models, modules, services, routers green; integration compile gate green.
Co-authored-by: Hanzo Dev <[email protected]>
65 lines
1.4 KiB
Go
65 lines
1.4 KiB
Go
// Copyright 2026 Hanzo AI, Inc. All rights reserved.
|
|
// Copyright 2025 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package common
|
|
|
|
import (
|
|
"github.com/hanzoai/git/modules/web"
|
|
"testing"
|
|
|
|
user_model "github.com/hanzoai/git/models/user"
|
|
"github.com/hanzoai/git/modules/web/middleware"
|
|
"github.com/hanzoai/git/services/contexttest"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestRequestPriority(t *testing.T) {
|
|
type test struct {
|
|
Name string
|
|
User *user_model.User
|
|
RoutePattern string
|
|
Expected Priority
|
|
}
|
|
|
|
cases := []test{
|
|
{
|
|
Name: "Logged In",
|
|
User: &user_model.User{},
|
|
Expected: HighPriority,
|
|
},
|
|
{
|
|
Name: "Sign In",
|
|
RoutePattern: "/user/login",
|
|
Expected: DefaultPriority,
|
|
},
|
|
{
|
|
Name: "Repo Home",
|
|
RoutePattern: "/{username}/{reponame}",
|
|
Expected: DefaultPriority,
|
|
},
|
|
{
|
|
Name: "User Repo",
|
|
RoutePattern: "/{username}/{reponame}/src/branch/main",
|
|
Expected: LowPriority,
|
|
},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
t.Run(tc.Name, func(t *testing.T) {
|
|
ctx, _ := contexttest.MockContext(t, "")
|
|
|
|
if tc.User != nil {
|
|
data := middleware.GetContextData(ctx)
|
|
data[middleware.ContextDataKeySignedUser] = tc.User
|
|
}
|
|
|
|
rctx := web.GetRouteContext(ctx)
|
|
rctx.RoutePatterns = []string{tc.RoutePattern}
|
|
|
|
assert.Exactly(t, tc.Expected, requestPriority(ctx))
|
|
})
|
|
}
|
|
}
|