mirror of
https://github.com/hanzoai/forge.git
synced 2026-10-30 15:00:39 +00:00
zeekayandHanzo Dev
1ed3377dce
modules/web/mux.go routes the 1333 routes. chi is no longer imported anywhere in
our source.
A tree over path segments, each node trying children by specificity: exact
segment, then patterned segments in registration order, then a trailing
wildcard. That ordering is the contract — "/user/settings" must beat
"/{username}" or a user named "settings" takes over the settings page — and
matching BACKTRACKS, because a segment can match here and fail deeper while the
next candidate at this level still has to be tried.
Four segment shapes, all of which this codebase actually uses:
users static
{id} whole segment (577)
{sha:[a-f0-9]+} regexp-constrained (43)
PACKAGES{format} parameter mid-segment (CRAN indexes)
* trailing wildcard (131)
A plain {name} carries no regexp. It is the overwhelming majority, and it does
not need one to match a whole segment.
The tests are the point of this commit, not the code. Each case is a way a
router can be wrong that a passing build will not reveal: static beating a
param, a regexp declining and the NEXT candidate winning (/repo/zzz is not a
sha, but "repo" is a legal username), a wildcard capturing the remainder,
"/*" matching "/" itself, HEAD falling back to GET, and — the one that matters
most — a failed branch leaving NO captured parameters behind for the branch
tried next.
Three things this turned up while wiring it in:
Mount had to strip its prefix. A sub-router mounted at "/v1" writes its
patterns relative to it, so handing it the full path matches nothing.
chi_middleware.GetHead was deleted rather than reimplemented: Mux.handlerFor
already falls back from HEAD to GET, so keeping it would have been two
implementations of one rule.
ChiRoutePathHandler is now RoutePathHandler and sets RouteContext.RoutePath.
It exists so a "%2f" inside a parameter routes as one segment — without it a
branch called "feat/x" splits and matches the wrong handler.
The vendored middleware tests used chi to register two routes each; they use a
small stdlib ServeMux shim now. modules/web imports modules/binding, so those
tests cannot import web back.
github.com/go-chi/chi/v5 remains in go.mod as an INDIRECT dependency of
markbates/goth/gothic, which drives every OAuth2 login. That is goth pulling it,
not us.
Everything green; integration compile gate green.
Co-authored-by: Hanzo Dev <[email protected]>
210 lines
5.2 KiB
Go
210 lines
5.2 KiB
Go
// Copyright 2026 Hanzo AI, Inc. All rights reserved.
|
|
// Copyright 2014 The Macaron Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License"): you may
|
|
// not use this file except in compliance with the License. You may obtain
|
|
// a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
// License for the specific language governing permissions and limitations
|
|
// under the License.
|
|
|
|
package session
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
. "github.com/smartystreets/goconvey/convey"
|
|
)
|
|
|
|
func Test_Sessioner(t *testing.T) {
|
|
Convey("Use session middleware", t, func() {
|
|
c := newTestRouter()
|
|
sessioner, err := Sessioner()
|
|
So(err, ShouldBeNil)
|
|
c.Use(sessioner)
|
|
c.Get("/", func(resp http.ResponseWriter, req *http.Request) {})
|
|
|
|
resp := httptest.NewRecorder()
|
|
req, err := http.NewRequest("GET", "/", nil)
|
|
So(err, ShouldBeNil)
|
|
c.ServeHTTP(resp, req)
|
|
})
|
|
|
|
Convey("Register invalid provider", t, func() {
|
|
Convey("Provider not exists", func() {
|
|
_, err := Sessioner(Options{
|
|
Provider: "fake",
|
|
})
|
|
So(err, ShouldNotBeNil)
|
|
})
|
|
|
|
Convey("Provider value is nil", func() {
|
|
defer func() {
|
|
So(recover(), ShouldNotBeNil)
|
|
}()
|
|
|
|
Register("fake", nil)
|
|
})
|
|
|
|
Convey("Register twice", func() {
|
|
defer func() {
|
|
So(recover(), ShouldNotBeNil)
|
|
}()
|
|
|
|
Register("memory", &MemProvider{})
|
|
})
|
|
})
|
|
}
|
|
|
|
func testProvider(opt Options) {
|
|
Convey("Basic operation", func() {
|
|
c := newTestRouter()
|
|
sessioner, err := Sessioner(opt)
|
|
So(err, ShouldBeNil)
|
|
c.Use(sessioner)
|
|
var initialSid string
|
|
|
|
c.Get("/", func(resp http.ResponseWriter, req *http.Request) {
|
|
sess := GetSession(req)
|
|
sess.Set("uname", "unknwon")
|
|
initialSid = sess.ID()
|
|
})
|
|
c.Get("/reg", func(resp http.ResponseWriter, req *http.Request) {
|
|
sess := GetSession(req)
|
|
So(initialSid, ShouldEqual, sess.ID())
|
|
raw, err := RegenerateSession(resp, req)
|
|
So(err, ShouldBeNil)
|
|
So(sess, ShouldNotBeNil)
|
|
So(sess, ShouldEqual, raw)
|
|
|
|
So(initialSid, ShouldNotEqual, sess.ID())
|
|
|
|
uname := sess.Get("uname")
|
|
So(uname, ShouldNotBeNil)
|
|
So(uname, ShouldEqual, "unknwon")
|
|
|
|
sess.Set("uname", "lunny")
|
|
uname = sess.Get("uname")
|
|
So(uname, ShouldNotBeNil)
|
|
So(uname, ShouldEqual, "lunny")
|
|
})
|
|
c.Get("/get", func(resp http.ResponseWriter, req *http.Request) {
|
|
sess := GetSession(req)
|
|
sid := sess.ID()
|
|
So(sid, ShouldNotBeEmpty)
|
|
|
|
raw, err := sess.Read(sid)
|
|
So(err, ShouldBeNil)
|
|
So(raw, ShouldNotBeNil)
|
|
|
|
uname := sess.Get("uname")
|
|
So(uname, ShouldNotBeNil)
|
|
So(uname, ShouldEqual, "lunny")
|
|
|
|
So(sess.Delete("uname"), ShouldBeNil)
|
|
So(sess.Get("uname"), ShouldBeNil)
|
|
|
|
So(sess.Destroy(resp, req), ShouldBeNil)
|
|
})
|
|
|
|
resp := httptest.NewRecorder()
|
|
req, err := http.NewRequest("GET", "/", nil)
|
|
So(err, ShouldBeNil)
|
|
c.ServeHTTP(resp, req)
|
|
|
|
cookie := resp.Header().Get("Set-Cookie")
|
|
|
|
resp = httptest.NewRecorder()
|
|
req, err = http.NewRequest("GET", "/reg", nil)
|
|
So(err, ShouldBeNil)
|
|
req.Header.Set("Cookie", cookie)
|
|
c.ServeHTTP(resp, req)
|
|
|
|
cookie = resp.Header().Get("Set-Cookie")
|
|
|
|
resp = httptest.NewRecorder()
|
|
req, err = http.NewRequest("GET", "/get", nil)
|
|
So(err, ShouldBeNil)
|
|
req.Header.Set("Cookie", cookie)
|
|
c.ServeHTTP(resp, req)
|
|
})
|
|
|
|
Convey("Regenrate empty session", func() {
|
|
c := newTestRouter()
|
|
sessioner, err := Sessioner(opt)
|
|
So(err, ShouldBeNil)
|
|
c.Use(sessioner)
|
|
c.Get("/", func(resp http.ResponseWriter, req *http.Request) {
|
|
sess := GetSession(req)
|
|
raw, err := sess.RegenerateID(resp, req)
|
|
So(err, ShouldBeNil)
|
|
So(raw, ShouldNotBeNil)
|
|
})
|
|
|
|
resp := httptest.NewRecorder()
|
|
req, err := http.NewRequest("GET", "/", nil)
|
|
So(err, ShouldBeNil)
|
|
req.Header.Set("Cookie", "MacaronSession=ad2c7e3cbecfcf48; Path=/;")
|
|
c.ServeHTTP(resp, req)
|
|
})
|
|
|
|
Convey("GC session", func() {
|
|
c := newTestRouter()
|
|
opt2 := opt
|
|
opt2.Gclifetime = 1
|
|
sessioner, err := Sessioner(opt2)
|
|
So(err, ShouldBeNil)
|
|
c.Use(sessioner)
|
|
|
|
c.Get("/", func(resp http.ResponseWriter, req *http.Request) {
|
|
sess := GetSession(req)
|
|
sess.Set("uname", "unknwon")
|
|
So(sess.ID(), ShouldNotBeEmpty)
|
|
uname := sess.Get("uname")
|
|
So(uname, ShouldNotBeNil)
|
|
So(uname, ShouldEqual, "unknwon")
|
|
|
|
So(sess.Flush(), ShouldBeNil)
|
|
So(sess.Get("uname"), ShouldBeNil)
|
|
|
|
time.Sleep(2 * time.Second)
|
|
sess.GC()
|
|
count, err := sess.Count()
|
|
So(count, ShouldEqual, 0)
|
|
So(err, ShouldBeNil)
|
|
})
|
|
|
|
resp := httptest.NewRecorder()
|
|
req, err := http.NewRequest("GET", "/", nil)
|
|
So(err, ShouldBeNil)
|
|
c.ServeHTTP(resp, req)
|
|
})
|
|
|
|
Convey("Detect invalid sid", func() {
|
|
c := newTestRouter()
|
|
sessioner, err := Sessioner(opt)
|
|
So(err, ShouldBeNil)
|
|
c.Use(sessioner)
|
|
c.Get("/", func(resp http.ResponseWriter, req *http.Request) {
|
|
sess := GetSession(req)
|
|
raw, err := sess.Read("../session/ad2c7e3cbecfcf486")
|
|
So(strings.Contains(err.Error(), "invalid 'sid': "), ShouldBeTrue)
|
|
So(raw, ShouldBeNil)
|
|
})
|
|
|
|
resp := httptest.NewRecorder()
|
|
req, err := http.NewRequest("GET", "/", nil)
|
|
So(err, ShouldBeNil)
|
|
c.ServeHTTP(resp, req)
|
|
})
|
|
}
|