mirror of
https://github.com/hanzoai/forge.git
synced 2026-10-30 15:00:39 +00:00
zeekayandHanzo Dev
1ed3377dce
modules/web/mux.go routes the 1333 routes. chi is no longer imported anywhere in
our source.
A tree over path segments, each node trying children by specificity: exact
segment, then patterned segments in registration order, then a trailing
wildcard. That ordering is the contract — "/user/settings" must beat
"/{username}" or a user named "settings" takes over the settings page — and
matching BACKTRACKS, because a segment can match here and fail deeper while the
next candidate at this level still has to be tried.
Four segment shapes, all of which this codebase actually uses:
users static
{id} whole segment (577)
{sha:[a-f0-9]+} regexp-constrained (43)
PACKAGES{format} parameter mid-segment (CRAN indexes)
* trailing wildcard (131)
A plain {name} carries no regexp. It is the overwhelming majority, and it does
not need one to match a whole segment.
The tests are the point of this commit, not the code. Each case is a way a
router can be wrong that a passing build will not reveal: static beating a
param, a regexp declining and the NEXT candidate winning (/repo/zzz is not a
sha, but "repo" is a legal username), a wildcard capturing the remainder,
"/*" matching "/" itself, HEAD falling back to GET, and — the one that matters
most — a failed branch leaving NO captured parameters behind for the branch
tried next.
Three things this turned up while wiring it in:
Mount had to strip its prefix. A sub-router mounted at "/v1" writes its
patterns relative to it, so handing it the full path matches nothing.
chi_middleware.GetHead was deleted rather than reimplemented: Mux.handlerFor
already falls back from HEAD to GET, so keeping it would have been two
implementations of one rule.
ChiRoutePathHandler is now RoutePathHandler and sets RouteContext.RoutePath.
It exists so a "%2f" inside a parameter routes as one segment — without it a
branch called "feat/x" splits and matches the wrong handler.
The vendored middleware tests used chi to register two routes each; they use a
small stdlib ServeMux shim now. modules/web imports modules/binding, so those
tests cannot import web back.
github.com/go-chi/chi/v5 remains in go.mod as an INDIRECT dependency of
markbates/goth/gothic, which drives every OAuth2 login. That is goth pulling it,
not us.
Everything green; integration compile gate green.
Co-authored-by: Hanzo Dev <[email protected]>
315 lines
9.3 KiB
Go
315 lines
9.3 KiB
Go
// Copyright 2026 Hanzo AI, Inc. All rights reserved.
|
|
// Copyright 2014 Martini Authors
|
|
// Copyright 2014 The Macaron Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License"): you may
|
|
// not use this file except in compliance with the License. You may obtain
|
|
// a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
// License for the specific language governing permissions and limitations
|
|
// under the License.
|
|
|
|
package binding
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
var formTestCases = []formTestCase{
|
|
{
|
|
description: "Happy path",
|
|
shouldSucceed: true,
|
|
payload: `title=Glorious+Post+Title&content=Lorem+ipsum+dolor+sit+amet`,
|
|
contentType: formContentType,
|
|
expected: Post{Title: "Glorious Post Title", Content: "Lorem ipsum dolor sit amet"},
|
|
},
|
|
{
|
|
description: "Happy path with interface",
|
|
shouldSucceed: true,
|
|
withInterface: true,
|
|
payload: `title=Glorious+Post+Title&content=Lorem+ipsum+dolor+sit+amet`,
|
|
contentType: formContentType,
|
|
expected: Post{Title: "Glorious Post Title", Content: "Lorem ipsum dolor sit amet"},
|
|
},
|
|
{
|
|
description: "Empty payload",
|
|
shouldSucceed: false,
|
|
payload: ``,
|
|
contentType: formContentType,
|
|
expected: Post{},
|
|
},
|
|
{
|
|
description: "Empty content type",
|
|
shouldSucceed: false,
|
|
payload: `title=Glorious+Post+Title&content=Lorem+ipsum+dolor+sit+amet`,
|
|
contentType: ``,
|
|
expected: Post{},
|
|
},
|
|
{
|
|
description: "Malformed form body",
|
|
shouldSucceed: false,
|
|
payload: `title=%2`,
|
|
contentType: formContentType,
|
|
expected: Post{},
|
|
},
|
|
{
|
|
description: "With nested and embedded structs",
|
|
shouldSucceed: true,
|
|
payload: `title=Glorious+Post+Title&id=1&name=Matt+Holt`,
|
|
contentType: formContentType,
|
|
expected: BlogPost{Post: Post{Title: "Glorious Post Title"}, Id: 1, Author: Person{Name: "Matt Holt"}},
|
|
},
|
|
{
|
|
description: "Required embedded struct field not specified",
|
|
shouldSucceed: false,
|
|
payload: `id=1&name=Matt+Holt`,
|
|
contentType: formContentType,
|
|
expected: BlogPost{Id: 1, Author: Person{Name: "Matt Holt"}},
|
|
},
|
|
{
|
|
description: "Required nested struct field not specified",
|
|
shouldSucceed: false,
|
|
payload: `title=Glorious+Post+Title&id=1`,
|
|
contentType: formContentType,
|
|
expected: BlogPost{Post: Post{Title: "Glorious Post Title"}, Id: 1},
|
|
},
|
|
{
|
|
description: "Multiple values into slice",
|
|
shouldSucceed: true,
|
|
payload: `title=Glorious+Post+Title&id=1&name=Matt+Holt&rating=4&rating=3&rating=5`,
|
|
contentType: formContentType,
|
|
expected: BlogPost{Post: Post{Title: "Glorious Post Title"}, Id: 1, Author: Person{Name: "Matt Holt"}, Ratings: []int{4, 3, 5}},
|
|
},
|
|
{
|
|
description: "Unexported field",
|
|
shouldSucceed: true,
|
|
payload: `title=Glorious+Post+Title&id=1&name=Matt+Holt&unexported=foo`,
|
|
contentType: formContentType,
|
|
expected: BlogPost{Post: Post{Title: "Glorious Post Title"}, Id: 1, Author: Person{Name: "Matt Holt"}},
|
|
},
|
|
{
|
|
description: "Query string POST",
|
|
shouldSucceed: true,
|
|
payload: `title=Glorious+Post+Title&content=Lorem+ipsum+dolor+sit+amet`,
|
|
contentType: formContentType,
|
|
expected: Post{Title: "Glorious Post Title", Content: "Lorem ipsum dolor sit amet"},
|
|
},
|
|
{
|
|
description: "Query string with Content-Type (POST request)",
|
|
shouldSucceed: true,
|
|
queryString: "?title=Glorious+Post+Title&content=Lorem+ipsum+dolor+sit+amet",
|
|
payload: ``,
|
|
contentType: formContentType,
|
|
expected: Post{Title: "Glorious Post Title", Content: "Lorem ipsum dolor sit amet"},
|
|
},
|
|
{
|
|
description: "Query string without Content-Type (GET request)",
|
|
shouldSucceed: true,
|
|
method: "GET",
|
|
queryString: "?title=Glorious+Post+Title&content=Lorem+ipsum+dolor+sit+amet",
|
|
payload: ``,
|
|
expected: Post{Title: "Glorious Post Title", Content: "Lorem ipsum dolor sit amet"},
|
|
},
|
|
{
|
|
description: "Embed struct pointer",
|
|
shouldSucceed: true,
|
|
deepEqual: true,
|
|
method: "GET",
|
|
queryString: "?name=Glorious+Post+Title&email=Lorem+ipsum+dolor+sit+amet",
|
|
payload: ``,
|
|
expected: EmbedPerson{&Person{Name: "Glorious Post Title", Email: "Lorem ipsum dolor sit amet"}},
|
|
},
|
|
{
|
|
description: "Embed struct pointer remain nil if not binded",
|
|
shouldSucceed: true,
|
|
deepEqual: true,
|
|
method: "GET",
|
|
queryString: "?",
|
|
payload: ``,
|
|
expected: EmbedPerson{nil},
|
|
},
|
|
{
|
|
description: "Custom error handler",
|
|
shouldSucceed: true,
|
|
deepEqual: true,
|
|
method: "GET",
|
|
queryString: "?",
|
|
payload: ``,
|
|
expected: CustomErrorHandle{},
|
|
},
|
|
{
|
|
description: "pointer form",
|
|
shouldSucceed: true,
|
|
deepEqual: true,
|
|
payload: fmt.Sprintf("Id=%d&IdPointer=%d&Url=%s&UrlPointer=%s&AlphaDash=%s&AlphaDashPointer=%s", idInt, idInt, urlStr, urlStr, alphaDashStr, alphaDashStr),
|
|
contentType: formContentType,
|
|
expected: PointerForm{Id: idInt, IdPointer: &idInt, Url: urlStr, UrlPointer: &urlStr, AlphaDash: alphaDashStr, AlphaDashPointer: &alphaDashStr},
|
|
},
|
|
}
|
|
|
|
func init() {
|
|
AddRule(&Rule{
|
|
func(rule string) bool {
|
|
return rule == "CustomRule"
|
|
},
|
|
func(errs Errors, _ string, _ interface{}) (bool, Errors) {
|
|
return false, errs
|
|
},
|
|
})
|
|
SetNameMapper(nameMapper)
|
|
}
|
|
|
|
func Test_Form(t *testing.T) {
|
|
for _, testCase := range formTestCases {
|
|
t.Run(testCase.description, func(t *testing.T) {
|
|
performFormTest(t, Form, testCase)
|
|
})
|
|
}
|
|
}
|
|
|
|
func performFormTest(t *testing.T, binder handlerFunc, testCase formTestCase) {
|
|
resp := httptest.NewRecorder()
|
|
m := newTestRouter()
|
|
|
|
formTestHandler := func(actual interface{}, errs Errors) {
|
|
if testCase.shouldSucceed {
|
|
assert.Empty(t, errs)
|
|
} else if !testCase.shouldSucceed {
|
|
assert.NotEmpty(t, errs)
|
|
}
|
|
expString := fmt.Sprintf("%+v", testCase.expected)
|
|
actString := fmt.Sprintf("%+v", actual)
|
|
if actString != expString && !(testCase.deepEqual && reflect.DeepEqual(testCase.expected, actual)) {
|
|
assert.EqualValues(t, expString, actString)
|
|
}
|
|
}
|
|
|
|
switch testCase.expected.(type) {
|
|
case Post:
|
|
if testCase.withInterface {
|
|
m.Post(testRoute, func(resp http.ResponseWriter, req *http.Request) {
|
|
var actual Post
|
|
errs := binder(req, &actual)
|
|
p := testCase.expected.(Post)
|
|
assert.EqualValues(t, p.Title, actual.Title)
|
|
formTestHandler(actual, errs)
|
|
})
|
|
} else {
|
|
m.Post(testRoute, func(resp http.ResponseWriter, req *http.Request) {
|
|
var actual Post
|
|
errs := binder(req, &actual)
|
|
formTestHandler(actual, errs)
|
|
})
|
|
m.Get(testRoute, func(resp http.ResponseWriter, req *http.Request) {
|
|
var actual Post
|
|
errs := binder(req, &actual)
|
|
formTestHandler(actual, errs)
|
|
})
|
|
}
|
|
|
|
case BlogPost:
|
|
if testCase.withInterface {
|
|
m.Post(testRoute, func(resp http.ResponseWriter, req *http.Request) {
|
|
var actual BlogPost
|
|
errs := binder(req, &actual)
|
|
p := testCase.expected.(BlogPost)
|
|
assert.EqualValues(t, p.Title, actual.Title)
|
|
formTestHandler(actual, errs)
|
|
})
|
|
} else {
|
|
m.Post(testRoute, func(resp http.ResponseWriter, req *http.Request) {
|
|
var actual BlogPost
|
|
errs := binder(req, &actual)
|
|
formTestHandler(actual, errs)
|
|
})
|
|
}
|
|
|
|
case EmbedPerson:
|
|
m.Post(testRoute, func(resp http.ResponseWriter, req *http.Request) {
|
|
var actual EmbedPerson
|
|
errs := binder(req, &actual)
|
|
formTestHandler(actual, errs)
|
|
})
|
|
m.Get(testRoute, func(resp http.ResponseWriter, req *http.Request) {
|
|
var actual EmbedPerson
|
|
errs := binder(req, &actual)
|
|
formTestHandler(actual, errs)
|
|
})
|
|
case CustomErrorHandle:
|
|
m.Get(testRoute, func(resp http.ResponseWriter, req *http.Request) {
|
|
var actual CustomErrorHandle
|
|
errs := binder(req, &actual)
|
|
formTestHandler(actual, errs)
|
|
})
|
|
case PointerForm:
|
|
m.Post(testRoute, func(resp http.ResponseWriter, req *http.Request) {
|
|
var actual PointerForm
|
|
errs := binder(req, &actual)
|
|
formTestHandler(actual, errs)
|
|
})
|
|
}
|
|
|
|
if len(testCase.method) == 0 {
|
|
testCase.method = "POST"
|
|
}
|
|
|
|
req, err := http.NewRequest(testCase.method, testRoute+testCase.queryString, strings.NewReader(testCase.payload))
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
req.Header.Set("Content-Type", testCase.contentType)
|
|
|
|
m.ServeHTTP(resp, req)
|
|
|
|
switch resp.Code {
|
|
case http.StatusNotFound:
|
|
panic("Routing is messed up in test fixture (got 404): check methods and paths")
|
|
case http.StatusInternalServerError:
|
|
panic("Something bad happened on '" + testCase.description + "'")
|
|
}
|
|
}
|
|
|
|
type (
|
|
formTestCase struct {
|
|
description string
|
|
shouldSucceed bool
|
|
deepEqual bool
|
|
withInterface bool
|
|
queryString string
|
|
payload string
|
|
contentType string
|
|
expected interface{}
|
|
method string
|
|
}
|
|
)
|
|
|
|
type defaultForm struct {
|
|
Default string `binding:"Default(hello world)"`
|
|
}
|
|
|
|
func Test_Default(t *testing.T) {
|
|
m := newTestRouter()
|
|
m.Get("/", func(resp http.ResponseWriter, req *http.Request) {
|
|
var f defaultForm
|
|
Bind(req, &f)
|
|
assert.EqualValues(t, "hello world", f.Default)
|
|
})
|
|
resp := httptest.NewRecorder()
|
|
req, err := http.NewRequest("GET", "/", nil)
|
|
assert.Nil(t, err)
|
|
|
|
m.ServeHTTP(resp, req)
|
|
}
|