mirror of
https://github.com/hanzoai/forge.git
synced 2026-10-30 15:00:39 +00:00
zeekayandHanzo Dev
27cde39e36
Storage buckets, indexer names, the bleve analyzer, the lock prefix, SSH host keys, the markdown front-matter key, the container data paths, the RPM repo id and the API security scheme all read as this product now, and app.example.ini matches the code again. The upstream maintainer list and the changelog generator config went with the release history they belonged to, and the citation comments state the fact rather than link the issue. Three inert rules turn out to have been inert because they named a module path this tree does not use: gci grouped no first-party imports under prefix(), and depguard let models/migrations import models and modules/structs. They now name github.com/hanzoai/git. The config example also documented .gitea/workflows while the code has read .hanzo/workflows for some time. The authorized_keys marker follows the delegate-hook precedent: the new name is written and the old one is still recognised, because a marker we do not know is copied through as a hand-added key and leaves a revoked key authorized. The stored user_setting key keeps its value; only a migration may change that. Co-authored-by: Hanzo Dev <[email protected]>
313 lines
7.9 KiB
Go
313 lines
7.9 KiB
Go
// Copyright 2026 Hanzo AI, Inc. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package setting
|
|
|
|
import (
|
|
"path/filepath"
|
|
"slices"
|
|
"testing"
|
|
|
|
"github.com/hanzoai/git/modules/test"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func Test_getStorageInheritNameSectionTypeForActions(t *testing.T) {
|
|
iniStr := `
|
|
[storage]
|
|
STORAGE_TYPE = s3
|
|
`
|
|
cfg, err := NewConfigProviderFromData(iniStr)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, loadActionsFrom(cfg))
|
|
|
|
assert.EqualValues(t, "s3", Actions.LogStorage.Type)
|
|
assert.Equal(t, "actions_log/", Actions.LogStorage.S3Config.BasePath)
|
|
assert.EqualValues(t, "s3", Actions.ArtifactStorage.Type)
|
|
assert.Equal(t, "actions_artifacts/", Actions.ArtifactStorage.S3Config.BasePath)
|
|
|
|
iniStr = `
|
|
[storage.actions_log]
|
|
STORAGE_TYPE = s3
|
|
`
|
|
cfg, err = NewConfigProviderFromData(iniStr)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, loadActionsFrom(cfg))
|
|
|
|
assert.EqualValues(t, "s3", Actions.LogStorage.Type)
|
|
assert.Equal(t, "actions_log/", Actions.LogStorage.S3Config.BasePath)
|
|
assert.EqualValues(t, "local", Actions.ArtifactStorage.Type)
|
|
assert.Equal(t, "actions_artifacts", filepath.Base(Actions.ArtifactStorage.Path))
|
|
|
|
iniStr = `
|
|
[storage.actions_log]
|
|
STORAGE_TYPE = my_storage
|
|
|
|
[storage.my_storage]
|
|
STORAGE_TYPE = s3
|
|
`
|
|
cfg, err = NewConfigProviderFromData(iniStr)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, loadActionsFrom(cfg))
|
|
|
|
assert.EqualValues(t, "s3", Actions.LogStorage.Type)
|
|
assert.Equal(t, "actions_log/", Actions.LogStorage.S3Config.BasePath)
|
|
assert.EqualValues(t, "local", Actions.ArtifactStorage.Type)
|
|
assert.Equal(t, "actions_artifacts", filepath.Base(Actions.ArtifactStorage.Path))
|
|
|
|
iniStr = `
|
|
[storage.actions_artifacts]
|
|
STORAGE_TYPE = my_storage
|
|
|
|
[storage.my_storage]
|
|
STORAGE_TYPE = s3
|
|
`
|
|
cfg, err = NewConfigProviderFromData(iniStr)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, loadActionsFrom(cfg))
|
|
|
|
assert.EqualValues(t, "local", Actions.LogStorage.Type)
|
|
assert.Equal(t, "actions_log", filepath.Base(Actions.LogStorage.Path))
|
|
assert.EqualValues(t, "s3", Actions.ArtifactStorage.Type)
|
|
assert.Equal(t, "actions_artifacts/", Actions.ArtifactStorage.S3Config.BasePath)
|
|
|
|
iniStr = `
|
|
[storage.actions_artifacts]
|
|
STORAGE_TYPE = my_storage
|
|
|
|
[storage.my_storage]
|
|
STORAGE_TYPE = s3
|
|
`
|
|
cfg, err = NewConfigProviderFromData(iniStr)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, loadActionsFrom(cfg))
|
|
|
|
assert.EqualValues(t, "local", Actions.LogStorage.Type)
|
|
assert.Equal(t, "actions_log", filepath.Base(Actions.LogStorage.Path))
|
|
assert.EqualValues(t, "s3", Actions.ArtifactStorage.Type)
|
|
assert.Equal(t, "actions_artifacts/", Actions.ArtifactStorage.S3Config.BasePath)
|
|
|
|
iniStr = ``
|
|
cfg, err = NewConfigProviderFromData(iniStr)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, loadActionsFrom(cfg))
|
|
|
|
assert.EqualValues(t, "local", Actions.LogStorage.Type)
|
|
assert.Equal(t, "actions_log", filepath.Base(Actions.LogStorage.Path))
|
|
assert.EqualValues(t, "local", Actions.ArtifactStorage.Type)
|
|
assert.Equal(t, "actions_artifacts", filepath.Base(Actions.ArtifactStorage.Path))
|
|
}
|
|
|
|
func Test_WorkflowDirs(t *testing.T) {
|
|
oldActions := Actions
|
|
defer func() {
|
|
Actions = oldActions
|
|
}()
|
|
|
|
tests := []struct {
|
|
name string
|
|
iniStr string
|
|
wantDirs []string
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "default",
|
|
iniStr: `[actions]`,
|
|
// .hanzo/workflows leads: the native dir wins over mirrored upstream dirs
|
|
wantDirs: []string{".hanzo/workflows", ".github/workflows"},
|
|
},
|
|
{
|
|
name: "single dir",
|
|
iniStr: "[actions]\nWORKFLOW_DIRS = .github/workflows",
|
|
wantDirs: []string{".github/workflows"},
|
|
},
|
|
{
|
|
name: "custom order",
|
|
iniStr: "[actions]\nWORKFLOW_DIRS = .github/workflows,.hanzo/workflows",
|
|
wantDirs: []string{".github/workflows", ".hanzo/workflows"},
|
|
},
|
|
{
|
|
name: "whitespace trimming",
|
|
iniStr: "[actions]\nWORKFLOW_DIRS = .hanzo/workflows , .github/workflows ",
|
|
wantDirs: []string{".hanzo/workflows", ".github/workflows"},
|
|
},
|
|
{
|
|
name: "trailing slash normalization",
|
|
iniStr: "[actions]\nWORKFLOW_DIRS = .hanzo/workflows/,.github/workflows/",
|
|
wantDirs: []string{".hanzo/workflows", ".github/workflows"},
|
|
},
|
|
{
|
|
name: "only commas and whitespace",
|
|
iniStr: "[actions]\nWORKFLOW_DIRS = , , ,",
|
|
wantErr: true,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
cfg, err := NewConfigProviderFromData(tt.iniStr)
|
|
require.NoError(t, err)
|
|
err = loadActionsFrom(cfg)
|
|
if tt.wantErr {
|
|
require.Error(t, err)
|
|
return
|
|
}
|
|
require.NoError(t, err)
|
|
assert.Equal(t, tt.wantDirs, Actions.WorkflowDirs)
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_getDefaultActionsURLForActions(t *testing.T) {
|
|
oldActions := Actions
|
|
oldAppURL := AppURL
|
|
defer func() {
|
|
Actions = oldActions
|
|
AppURL = oldAppURL
|
|
}()
|
|
|
|
AppURL = "http://test_get_default_actions_url_for_actions:3000/"
|
|
|
|
tests := []struct {
|
|
name string
|
|
iniStr string
|
|
wantErr assert.ErrorAssertionFunc
|
|
wantURL string
|
|
}{
|
|
{
|
|
name: "default",
|
|
iniStr: `
|
|
[actions]
|
|
`,
|
|
wantErr: assert.NoError,
|
|
wantURL: "https://github.com",
|
|
},
|
|
{
|
|
name: "github",
|
|
iniStr: `
|
|
[actions]
|
|
DEFAULT_ACTIONS_URL = github
|
|
`,
|
|
wantErr: assert.NoError,
|
|
wantURL: "https://github.com",
|
|
},
|
|
{
|
|
name: "self",
|
|
iniStr: `
|
|
[actions]
|
|
DEFAULT_ACTIONS_URL = self
|
|
`,
|
|
wantErr: assert.NoError,
|
|
wantURL: "http://test_get_default_actions_url_for_actions:3000",
|
|
},
|
|
{
|
|
name: "custom url",
|
|
iniStr: `
|
|
[actions]
|
|
DEFAULT_ACTIONS_URL = https://forge.example
|
|
`,
|
|
wantErr: assert.NoError,
|
|
wantURL: "https://github.com",
|
|
},
|
|
{
|
|
name: "custom urls",
|
|
iniStr: `
|
|
[actions]
|
|
DEFAULT_ACTIONS_URL = https://forge.example,https://github.com
|
|
`,
|
|
wantErr: assert.NoError,
|
|
wantURL: "https://github.com",
|
|
},
|
|
{
|
|
name: "invalid",
|
|
iniStr: `
|
|
[actions]
|
|
DEFAULT_ACTIONS_URL = nowhere
|
|
`,
|
|
wantErr: assert.Error,
|
|
wantURL: "https://github.com",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
cfg, err := NewConfigProviderFromData(tt.iniStr)
|
|
require.NoError(t, err)
|
|
if !tt.wantErr(t, loadActionsFrom(cfg)) {
|
|
return
|
|
}
|
|
assert.Equal(t, tt.wantURL, Actions.DefaultActionsURL.URL())
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_ScopedWorkflowDirs(t *testing.T) {
|
|
defer test.MockVariableValue(&Actions)()
|
|
|
|
defaultWorkflowDirs := []string{".hanzo/workflows", ".github/workflows"}
|
|
defaultScopedDirs := []string{".hanzo/scoped_workflows"}
|
|
|
|
tests := []struct {
|
|
name string
|
|
iniStr string
|
|
wantScoped []string
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "default",
|
|
iniStr: `[actions]`,
|
|
wantScoped: defaultScopedDirs,
|
|
},
|
|
{
|
|
name: "custom dir",
|
|
iniStr: "[actions]\nSCOPED_WORKFLOW_DIRS = .hanzo/my-scoped",
|
|
wantScoped: []string{".hanzo/my-scoped"},
|
|
},
|
|
{
|
|
name: "empty disables the feature",
|
|
iniStr: "[actions]\nSCOPED_WORKFLOW_DIRS = , ,",
|
|
wantScoped: []string{},
|
|
},
|
|
{
|
|
name: "overlap equal with workflow dir",
|
|
iniStr: "[actions]\nWORKFLOW_DIRS = .hanzo/workflows\nSCOPED_WORKFLOW_DIRS = .hanzo/workflows",
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "scoped dir nested under workflow dir",
|
|
iniStr: "[actions]\nWORKFLOW_DIRS = .hanzo/workflows\nSCOPED_WORKFLOW_DIRS = .hanzo/workflows/scoped",
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "workflow dir nested under scoped dir",
|
|
iniStr: "[actions]\nWORKFLOW_DIRS = .hanzo/workflows/ci\nSCOPED_WORKFLOW_DIRS = .hanzo/workflows",
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "no overlap",
|
|
iniStr: "[actions]\nSCOPED_WORKFLOW_DIRS = .hanzo/scoped",
|
|
wantScoped: []string{".hanzo/scoped"},
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
// reset to defaults so MapTo starts clean (absent keys keep the defaults)
|
|
Actions.WorkflowDirs = slices.Clone(defaultWorkflowDirs)
|
|
Actions.ScopedWorkflowDirs = slices.Clone(defaultScopedDirs)
|
|
|
|
cfg, err := NewConfigProviderFromData(tt.iniStr)
|
|
require.NoError(t, err)
|
|
err = loadActionsFrom(cfg)
|
|
if tt.wantErr {
|
|
require.Error(t, err)
|
|
return
|
|
}
|
|
require.NoError(t, err)
|
|
assert.Equal(t, tt.wantScoped, Actions.ScopedWorkflowDirs)
|
|
})
|
|
}
|
|
}
|