mirror of
https://github.com/hanzoai/forum.git
synced 2026-09-30 21:51:19 +00:00
Joffrey JAFFEUXandGitHub
ac56e1f5e7
Subscriptions manager have been a pain since the beginning, one of the problem is that thread and channels behave mostly the same but with various small difference which I expect to increase over time. Trying to use subclasses for this case has proven to be a mistake, this commit now uses a class for each case (channel, thread) which for now contains a lot of duplication, which might be reduced in the future but has the merit to make reasoning about each case very simple. This refactor is fixing a bug introduced in https://github.com/discourse/discourse/commit/e1e1c5dee5444adacdc3d4d3d21670d1d124fc62 which was causing the wrong channel to be unsubscribed, this shouldn't be possible anymore. We had tests for this which were disabled due to flakeyness, I will consider re-enabling them in the future. Other notes: - notices had been added to the subscriptions manager service, they have been moved into their own dedicated service: `ChatChannelNoticesManager` - the `(each model)` trick used in `<ChatChannel />` since https://github.com/discourse/discourse/commit/e1e1c5dee5444adacdc3d4d3d21670d1d124fc62 to ensure atomicity has been applied to `<ChatThread />` too
17 lines
454 B
JavaScript
17 lines
454 B
JavaScript
import { tracked } from "@glimmer/tracking";
|
|
import Service from "@ember/service";
|
|
import { TrackedArray } from "@ember-compat/tracked-built-ins";
|
|
import ChatNotice from "../models/chat-notice";
|
|
|
|
export default class ChatChannelNoticesManager extends Service {
|
|
@tracked notices = new TrackedArray();
|
|
|
|
handleNotice(data) {
|
|
this.notices.pushObject(ChatNotice.create(data));
|
|
}
|
|
|
|
clearNotice(notice) {
|
|
this.notices.removeObject(notice);
|
|
}
|
|
}
|