mirror of
https://github.com/hanzoai/gui.git
synced 2026-10-25 02:31:41 +00:00
zeekayandHanzo Dev
69c6e860d7
This repo could never sync. There was NO merge-base with tamagui — 372 commits
here against 15,791 there, unrelated histories — because it began as a
copy-paste rebrand with a flattened layout. Every "sync" since was a hand
re-application that drifted, which is why the tree sat on 7.3.1 while upstream
shipped fixes we then rediscovered by hand.
This commit's PARENT IS TAMAGUI. A future sync is `git merge tama/main` then
`node scripts/rebrand.mjs` — a real merge, because the history is now shared.
174 packages: 166 upstream, our 8 restored (chrome, shell, telemetry, recipes,
get, font-geist-{sans,mono}, @hanzo/booker), bento-get gained. 170/170 build.
Our patches to files UPSTREAM ALSO OWNS are carried, which the package-level
delta missed and which was where the value actually was:
- useMedia's server snapshot (`initState ?? getMedia()`). Upstream still
returns undefined there, so every Tamagui Dialog kills a prerender — the
exact crash hanzo.app spent a day on.
- data-slot on web host nodes, absent upstream entirely.
Both applied ONTO upstream's newer files (it rewrote useMedia +150/-63 and
createComponent +160/-55), marked `PATCH (ours, carried across the transplant)`.
Seven traps are encoded in scripts/rebrand.mjs, each found by a gate:
skip itself and lockfiles; special-case the double-branded names in BOTH scoped
and bare form; map path strings, not just paths; drop a level for the flattened
group; check disk rather than a stale index.
Rust build artifacts are NOT committed. An earlier draft of this commit swept
apps/desktop/src-tauri/target/debug in via `git add -A` — 3,859 files including
a 272MB .a, over GitHub's 100MB cap, so the push could never have landed. They
are gitignored now.
Co-Authored-By: Hanzo Dev <[email protected]>
69 lines
2.4 KiB
TypeScript
69 lines
2.4 KiB
TypeScript
import { expect, test } from '@playwright/test'
|
|
import { setupPage } from './test-utils'
|
|
|
|
/**
|
|
* Test for styled(Dialog.Overlay) with onPress
|
|
*
|
|
* This tests the fix for: "Cannot read property '_internalInstanceHandle' of null"
|
|
* which occurred on Android when using styled(Dialog.Overlay) with onPress.
|
|
*
|
|
* The fix skips GestureDetector wrapping for HOC components and passes press
|
|
* events down via props instead, allowing the inner component to handle gesture
|
|
* detection at the correct level where a native view exists.
|
|
*/
|
|
test.describe('Dialog Sheet Adapt - styled(Dialog.Overlay) with onPress', () => {
|
|
test.beforeEach(async ({ page }) => {
|
|
await setupPage(page, { name: 'DialogSheetAdaptCase', type: 'useCase' })
|
|
})
|
|
|
|
test('styled(Dialog.Overlay) with onPress should render without crashing', async ({
|
|
page,
|
|
}) => {
|
|
await page.waitForLoadState('networkidle')
|
|
|
|
// Open the dialog
|
|
const trigger = page.getByTestId('open-dialog')
|
|
await trigger.click()
|
|
|
|
// Wait for dialog overlay to be visible (the styled DialogOverlay)
|
|
// On web, this should work. The fix ensures HOC components pass press events
|
|
// down instead of wrapping with GestureDetector (which would crash on native
|
|
// when the inner component returns null during adapt)
|
|
await page.waitForTimeout(500)
|
|
|
|
// Dialog content should be visible
|
|
const dialogContent = page.locator('text=Dialog with Sheet Adapt')
|
|
await expect(dialogContent).toBeVisible({ timeout: 5000 })
|
|
|
|
// Close button should work
|
|
const closeButton = page.getByTestId('close-dialog')
|
|
await closeButton.click()
|
|
|
|
// Dialog should close
|
|
await expect(dialogContent).not.toBeVisible({ timeout: 5000 })
|
|
})
|
|
|
|
test('can open and close dialog multiple times without errors', async ({ page }) => {
|
|
await page.waitForLoadState('networkidle')
|
|
|
|
// Test multiple open/close cycles to ensure stability
|
|
for (let i = 0; i < 3; i++) {
|
|
// Open the dialog
|
|
const trigger = page.getByTestId('open-dialog')
|
|
await trigger.click()
|
|
|
|
// Wait for dialog to be visible
|
|
await page.waitForTimeout(300)
|
|
const dialogContent = page.locator('text=Dialog with Sheet Adapt')
|
|
await expect(dialogContent).toBeVisible({ timeout: 5000 })
|
|
|
|
// Close via button
|
|
const closeButton = page.getByTestId('close-dialog')
|
|
await closeButton.click()
|
|
|
|
// Wait for dialog to close
|
|
await expect(dialogContent).not.toBeVisible({ timeout: 5000 })
|
|
}
|
|
})
|
|
})
|