Files
gui/apps/kitchen-sink/tests/MenuAboveDialog.test.tsx
zeekayandHanzo Dev 69c6e860d7 transplant onto tamagui v2.6.0, brand as a re-runnable transform
This repo could never sync. There was NO merge-base with tamagui — 372 commits
here against 15,791 there, unrelated histories — because it began as a
copy-paste rebrand with a flattened layout. Every "sync" since was a hand
re-application that drifted, which is why the tree sat on 7.3.1 while upstream
shipped fixes we then rediscovered by hand.

This commit's PARENT IS TAMAGUI. A future sync is `git merge tama/main` then
`node scripts/rebrand.mjs` — a real merge, because the history is now shared.

174 packages: 166 upstream, our 8 restored (chrome, shell, telemetry, recipes,
get, font-geist-{sans,mono}, @hanzo/booker), bento-get gained. 170/170 build.

Our patches to files UPSTREAM ALSO OWNS are carried, which the package-level
delta missed and which was where the value actually was:
  - useMedia's server snapshot (`initState ?? getMedia()`). Upstream still
    returns undefined there, so every Tamagui Dialog kills a prerender — the
    exact crash hanzo.app spent a day on.
  - data-slot on web host nodes, absent upstream entirely.
Both applied ONTO upstream's newer files (it rewrote useMedia +150/-63 and
createComponent +160/-55), marked `PATCH (ours, carried across the transplant)`.

Seven traps are encoded in scripts/rebrand.mjs, each found by a gate:
skip itself and lockfiles; special-case the double-branded names in BOTH scoped
and bare form; map path strings, not just paths; drop a level for the flattened
group; check disk rather than a stale index.

Rust build artifacts are NOT committed. An earlier draft of this commit swept
apps/desktop/src-tauri/target/debug in via `git add -A` — 3,859 files including
a 272MB .a, over GitHub's 100MB cap, so the push could never have landed. They
are gitignored now.

Co-Authored-By: Hanzo Dev <[email protected]>
2026-07-30 18:25:06 -07:00

109 lines
3.8 KiB
TypeScript

import { expect, test } from '@playwright/test'
import { setupPage } from './test-utils'
test.beforeEach(async ({ page }) => {
await setupPage(page, { type: 'useCase', name: 'MenuAboveDialogCase' })
})
test('menu renders above dialog overlay', async ({ page }) => {
await page.waitForLoadState('networkidle')
// open dialog
const dialogTrigger = page.getByTestId('dialog-trigger')
await dialogTrigger.click()
const dialogContent = page.getByTestId('dialog-content')
await expect(dialogContent).toBeVisible({ timeout: 5000 })
await page.waitForTimeout(300)
// open menu inside dialog
const menuTrigger = page.getByTestId('menu-trigger')
await menuTrigger.click()
const menuContent = page.getByTestId('menu-content')
await expect(menuContent).toBeVisible({ timeout: 5000 })
// verify menu is clickable (proves it's above dialog)
const menuItem = page.getByTestId('menu-item-1')
await expect(menuItem).toBeVisible()
// get z-index of portal containers (the fixed positioned wrappers)
const dialogPortalZIndex = await page.evaluate(() => {
const dialogContent = document.querySelector('[data-testid="dialog-content"]')
// find the portal container (fixed position ancestor with z-index)
let el = dialogContent?.parentElement
while (el) {
const style = window.getComputedStyle(el)
if (style.position === 'fixed' && style.zIndex !== 'auto') {
return parseInt(style.zIndex)
}
el = el.parentElement
}
return 0
})
const menuPortalZIndex = await page.evaluate(() => {
const menuContent = document.querySelector('[data-testid="menu-content"]')
// find the portal container (fixed position ancestor with z-index)
let el = menuContent?.parentElement
while (el) {
const style = window.getComputedStyle(el)
if (style.position === 'fixed' && style.zIndex !== 'auto') {
return parseInt(style.zIndex)
}
el = el.parentElement
}
return 0
})
// menu portal should have higher z-index than dialog portal
console.log(
`Dialog portal z-index: ${dialogPortalZIndex}, Menu portal z-index: ${menuPortalZIndex}`
)
expect(menuPortalZIndex).toBeGreaterThan(dialogPortalZIndex)
})
test('menu closes on ESC, dialog stays open', async ({ page }) => {
await page.waitForLoadState('networkidle')
// open dialog
await page.getByTestId('dialog-trigger').click()
await expect(page.getByTestId('dialog-content')).toBeVisible({ timeout: 5000 })
await page.waitForTimeout(300)
// open menu
await page.getByTestId('menu-trigger').click()
await expect(page.getByTestId('menu-content')).toBeVisible({ timeout: 5000 })
await page.waitForTimeout(200)
// press ESC - menu should close, dialog should stay open
await page.keyboard.press('Escape')
await page.waitForTimeout(400)
await expect(page.getByTestId('menu-content')).not.toBeVisible({ timeout: 5000 })
await expect(page.getByTestId('dialog-content')).toBeVisible()
})
test('clicking menu item works when menu is above dialog', async ({ page }) => {
await page.waitForLoadState('networkidle')
// open dialog
await page.getByTestId('dialog-trigger').click()
await expect(page.getByTestId('dialog-content')).toBeVisible({ timeout: 5000 })
await page.waitForTimeout(300)
// open menu
await page.getByTestId('menu-trigger').click()
await expect(page.getByTestId('menu-content')).toBeVisible({ timeout: 5000 })
await page.waitForTimeout(200)
// click menu item - should work without being blocked by dialog
const menuItem = page.getByTestId('menu-item-2')
await menuItem.click()
// menu should close after item click
await expect(page.getByTestId('menu-content')).not.toBeVisible({ timeout: 5000 })
// dialog should still be open
await expect(page.getByTestId('dialog-content')).toBeVisible()
})