mirror of
https://github.com/hanzoai/gui.git
synced 2026-10-25 02:31:41 +00:00
zeekayandHanzo Dev
69c6e860d7
This repo could never sync. There was NO merge-base with tamagui — 372 commits
here against 15,791 there, unrelated histories — because it began as a
copy-paste rebrand with a flattened layout. Every "sync" since was a hand
re-application that drifted, which is why the tree sat on 7.3.1 while upstream
shipped fixes we then rediscovered by hand.
This commit's PARENT IS TAMAGUI. A future sync is `git merge tama/main` then
`node scripts/rebrand.mjs` — a real merge, because the history is now shared.
174 packages: 166 upstream, our 8 restored (chrome, shell, telemetry, recipes,
get, font-geist-{sans,mono}, @hanzo/booker), bento-get gained. 170/170 build.
Our patches to files UPSTREAM ALSO OWNS are carried, which the package-level
delta missed and which was where the value actually was:
- useMedia's server snapshot (`initState ?? getMedia()`). Upstream still
returns undefined there, so every Tamagui Dialog kills a prerender — the
exact crash hanzo.app spent a day on.
- data-slot on web host nodes, absent upstream entirely.
Both applied ONTO upstream's newer files (it rewrote useMedia +150/-63 and
createComponent +160/-55), marked `PATCH (ours, carried across the transplant)`.
Seven traps are encoded in scripts/rebrand.mjs, each found by a gate:
skip itself and lockfiles; special-case the double-branded names in BOTH scoped
and bare form; map path strings, not just paths; drop a level for the flattened
group; check disk rather than a stale index.
Rust build artifacts are NOT committed. An earlier draft of this commit swept
apps/desktop/src-tauri/target/debug in via `git add -A` — 3,859 files including
a 272MB .a, over GitHub's 100MB cap, so the push could never have landed. They
are gitignored now.
Co-Authored-By: Hanzo Dev <[email protected]>
68 lines
2.3 KiB
TypeScript
68 lines
2.3 KiB
TypeScript
import { expect, test } from '@playwright/test'
|
|
import { setupPage } from './test-utils'
|
|
|
|
// regression: toggling animatePosition between renders on a long-lived
|
|
// shared Menu.Content used to trip React's "Should have a queue" invariant
|
|
// because PopperContent only spread `transition` when animatePos was truthy.
|
|
// the inner View's hook count flipped (useAnimations not called -> called)
|
|
// when animatePosition went from undefined/false -> true.
|
|
test.describe('Menu animatePosition toggle (regression)', () => {
|
|
test.beforeEach(async ({ page }) => {
|
|
await setupPage(page, {
|
|
name: 'MenuAnimatePositionToggleCase',
|
|
type: 'useCase',
|
|
waitExtra: true,
|
|
})
|
|
})
|
|
|
|
test('toggling animatePosition mid-life does not throw a React invariant', async ({
|
|
page,
|
|
}) => {
|
|
const errors: string[] = []
|
|
page.on('pageerror', (err) => errors.push(err.message))
|
|
page.on('console', (msg) => {
|
|
if (msg.type() === 'error') errors.push(msg.text())
|
|
})
|
|
|
|
// open via the non-animating trigger first (animatePosition stays undefined)
|
|
const triggerNoAnim = page.getByTestId('trigger-no-anim')
|
|
const triggerAnim = page.getByTestId('trigger-anim')
|
|
|
|
await triggerNoAnim.hover()
|
|
await triggerNoAnim.click()
|
|
await page.waitForTimeout(300)
|
|
|
|
// close
|
|
await page.keyboard.press('Escape')
|
|
await page.waitForTimeout(200)
|
|
|
|
// now open via the animating trigger - this used to flip 'transition'
|
|
// presence on the same inner View instance and crash with
|
|
// "Should have a queue. This is likely a bug in React. Please file an issue."
|
|
await triggerAnim.hover()
|
|
await triggerAnim.click()
|
|
await page.waitForTimeout(300)
|
|
|
|
const content = page.getByTestId('menu-content')
|
|
await expect(content).toBeVisible()
|
|
|
|
// toggle back and forth a few times to be sure
|
|
await page.keyboard.press('Escape')
|
|
await page.waitForTimeout(150)
|
|
await triggerNoAnim.click()
|
|
await page.waitForTimeout(200)
|
|
await page.keyboard.press('Escape')
|
|
await page.waitForTimeout(150)
|
|
await triggerAnim.click()
|
|
await page.waitForTimeout(300)
|
|
|
|
const reactInvariantErrors = errors.filter(
|
|
(e) =>
|
|
e.includes('Should have a queue') ||
|
|
e.includes('Rendered more hooks') ||
|
|
e.includes('Rendered fewer hooks')
|
|
)
|
|
expect(reactInvariantErrors).toEqual([])
|
|
})
|
|
})
|