mirror of
https://github.com/hanzoai/gui.git
synced 2026-10-25 02:31:41 +00:00
zeekayandHanzo Dev
69c6e860d7
This repo could never sync. There was NO merge-base with tamagui — 372 commits
here against 15,791 there, unrelated histories — because it began as a
copy-paste rebrand with a flattened layout. Every "sync" since was a hand
re-application that drifted, which is why the tree sat on 7.3.1 while upstream
shipped fixes we then rediscovered by hand.
This commit's PARENT IS TAMAGUI. A future sync is `git merge tama/main` then
`node scripts/rebrand.mjs` — a real merge, because the history is now shared.
174 packages: 166 upstream, our 8 restored (chrome, shell, telemetry, recipes,
get, font-geist-{sans,mono}, @hanzo/booker), bento-get gained. 170/170 build.
Our patches to files UPSTREAM ALSO OWNS are carried, which the package-level
delta missed and which was where the value actually was:
- useMedia's server snapshot (`initState ?? getMedia()`). Upstream still
returns undefined there, so every Tamagui Dialog kills a prerender — the
exact crash hanzo.app spent a day on.
- data-slot on web host nodes, absent upstream entirely.
Both applied ONTO upstream's newer files (it rewrote useMedia +150/-63 and
createComponent +160/-55), marked `PATCH (ours, carried across the transplant)`.
Seven traps are encoded in scripts/rebrand.mjs, each found by a gate:
skip itself and lockfiles; special-case the double-branded names in BOTH scoped
and bare form; map path strings, not just paths; drop a level for the flattened
group; check disk rather than a stale index.
Rust build artifacts are NOT committed. An earlier draft of this commit swept
apps/desktop/src-tauri/target/debug in via `git add -A` — 3,859 files including
a 272MB .a, over GitHub's 100MB cap, so the push could never have landed. They
are gitignored now.
Co-Authored-By: Hanzo Dev <[email protected]>
107 lines
3.5 KiB
TypeScript
107 lines
3.5 KiB
TypeScript
import { expect, test } from '@playwright/test'
|
|
import { setupPage } from './test-utils'
|
|
|
|
/**
|
|
* Tests the disableClick prop on Popover.Trigger.
|
|
*
|
|
* Bug: when a hoverable popover is open and the user clicks the trigger,
|
|
* the browser fires pointerdown then click. If onPressIn calls setOpen(false),
|
|
* React re-renders between the two events. The built-in onPress handler then
|
|
* reads the updated open=false and toggles it back to true, causing a
|
|
* close → re-open → close oscillation (visible as a flash/glitch).
|
|
*
|
|
* Fix: disableClick prop suppresses the built-in click toggle on the trigger,
|
|
* allowing the user to control open/close entirely through their own handlers.
|
|
*/
|
|
|
|
test.beforeEach(async ({ page }) => {
|
|
await setupPage(page, {
|
|
name: 'PopoverHoverableDisableClickCase',
|
|
type: 'useCase',
|
|
})
|
|
await page.waitForLoadState('networkidle')
|
|
await page.waitForTimeout(500)
|
|
})
|
|
|
|
test('disableClick: hover opens, click dismisses without re-open oscillation', async ({
|
|
page,
|
|
}) => {
|
|
const trigger = page.locator('#disableclick-trigger')
|
|
const content = page.locator('#disableclick-content')
|
|
|
|
await expect(content).not.toBeVisible()
|
|
|
|
// hover to open
|
|
await trigger.hover()
|
|
await page.waitForTimeout(300)
|
|
await expect(content).toBeVisible({ timeout: 2000 })
|
|
|
|
// click to dismiss (onPressIn sets open=false)
|
|
await trigger.click()
|
|
await page.waitForTimeout(500)
|
|
|
|
// popover should be closed — NOT re-opened by the built-in onPress toggle
|
|
await expect(content).not.toBeVisible({ timeout: 2000 })
|
|
|
|
// check the log for oscillation: if we see onOpenChange: true AFTER
|
|
// onPressIn: dismissing, that's the bug
|
|
const logEntries = await page.evaluate(() => {
|
|
const logEl = document.getElementById('open-state-log')
|
|
if (!logEl) return []
|
|
return Array.from(logEl.querySelectorAll('span')).map((el) => el.textContent || '')
|
|
})
|
|
|
|
console.log('State log:', logEntries)
|
|
|
|
// after the dismiss, there should be no onOpenChange: true
|
|
const dismissIdx = logEntries.findIndex((e) => e.includes('dismissing'))
|
|
if (dismissIdx >= 0) {
|
|
const afterDismiss = logEntries.slice(dismissIdx + 1)
|
|
const reOpened = afterDismiss.some((e) => e.includes('onOpenChange: true'))
|
|
expect(reOpened, 'Popover re-opened after dismiss (state oscillation bug)').toBe(
|
|
false
|
|
)
|
|
}
|
|
})
|
|
|
|
test('disableClick: hover opens, move away closes, re-hover re-opens', async ({
|
|
page,
|
|
}) => {
|
|
const trigger = page.locator('#disableclick-trigger')
|
|
const content = page.locator('#disableclick-content')
|
|
|
|
await expect(content).not.toBeVisible()
|
|
|
|
// hover to open
|
|
await trigger.hover()
|
|
await page.waitForTimeout(300)
|
|
await expect(content).toBeVisible({ timeout: 2000 })
|
|
|
|
// move away to close
|
|
await page.mouse.move(10, 10)
|
|
await page.waitForTimeout(800)
|
|
await expect(content).not.toBeVisible({ timeout: 2000 })
|
|
|
|
// hover again should re-open (hover still works with disableClick)
|
|
await trigger.hover()
|
|
await page.waitForTimeout(300)
|
|
await expect(content).toBeVisible({ timeout: 2000 })
|
|
})
|
|
|
|
test('normal trigger: click toggles popover open and closed', async ({ page }) => {
|
|
const trigger = page.locator('#withclick-trigger')
|
|
const content = page.locator('#withclick-content')
|
|
|
|
await expect(content).not.toBeVisible()
|
|
|
|
// click should open (normal trigger without disableClick)
|
|
await trigger.click()
|
|
await page.waitForTimeout(500)
|
|
await expect(content).toBeVisible({ timeout: 2000 })
|
|
|
|
// click again should close
|
|
await trigger.click()
|
|
await page.waitForTimeout(500)
|
|
await expect(content).not.toBeVisible({ timeout: 2000 })
|
|
})
|