Files
gui/apps/kitchen-sink/tests/PopoverInitialPosition.animated.test.tsx
zeekayandHanzo Dev 69c6e860d7 transplant onto tamagui v2.6.0, brand as a re-runnable transform
This repo could never sync. There was NO merge-base with tamagui — 372 commits
here against 15,791 there, unrelated histories — because it began as a
copy-paste rebrand with a flattened layout. Every "sync" since was a hand
re-application that drifted, which is why the tree sat on 7.3.1 while upstream
shipped fixes we then rediscovered by hand.

This commit's PARENT IS TAMAGUI. A future sync is `git merge tama/main` then
`node scripts/rebrand.mjs` — a real merge, because the history is now shared.

174 packages: 166 upstream, our 8 restored (chrome, shell, telemetry, recipes,
get, font-geist-{sans,mono}, @hanzo/booker), bento-get gained. 170/170 build.

Our patches to files UPSTREAM ALSO OWNS are carried, which the package-level
delta missed and which was where the value actually was:
  - useMedia's server snapshot (`initState ?? getMedia()`). Upstream still
    returns undefined there, so every Tamagui Dialog kills a prerender — the
    exact crash hanzo.app spent a day on.
  - data-slot on web host nodes, absent upstream entirely.
Both applied ONTO upstream's newer files (it rewrote useMedia +150/-63 and
createComponent +160/-55), marked `PATCH (ours, carried across the transplant)`.

Seven traps are encoded in scripts/rebrand.mjs, each found by a gate:
skip itself and lockfiles; special-case the double-branded names in BOTH scoped
and bare form; map path strings, not just paths; drop a level for the flattened
group; check disk rather than a stale index.

Rust build artifacts are NOT committed. An earlier draft of this commit swept
apps/desktop/src-tauri/target/debug in via `git add -A` — 3,859 files including
a 272MB .a, over GitHub's 100MB cap, so the push could never have landed. They
are gitignored now.

Co-Authored-By: Hanzo Dev <[email protected]>
2026-07-30 18:25:06 -07:00

83 lines
2.9 KiB
TypeScript

import { expect, test } from '@playwright/test'
import { setupPage } from './test-utils'
// regression: popover content should appear near its trigger, not fly in
// from the top-left corner. when floating-ui resets isPositioned on close
// but x/y retain stale values, the hide logic must still prevent the
// content from being visible at the wrong position.
// native animation driver has a pre-existing initial position bug
const driverName = process.env.GUI_TEST_ANIMATION_DRIVER || ''
test.skip(
driverName === 'native',
'native driver has pre-existing initial position issue'
)
test.describe('Popover initial position', () => {
test('hoverable popover appears near trigger, not at top-left', async ({ page }) => {
await setupPage(page, {
name: 'PopoverHoverableScopedCase',
type: 'useCase',
})
const content = page.locator('#nav-content')
const trigger = page.locator('#nav-trigger-about')
const triggerBox = await trigger.boundingBox()
expect(triggerBox).toBeTruthy()
// hover trigger to open
await trigger.hover()
await page.waitForTimeout(500)
await expect(content).toBeVisible()
const contentBox = await content.boundingBox()
expect(contentBox).toBeTruthy()
// content should be near the trigger, not at the page origin
// popover is placed below trigger, so content.y should be close to trigger bottom
const triggerBottom = triggerBox!.y + triggerBox!.height
expect(contentBox!.y).toBeGreaterThan(triggerBottom - 20)
expect(contentBox!.y).toBeLessThan(triggerBottom + 100)
// content x should be in the general area of the trigger, not at 0
expect(contentBox!.x).toBeGreaterThan(triggerBox!.x - contentBox!.width)
})
test('popover does not briefly appear at origin on reopen', async ({ page }) => {
await setupPage(page, {
name: 'PopoverHoverableScopedCase',
type: 'useCase',
})
const content = page.locator('#nav-content')
const trigger = page.locator('#nav-trigger-contact')
// open
await trigger.hover()
await page.waitForTimeout(500)
await expect(content).toBeVisible()
// close fully
await page.mouse.move(10, 600, { steps: 2 })
await page.waitForTimeout(800)
await expect(content).not.toBeVisible()
// reopen on same trigger and check position EARLY
await trigger.hover()
await page.waitForTimeout(100)
const earlyBox = await content.boundingBox()
if (earlyBox) {
const triggerBox = await trigger.boundingBox()
// if content is visible, it must NOT be at the top-left corner
// (the fly-from-origin bug shows content starting near 0,0)
const distFromOrigin = Math.sqrt(earlyBox.x ** 2 + earlyBox.y ** 2)
const triggerDist = Math.sqrt(
(earlyBox.x - triggerBox!.x) ** 2 + (earlyBox.y - triggerBox!.y) ** 2
)
// content should be closer to trigger than to the page origin
expect(triggerDist).toBeLessThan(distFromOrigin + 50)
}
})
})