mirror of
https://github.com/hanzoai/gui.git
synced 2026-10-25 02:31:41 +00:00
zeekayandHanzo Dev
69c6e860d7
This repo could never sync. There was NO merge-base with tamagui — 372 commits
here against 15,791 there, unrelated histories — because it began as a
copy-paste rebrand with a flattened layout. Every "sync" since was a hand
re-application that drifted, which is why the tree sat on 7.3.1 while upstream
shipped fixes we then rediscovered by hand.
This commit's PARENT IS TAMAGUI. A future sync is `git merge tama/main` then
`node scripts/rebrand.mjs` — a real merge, because the history is now shared.
174 packages: 166 upstream, our 8 restored (chrome, shell, telemetry, recipes,
get, font-geist-{sans,mono}, @hanzo/booker), bento-get gained. 170/170 build.
Our patches to files UPSTREAM ALSO OWNS are carried, which the package-level
delta missed and which was where the value actually was:
- useMedia's server snapshot (`initState ?? getMedia()`). Upstream still
returns undefined there, so every Tamagui Dialog kills a prerender — the
exact crash hanzo.app spent a day on.
- data-slot on web host nodes, absent upstream entirely.
Both applied ONTO upstream's newer files (it rewrote useMedia +150/-63 and
createComponent +160/-55), marked `PATCH (ours, carried across the transplant)`.
Seven traps are encoded in scripts/rebrand.mjs, each found by a gate:
skip itself and lockfiles; special-case the double-branded names in BOTH scoped
and bare form; map path strings, not just paths; drop a level for the flattened
group; check disk rather than a stale index.
Rust build artifacts are NOT committed. An earlier draft of this commit swept
apps/desktop/src-tauri/target/debug in via `git add -A` — 3,859 files including
a 272MB .a, over GitHub's 100MB cap, so the push could never have landed. They
are gitignored now.
Co-Authored-By: Hanzo Dev <[email protected]>
63 lines
2.2 KiB
TypeScript
63 lines
2.2 KiB
TypeScript
import { expect, test } from '@playwright/test'
|
|
import { setupPage } from './test-utils'
|
|
|
|
// helper to extract render count from text like "renders: 1"
|
|
function parseRenderCount(text: string | null): number {
|
|
if (!text) return 0
|
|
const match = text.match(/renders:\s*(\d+)/)
|
|
return match ? Number(match[1]) : 0
|
|
}
|
|
|
|
test.describe('Popover Trigger Render Isolation', () => {
|
|
test.beforeEach(async ({ page }) => {
|
|
await setupPage(page, { name: 'PopoverTriggerIsolationCase', type: 'useCase' })
|
|
})
|
|
|
|
test('only the active trigger re-renders when popover opens', async ({ page }) => {
|
|
await page.waitForLoadState('networkidle')
|
|
|
|
// get initial render counts
|
|
const getRenderCounts = async () => {
|
|
return {
|
|
trigger1: parseRenderCount(
|
|
await page.getByTestId('isolated-trigger-1-render-count').textContent()
|
|
),
|
|
trigger2: parseRenderCount(
|
|
await page.getByTestId('isolated-trigger-2-render-count').textContent()
|
|
),
|
|
trigger3: parseRenderCount(
|
|
await page.getByTestId('isolated-trigger-3-render-count').textContent()
|
|
),
|
|
}
|
|
}
|
|
|
|
const initialCounts = await getRenderCounts()
|
|
|
|
// click trigger1 to open popover
|
|
await page.getByTestId('isolated-trigger-1').click()
|
|
|
|
// wait for popover to open
|
|
const content = page.getByTestId('isolated-popover-content')
|
|
await expect(content).toBeVisible({ timeout: 5000 })
|
|
|
|
// check render counts after opening
|
|
const afterOpenCounts = await getRenderCounts()
|
|
|
|
// trigger1 (active) may re-render to update aria-expanded
|
|
// but trigger2 and trigger3 (inactive) should NOT re-render
|
|
expect(afterOpenCounts.trigger2).toBe(initialCounts.trigger2)
|
|
expect(afterOpenCounts.trigger3).toBe(initialCounts.trigger3)
|
|
|
|
// close the popover
|
|
await page.getByTestId('isolated-close').click()
|
|
await expect(content).not.toBeVisible({ timeout: 5000 })
|
|
|
|
// check render counts after closing
|
|
const afterCloseCounts = await getRenderCounts()
|
|
|
|
// inactive triggers should still not have re-rendered
|
|
expect(afterCloseCounts.trigger2).toBe(initialCounts.trigger2)
|
|
expect(afterCloseCounts.trigger3).toBe(initialCounts.trigger3)
|
|
})
|
|
})
|