mirror of
https://github.com/hanzoai/gui.git
synced 2026-10-25 02:31:41 +00:00
zeekayandHanzo Dev
69c6e860d7
This repo could never sync. There was NO merge-base with tamagui — 372 commits
here against 15,791 there, unrelated histories — because it began as a
copy-paste rebrand with a flattened layout. Every "sync" since was a hand
re-application that drifted, which is why the tree sat on 7.3.1 while upstream
shipped fixes we then rediscovered by hand.
This commit's PARENT IS TAMAGUI. A future sync is `git merge tama/main` then
`node scripts/rebrand.mjs` — a real merge, because the history is now shared.
174 packages: 166 upstream, our 8 restored (chrome, shell, telemetry, recipes,
get, font-geist-{sans,mono}, @hanzo/booker), bento-get gained. 170/170 build.
Our patches to files UPSTREAM ALSO OWNS are carried, which the package-level
delta missed and which was where the value actually was:
- useMedia's server snapshot (`initState ?? getMedia()`). Upstream still
returns undefined there, so every Tamagui Dialog kills a prerender — the
exact crash hanzo.app spent a day on.
- data-slot on web host nodes, absent upstream entirely.
Both applied ONTO upstream's newer files (it rewrote useMedia +150/-63 and
createComponent +160/-55), marked `PATCH (ours, carried across the transplant)`.
Seven traps are encoded in scripts/rebrand.mjs, each found by a gate:
skip itself and lockfiles; special-case the double-branded names in BOTH scoped
and bare form; map path strings, not just paths; drop a level for the flattened
group; check disk rather than a stale index.
Rust build artifacts are NOT committed. An earlier draft of this commit swept
apps/desktop/src-tauri/target/debug in via `git add -A` — 3,859 files including
a 272MB .a, over GitHub's 100MB cap, so the push could never have landed. They
are gitignored now.
Co-Authored-By: Hanzo Dev <[email protected]>
224 lines
7.4 KiB
TypeScript
224 lines
7.4 KiB
TypeScript
import { expect, test, type Page } from '@playwright/test'
|
|
import { setupPage } from './test-utils'
|
|
|
|
test.beforeEach(async ({ page }) => {
|
|
await setupPage(page, { name: 'RemoveScrollCase', type: 'useCase' })
|
|
})
|
|
|
|
/**
|
|
* helper: scroll, open select, wait for viewport
|
|
*/
|
|
async function scrollAndOpenSelect(page: Page, scrollY: number) {
|
|
if (scrollY > 0) {
|
|
await page.evaluate((y) => window.scrollTo(0, y), scrollY)
|
|
await page.waitForTimeout(100)
|
|
const actual = await page.evaluate(() => window.scrollY)
|
|
expect(actual).toBeGreaterThanOrEqual(scrollY - 2)
|
|
}
|
|
|
|
const trigger = page.getByTestId('rs-select-trigger')
|
|
await trigger.scrollIntoViewIfNeeded()
|
|
await trigger.click()
|
|
|
|
const viewport = page.getByTestId('rs-select-viewport')
|
|
await expect(viewport).toBeVisible({ timeout: 5000 })
|
|
await page.waitForTimeout(200)
|
|
|
|
return viewport
|
|
}
|
|
|
|
// --- positive: scroll position IS restored ---
|
|
|
|
test.describe('scroll position restored after close', () => {
|
|
test('preserved when closing by selecting an item', async ({ page }) => {
|
|
await scrollAndOpenSelect(page, 500)
|
|
const preClose = await page.evaluate(() => window.scrollY)
|
|
|
|
const item = page.getByTestId('rs-select-apple')
|
|
await item.click()
|
|
await page.waitForTimeout(300)
|
|
|
|
const viewport = page.getByTestId('rs-select-viewport')
|
|
await expect(viewport).not.toBeVisible()
|
|
|
|
const postClose = await page.evaluate(() => window.scrollY)
|
|
expect(Math.abs(postClose - preClose)).toBeLessThanOrEqual(2)
|
|
})
|
|
|
|
test('preserved when closing by pressing Escape', async ({ page }) => {
|
|
await scrollAndOpenSelect(page, 500)
|
|
const preClose = await page.evaluate(() => window.scrollY)
|
|
|
|
await page.keyboard.press('Escape')
|
|
await page.waitForTimeout(300)
|
|
|
|
const viewport = page.getByTestId('rs-select-viewport')
|
|
await expect(viewport).not.toBeVisible()
|
|
|
|
const postClose = await page.evaluate(() => window.scrollY)
|
|
expect(Math.abs(postClose - preClose)).toBeLessThanOrEqual(2)
|
|
})
|
|
|
|
test('preserved when closing by clicking outside', async ({ page }) => {
|
|
await scrollAndOpenSelect(page, 500)
|
|
const preClose = await page.evaluate(() => window.scrollY)
|
|
|
|
// click far from the select content to dismiss
|
|
await page.mouse.click(10, 10)
|
|
await page.waitForTimeout(300)
|
|
|
|
const viewport = page.getByTestId('rs-select-viewport')
|
|
await expect(viewport).not.toBeVisible({ timeout: 5000 })
|
|
|
|
const postClose = await page.evaluate(() => window.scrollY)
|
|
expect(Math.abs(postClose - preClose)).toBeLessThanOrEqual(2)
|
|
})
|
|
})
|
|
|
|
// --- negative: things that should NOT happen ---
|
|
|
|
test.describe('scroll lock prevents body scroll while open', () => {
|
|
test('overflow:hidden applied to html while Select is open', async ({ page }) => {
|
|
await scrollAndOpenSelect(page, 300)
|
|
|
|
const htmlOverflow = await page.evaluate(
|
|
() => getComputedStyle(document.documentElement).overflow
|
|
)
|
|
expect(htmlOverflow).toBe('hidden')
|
|
|
|
// close and verify released
|
|
await page.keyboard.press('Escape')
|
|
await page.waitForTimeout(300)
|
|
|
|
const afterOverflow = await page.evaluate(
|
|
() => getComputedStyle(document.documentElement).overflow
|
|
)
|
|
expect(afterOverflow).not.toBe('hidden')
|
|
})
|
|
})
|
|
|
|
test.describe('edge cases', () => {
|
|
test('no scroll jump when scrollY is 0', async ({ page }) => {
|
|
// already at top
|
|
await scrollAndOpenSelect(page, 0)
|
|
|
|
const item = page.getByTestId('rs-select-banana')
|
|
await item.click()
|
|
await page.waitForTimeout(300)
|
|
|
|
const postClose = await page.evaluate(() => window.scrollY)
|
|
// should still be at 0, no negative jump or weird offset
|
|
expect(postClose).toBe(0)
|
|
})
|
|
|
|
test('scroll position stable across multiple open/close cycles', async ({ page }) => {
|
|
await page.evaluate(() => window.scrollTo(0, 400))
|
|
await page.waitForTimeout(100)
|
|
|
|
for (let i = 0; i < 3; i++) {
|
|
const trigger = page.getByTestId('rs-select-trigger')
|
|
await trigger.scrollIntoViewIfNeeded()
|
|
await trigger.click()
|
|
|
|
const viewport = page.getByTestId('rs-select-viewport')
|
|
await expect(viewport).toBeVisible({ timeout: 5000 })
|
|
await page.waitForTimeout(200)
|
|
|
|
await page.keyboard.press('Escape')
|
|
await page.waitForTimeout(300)
|
|
await expect(viewport).not.toBeVisible()
|
|
}
|
|
|
|
const finalScroll = await page.evaluate(() => window.scrollY)
|
|
expect(Math.abs(finalScroll - 400)).toBeLessThanOrEqual(2)
|
|
})
|
|
|
|
test('selecting different items preserves scroll each time', async ({ page }) => {
|
|
const items = ['rs-select-apple', 'rs-select-banana', 'rs-select-orange']
|
|
|
|
for (const itemId of items) {
|
|
// re-scroll to target before each iteration
|
|
await page.evaluate(() => window.scrollTo(0, 600))
|
|
await page.waitForTimeout(200)
|
|
|
|
const trigger = page.getByTestId('rs-select-trigger')
|
|
// click trigger directly without scrollIntoViewIfNeeded
|
|
await trigger.click()
|
|
|
|
const viewport = page.getByTestId('rs-select-viewport')
|
|
await expect(viewport).toBeVisible({ timeout: 5000 })
|
|
await page.waitForTimeout(200)
|
|
|
|
// capture scroll position while select is open (scroll is locked here)
|
|
const whileOpen = await page.evaluate(() => window.scrollY)
|
|
|
|
const item = page.getByTestId(itemId)
|
|
await item.click()
|
|
await page.waitForTimeout(500)
|
|
await expect(viewport).not.toBeVisible()
|
|
|
|
const afterClose = await page.evaluate(() => window.scrollY)
|
|
// scroll should be restored to where it was when the select opened
|
|
expect(Math.abs(afterClose - whileOpen)).toBeLessThanOrEqual(2)
|
|
}
|
|
})
|
|
})
|
|
|
|
// --- mobile/touch device tests (chrome mobile emulation) ---
|
|
|
|
test.describe('mobile touch device', () => {
|
|
test.use({
|
|
viewport: { width: 390, height: 844 },
|
|
hasTouch: true,
|
|
isMobile: true,
|
|
})
|
|
|
|
test('scroll position restored after selecting item on mobile', async ({ page }) => {
|
|
await page.evaluate(() => window.scrollTo(0, 400))
|
|
await page.waitForTimeout(100)
|
|
|
|
const trigger = page.getByTestId('rs-select-trigger')
|
|
await trigger.scrollIntoViewIfNeeded()
|
|
const preOpen = await page.evaluate(() => window.scrollY)
|
|
await trigger.click()
|
|
|
|
const viewport = page.getByTestId('rs-select-viewport')
|
|
await expect(viewport).toBeVisible({ timeout: 5000 })
|
|
await page.waitForTimeout(200)
|
|
|
|
const item = page.getByTestId('rs-select-apple')
|
|
await item.click()
|
|
await page.waitForTimeout(300)
|
|
await expect(viewport).not.toBeVisible()
|
|
|
|
const postClose = await page.evaluate(() => window.scrollY)
|
|
expect(Math.abs(postClose - preOpen)).toBeLessThanOrEqual(2)
|
|
})
|
|
|
|
test('scroll lock active on mobile while Select open', async ({ page }) => {
|
|
await page.evaluate(() => window.scrollTo(0, 300))
|
|
await page.waitForTimeout(100)
|
|
|
|
const trigger = page.getByTestId('rs-select-trigger')
|
|
await trigger.scrollIntoViewIfNeeded()
|
|
await trigger.click()
|
|
|
|
const viewport = page.getByTestId('rs-select-viewport')
|
|
await expect(viewport).toBeVisible({ timeout: 5000 })
|
|
await page.waitForTimeout(200)
|
|
|
|
const htmlOverflow = await page.evaluate(
|
|
() => getComputedStyle(document.documentElement).overflow
|
|
)
|
|
expect(htmlOverflow).toBe('hidden')
|
|
|
|
await page.keyboard.press('Escape')
|
|
await page.waitForTimeout(300)
|
|
|
|
const afterOverflow = await page.evaluate(
|
|
() => getComputedStyle(document.documentElement).overflow
|
|
)
|
|
expect(afterOverflow).not.toBe('hidden')
|
|
})
|
|
})
|