Files
zeekayandHanzo Dev 54d5e32ac2 store: Prepare keys every unkeyed user and membership on every open; NameKey is read-only in the schema
v1.34.136 keyed old rows only from store.Open, once per store, and a host that opens the store its own way never ran it, so a legacy "Alice" was invisible to the fold lookup and "alice" could register beside it. Prepare runs on every open (store.Open, server.OpenSQLite, and any host's own open path calls it), finds unkeyed rows by the field's absence through its index (orm v0.6.42), and keys each in a transaction that reads it again first, so a racing write is kept. A rollback that unkeys rows is undone at the next open. The one-shot migrations kind is gone. NameKey is a schema.Folded, always written and published readOnly.

Co-authored-by: Hanzo Dev <[email protected]>
2026-10-02 22:25:48 -07:00

77 lines
2.5 KiB
Go
Raw Permalink Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
// Copyright 2026 Hanzo AI, Inc.
// SPDX-License-Identifier: MIT OR Apache-2.0
package schema
import (
"encoding/json"
"strings"
"testing"
)
// Fold(a) == Fold(b) exactly when strings.EqualFold(a, b), across the runes
// whose case is not a simple lower/upper pair.
func TestFoldAgreesWithEqualFold(t *testing.T) {
words := []string{
"alice", "ALICE", "Alice", "aLiCe", "alicf", "",
"k", "K", "K", // Kelvin sign folds with k
"s", "S", "ſ", // long s folds with s
"σ", "Σ", "ς", // sigma's three forms
"Dž", "dž", "DŽ", "straße", "STRASSE", "İstanbul", "istanbul", "ıstanbul",
}
for _, a := range words {
for _, b := range words {
if got, want := Fold(a) == Fold(b), strings.EqualFold(a, b); got != want {
t.Errorf("Fold(%q) == Fold(%q) is %v, EqualFold says %v", a, b, got, want)
}
}
}
}
// A save through the model derives the key of the name it is stored beside,
// on create and on update, replacing whatever the caller left in it.
func TestSavesDeriveTheNameKey(t *testing.T) {
var u User
u.Name, u.NameKey = "Dana", "stale"
if err := u.BeforeCreate(); err != nil || u.NameKey != Folded(Fold("Dana")) {
t.Fatalf("create: NameKey %q, %v; want %q", u.NameKey, err, Fold("Dana"))
}
u.Name = "Erik"
if err := u.BeforeUpdate(nil); err != nil || u.NameKey != Folded(Fold("Erik")) {
t.Fatalf("update after rename: NameKey %q, %v; want %q", u.NameKey, err, Fold("Erik"))
}
var m Membership
m.User = "acme/Dana"
if err := m.BeforeCreate(); err != nil || m.NameKey != Folded(Fold("Dana")) {
t.Fatalf("membership: NameKey %q, %v; want the username half's fold", m.NameKey, err)
}
if MemberKey("nohalf") != "" {
t.Fatal("a user id with no / has no username half to key")
}
}
// The key travels as a plain string, is always written, and is published as a
// string a client reads and never sets.
func TestTheKeyIsAReadOnlyString(t *testing.T) {
var u User
u.Owner, u.Name = "acme", ""
_ = u.BeforeCreate()
b, err := json.Marshal(&u)
if err != nil {
t.Fatal(err)
}
if !strings.Contains(string(b), `"nameKey":""`) {
t.Fatalf("an empty key was not written, so a keyed row would read as unkeyed: %s", b)
}
var back User
u.Name = "Dana"
_ = u.BeforeUpdate(nil)
b, _ = json.Marshal(&u)
if err := json.Unmarshal(b, &back); err != nil || back.NameKey != Folded(Fold("Dana")) {
t.Fatalf("round trip: %q, %v", back.NameKey, err)
}
if got := (Folded("")).JSONSchema(); got["type"] != "string" || got["readOnly"] != true {
t.Fatalf("schema %v", got)
}
}