mirror of
https://github.com/hanzoai/ingress.git
synced 2026-10-20 15:07:40 +00:00
make: default to help instead of building
help is the canonical default verb, and bare `make` here ran `generate binary` — go generate plus a webui build — which is a heavy surprise for someone typing `make` to see what a repo offers. Safe because nothing invokes a bare make: the Dockerfile has none, ci.yml calls `go test` directly rather than a make target, and no script or doc references one. `make default` still builds exactly as before. One line, deliberately. The #? help style is upstream's and it works, so it stays; rewriting it to match another repo's would be churn, not a fix. Co-authored-by: Hanzo Dev <[email protected]>
This commit is contained in:
@@ -20,6 +20,11 @@ LINT_EXECUTABLES = misspell shellcheck
|
||||
DOCKER_BUILD_PLATFORMS ?= linux/amd64,linux/arm64
|
||||
REGISTRY := ghcr.io/hanzoai/ingress
|
||||
|
||||
# Bare `make` prints help instead of building. Nothing invokes a bare make —
|
||||
# not the Dockerfile, not .github/workflows/ci.yml (it calls `go test` directly),
|
||||
# not a script or doc — so this costs nothing, and `make default` still builds.
|
||||
.DEFAULT_GOAL := help
|
||||
|
||||
.PHONY: default
|
||||
#? default: Run `make generate` and `make binary`
|
||||
default: generate binary
|
||||
|
||||
Reference in New Issue
Block a user