Files
insights/.semgrep/rules/devex/api-response-must-match-schema.py
zeekay 1b367e2b62 chore: rebase the tree onto upstream master
The tree was a debranded snapshot of upstream taken around 2026-02-20, and
upstream has moved about five months since. This replaces it with upstream
master, mechanically re-derived: bin/debrand does the rename, and the
pipeline and squashed migrations are restored from the shipped tree.

Not a merge. The previous import replaced the tree wholesale in a single
commit, so there is no shared content history to merge against. Reproducing
the rename on the new tree is what actually converges.

What survives: .hanzo/workflows, the Dockerfiles and bin/docker* entrypoints,
compose files, LLM.md, and insights/migrations. The squashed initial
migration is load-bearing — the live database records it by name, so
upstream's ~918 individual migrations cannot come back.

Nine products are dropped as unreferenced. Twenty-one more that we do not run
are kept anyway because the core app still imports them; unpicking those is a
refactor and does not belong in a rebase.

This base does not build yet, and the reasons are not in the rename:
upstream now wants Python 3.13.13 against our 3.12.12 and Django 5.2 against
our 4.2, and the dependency manifests still name upstream packages that we
republish under our own names. Those are decisions, not renames.
2026-08-01 15:44:40 -07:00

69 lines
1.7 KiB
Python

# Test cases for api-response-must-match-schema rule.
# ruff: noqa: F841, E501
from rest_framework.response import Response
# ============================================================
# Should flag: viewset returns hand-assembled data dict
# ============================================================
def list_things():
# ruleid: api-response-must-match-schema
return Response({"things": [1, 2, 3]})
def detail_thing():
# ruleid: api-response-must-match-schema
return Response({"id": 1, "name": "foo"})
def detail_with_data_kwarg():
# ruleid: api-response-must-match-schema
return Response(data={"id": 1, "name": "foo"})
# ============================================================
# Should NOT flag: conventional DRF error/ack idioms
# ============================================================
def not_found():
# ok: api-response-must-match-schema
return Response({"detail": "Not found"}, status=404)
def not_found_data_kwarg():
# ok: api-response-must-match-schema
return Response(data={"detail": "Not found"}, status=404)
def bad_request():
# ok: api-response-must-match-schema
return Response({"error": "bad input"}, status=400)
def ack():
# ok: api-response-must-match-schema
return Response({"success": True})
def paginated():
# ok: api-response-must-match-schema
return Response({"results": [], "count": 0, "next": None, "previous": None})
# ============================================================
# Should NOT flag: payload constructed via serializer
# ============================================================
class FooSerializer:
pass
def correct_pattern(foo):
# ok: api-response-must-match-schema
return Response(FooSerializer(instance=foo).data)