Files
insights/.semgrep/rules/devex/toolbar-no-raw-fetch.yaml
zeekay 1b367e2b62 chore: rebase the tree onto upstream master
The tree was a debranded snapshot of upstream taken around 2026-02-20, and
upstream has moved about five months since. This replaces it with upstream
master, mechanically re-derived: bin/debrand does the rename, and the
pipeline and squashed migrations are restored from the shipped tree.

Not a merge. The previous import replaced the tree wholesale in a single
commit, so there is no shared content history to merge against. Reproducing
the rename on the new tree is what actually converges.

What survives: .hanzo/workflows, the Dockerfiles and bin/docker* entrypoints,
compose files, LLM.md, and insights/migrations. The squashed initial
migration is load-bearing — the live database records it by name, so
upstream's ~918 individual migrations cannot come back.

Nine products are dropped as unreferenced. Twenty-one more that we do not run
are kept anyway because the core app still imports them; unpicking those is a
refactor and does not belong in a rebase.

This base does not build yet, and the reasons are not in the rename:
upstream now wants Python 3.13.13 against our 3.12.12 and Django 5.2 against
our 4.2, and the dependency manifests still name upstream packages that we
republish under our own names. Those are decisions, not renames.
2026-08-01 15:44:40 -07:00

35 lines
1.5 KiB
YAML

rules:
- id: toolbar-no-raw-fetch
message: |
Raw `fetch(...)` in toolbar code. The toolbar runs on customer pages, where
`window.fetch` may be replaced by wrappers that resolve to non-Response values,
and where network failures (offline, ad blockers, CORS, CSP) are everyday
outcomes - not bugs. A raw fetch bypasses the layer that normalizes those
failures and keeps them out of error tracking.
Use, in order of preference:
• `toolbarApi` (`~/toolbar/toolbarApi`) for authenticated API requests - it
returns a `ToolbarApiResult` union and never throws
• `toolbarFetch` (`~/toolbar/toolbarFetch`) only when you need the raw
`Response` and cannot use `toolbarApi`
• `safeFetch` (`~/toolbar/utils`) for unauthenticated requests (auth flows,
preloads, local blob URLs)
If a raw fetch is genuinely unavoidable (e.g. a circular import), add
`// nosemgrep: toolbar-no-raw-fetch` with a short reason and make sure a
rejection can never escape unhandled.
severity: ERROR
languages: [typescript]
paths:
include:
- frontend/src/toolbar
exclude:
- '**/*.test.ts'
- '**/*.test.tsx'
pattern-either:
- pattern: fetch(...)
- pattern: window.fetch(...)
- pattern: globalThis.fetch(...)
metadata:
category: best-practice