Files
insights/.semgrep/rules/devex/toolbar-transport-no-error-tracking.yaml
zeekay 1b367e2b62 chore: rebase the tree onto upstream master
The tree was a debranded snapshot of upstream taken around 2026-02-20, and
upstream has moved about five months since. This replaces it with upstream
master, mechanically re-derived: bin/debrand does the rename, and the
pipeline and squashed migrations are restored from the shipped tree.

Not a merge. The previous import replaced the tree wholesale in a single
commit, so there is no shared content history to merge against. Reproducing
the rename on the new tree is what actually converges.

What survives: .hanzo/workflows, the Dockerfiles and bin/docker* entrypoints,
compose files, LLM.md, and insights/migrations. The squashed initial
migration is load-bearing — the live database records it by name, so
upstream's ~918 individual migrations cannot come back.

Nine products are dropped as unreferenced. Twenty-one more that we do not run
are kept anyway because the core app still imports them; unpicking those is a
refactor and does not belong in a rebase.

This base does not build yet, and the reasons are not in the rename:
upstream now wants Python 3.13.13 against our 3.12.12 and Django 5.2 against
our 4.2, and the dependency manifests still name upstream packages that we
republish under our own names. Those are decisions, not renames.
2026-08-01 15:44:40 -07:00

24 lines
1.1 KiB
YAML

rules:
- id: toolbar-transport-no-error-tracking
message: |
Exception capture in the toolbar's transport layer. `toolbarFetch` and
`toolbarApi` must never report failures to error tracking: every failure they
see is request-shaped (4xx, 5xx, network, malformed body) and expected on
customer pages. They log via `toolbarLogger`, emit `toolbar api request`
telemetry, and return a failure result (`ToolbarApiResult` / a synthetic
`Response`) for the caller to handle. If a call site needs to raise, it throws
`ToolbarRequestError`, which the global kea loader handler logs without
capturing. Error tracking is reserved for genuine toolbar bugs, reported from
the code that owns them.
severity: ERROR
languages: [typescript]
paths:
include:
- frontend/src/toolbar/toolbarApi.ts
- frontend/src/toolbar/toolbarFetch.ts
pattern-either:
- pattern: captureToolbarException(...)
- pattern: $X.captureException(...)
metadata:
category: best-practice