mirror of
https://github.com/hanzoai/insights.git
synced 2026-11-02 14:32:45 +00:00
zeekay
1b367e2b62
The tree was a debranded snapshot of upstream taken around 2026-02-20, and upstream has moved about five months since. This replaces it with upstream master, mechanically re-derived: bin/debrand does the rename, and the pipeline and squashed migrations are restored from the shipped tree. Not a merge. The previous import replaced the tree wholesale in a single commit, so there is no shared content history to merge against. Reproducing the rename on the new tree is what actually converges. What survives: .hanzo/workflows, the Dockerfiles and bin/docker* entrypoints, compose files, LLM.md, and insights/migrations. The squashed initial migration is load-bearing — the live database records it by name, so upstream's ~918 individual migrations cannot come back. Nine products are dropped as unreferenced. Twenty-one more that we do not run are kept anyway because the core app still imports them; unpicking those is a refactor and does not belong in a rebase. This base does not build yet, and the reasons are not in the rename: upstream now wants Python 3.13.13 against our 3.12.12 and Django 5.2 against our 4.2, and the dependency manifests still name upstream packages that we republish under our own names. Those are decisions, not renames.
38 lines
1.6 KiB
YAML
38 lines
1.6 KiB
YAML
# This rule detects direct model creation in max_tools.py files that should use serializers.
|
|
# Max AI tools should go through serializers to ensure proper validation, rate limiting,
|
|
# metrics logging, and consistent behavior with the rest of the codebase.
|
|
#
|
|
# See: https://github.com/Insights/insights/pull/48087 for context
|
|
rules:
|
|
- id: max-tools-direct-model-create
|
|
patterns:
|
|
- pattern-either:
|
|
- pattern: $MODEL.objects.create(...)
|
|
- pattern: $MODEL.objects.acreate(...)
|
|
- metavariable-regex:
|
|
metavariable: $MODEL
|
|
# Models that have serializers and should not be created directly in max_tools.
|
|
# Add models here as needed (e.g., Experiment, Survey, Task).
|
|
regex: ^(FeatureFlag)$
|
|
message: |
|
|
Direct model creation in max_tools bypasses serializer validation.
|
|
Use the appropriate serializer (e.g., FeatureFlagSerializer) to ensure
|
|
proper validation, rate limiting, and metrics logging.
|
|
|
|
Instead of:
|
|
flag = FeatureFlag.objects.create(team=team, key=key, ...)
|
|
|
|
Use:
|
|
serializer = FeatureFlagSerializer(data=data, context={"request": request, "get_team": lambda: team})
|
|
serializer.is_valid(raise_exception=True)
|
|
flag = serializer.save()
|
|
languages: [python]
|
|
severity: WARNING
|
|
metadata:
|
|
category: correctness
|
|
subcategory: audit
|
|
confidence: HIGH
|
|
paths:
|
|
include:
|
|
- '**/max_tools.py'
|