mirror of
https://github.com/hanzoai/insights.git
synced 2026-11-03 00:52:32 +00:00
zeekayandHanzo Dev
5ac678fd84
PersonHog was the last of it, and it was not only a name. The package is personinsights and the types in it are already Person* -- the shipped descriptor under personinsights_client/proto/generated says PersonService and the tests say TestFakePersonClient -- but the .proto still declared PersonHogService. A client dialling one service name and a server built from a .proto declaring another is not a naming problem, it is a wire that does not connect; the only reason nobody hit it is that none of these services runs here yet. Five service declarations now say what the generated client has said all along. StreamHog was a second fictional company, invented so a Stripe mock had someone to bill. This fork already has Hedgebox, in five hundred fixtures, so the mock bills Hedgebox and there is one made-up company again instead of two. REVIEW_HOG was an enum member in three enums that had to agree, whose value has been `review` since the app was renamed. Only the member said otherwise. Every rule is in bin/debrand and every spelling is refused there, so a fresh upstream import lands on these names and none of them can come back. Two are named as outstanding rather than refused, with the reason each is still sayable: hogdesk survives inside applied migrations' choices lists, where Django compares it in Python and never writes it -- the member is Desk = "desk" and all three tables that store it hold no rows; sherlockhog keys a service in another repository that still calls itself that, and renaming our half would classify its traffic as a product that does not exist. Co-authored-by: Hanzo Dev <[email protected]>
37 lines
1.1 KiB
TypeScript
37 lines
1.1 KiB
TypeScript
import { FEATURE_FLAGS } from 'lib/constants'
|
|
import { urls } from 'scenes/urls'
|
|
|
|
import { FileSystemIconType, ProductItemCategory, ProductKey } from '~/queries/schema/schema-general'
|
|
import { ProductManifest } from '~/types'
|
|
|
|
export const manifest: ProductManifest = {
|
|
name: 'Review',
|
|
scenes: {
|
|
CodeReview: {
|
|
name: 'Code review',
|
|
import: () => import('./frontend/CodeReviewScene'),
|
|
projectBased: true,
|
|
description: 'Automated code reviews of your pull requests, and your review agent settings.',
|
|
iconType: 'code_review',
|
|
},
|
|
},
|
|
routes: {
|
|
'/code-review': ['CodeReview', 'codeReview'],
|
|
},
|
|
urls: {
|
|
codeReview: (): string => '/code-review',
|
|
},
|
|
treeItemsProducts: [
|
|
{
|
|
path: 'Code review',
|
|
intents: [ProductKey.REVIEW],
|
|
category: ProductItemCategory.UNRELEASED,
|
|
iconType: 'code_review' as FileSystemIconType,
|
|
href: urls.codeReview(),
|
|
flag: FEATURE_FLAGS.REVIEW,
|
|
tags: ['alpha'],
|
|
sceneKey: 'CodeReview',
|
|
},
|
|
],
|
|
}
|