mirror of
https://github.com/hanzoai/insights.git
synced 2026-10-30 16:15:31 +00:00
zeekay
1b367e2b62
The tree was a debranded snapshot of upstream taken around 2026-02-20, and upstream has moved about five months since. This replaces it with upstream master, mechanically re-derived: bin/debrand does the rename, and the pipeline and squashed migrations are restored from the shipped tree. Not a merge. The previous import replaced the tree wholesale in a single commit, so there is no shared content history to merge against. Reproducing the rename on the new tree is what actually converges. What survives: .hanzo/workflows, the Dockerfiles and bin/docker* entrypoints, compose files, LLM.md, and insights/migrations. The squashed initial migration is load-bearing — the live database records it by name, so upstream's ~918 individual migrations cannot come back. Nine products are dropped as unreferenced. Twenty-one more that we do not run are kept anyway because the core app still imports them; unpicking those is a refactor and does not belong in a rebase. This base does not build yet, and the reasons are not in the rename: upstream now wants Python 3.13.13 against our 3.12.12 and Django 5.2 against our 4.2, and the dependency manifests still name upstream packages that we republish under our own names. Those are decisions, not renames.
99 lines
3.7 KiB
TypeScript
99 lines
3.7 KiB
TypeScript
/**
|
|
* Runtime regression test for the metric null-injection bug.
|
|
*
|
|
* The generated zod for `metrics` is one flattened object holding every
|
|
* metric-type field, each carrying `.default(null)`. In tool mode the server
|
|
* runs `schema.safeParse(args)`, so zod fills every omitted field with `null`.
|
|
* A clean mean metric then arrives at the API with `series`, `numerator`,
|
|
* `denominator`, `completion_event`, `retention_window_*`, … all set to null,
|
|
* and the backend (pydantic `extra="forbid"`) rejects them as `extra_forbidden`.
|
|
*
|
|
* These tests parse a minimal, valid metric and assert the parser does NOT
|
|
* invent fields the caller never sent.
|
|
*/
|
|
import { describe, expect, it } from 'vitest'
|
|
import { z } from 'zod'
|
|
|
|
import { GENERATED_TOOLS } from '@/tools/generated/experiments'
|
|
import type { ToolBase, ZodObjectAny } from '@/tools/types'
|
|
|
|
function updateSchema(): z.ZodTypeAny {
|
|
const factory = GENERATED_TOOLS['experiment-update'] as () => ToolBase<ZodObjectAny>
|
|
return factory().schema as z.ZodTypeAny
|
|
}
|
|
|
|
/** Keys present-and-null in `parsed` that were absent from `sent` — i.e. invented by zod. */
|
|
function injectedNullKeys(sent: Record<string, unknown>, parsed: Record<string, unknown>): string[] {
|
|
return Object.entries(parsed)
|
|
.filter(([k, v]) => v === null && !(k in sent))
|
|
.map(([k]) => k)
|
|
.sort()
|
|
}
|
|
|
|
const CLEAN_METRICS: Array<[string, Record<string, unknown>]> = [
|
|
[
|
|
'mean',
|
|
{
|
|
kind: 'ExperimentMetric',
|
|
metric_type: 'mean',
|
|
name: 'clean mean',
|
|
source: { kind: 'EventsNode', event: '$pageview', math: 'total' },
|
|
},
|
|
],
|
|
[
|
|
'funnel',
|
|
{
|
|
kind: 'ExperimentMetric',
|
|
metric_type: 'funnel',
|
|
name: 'clean funnel',
|
|
series: [{ kind: 'EventsNode', event: '$pageview' }],
|
|
},
|
|
],
|
|
[
|
|
'ratio',
|
|
{
|
|
kind: 'ExperimentMetric',
|
|
metric_type: 'ratio',
|
|
name: 'clean ratio',
|
|
numerator: { kind: 'EventsNode', event: '$pageview', math: 'total' },
|
|
denominator: { kind: 'EventsNode', event: '$pageview', math: 'total' },
|
|
},
|
|
],
|
|
[
|
|
'retention',
|
|
{
|
|
kind: 'ExperimentMetric',
|
|
metric_type: 'retention',
|
|
name: 'clean retention',
|
|
start_event: { kind: 'EventsNode', event: '$pageview' },
|
|
completion_event: { kind: 'EventsNode', event: '$pageview' },
|
|
retention_window_start: 0,
|
|
retention_window_end: 7,
|
|
retention_window_unit: 'day',
|
|
start_handling: 'first_seen',
|
|
},
|
|
],
|
|
]
|
|
|
|
describe('experiment-update metric null injection', () => {
|
|
it.each(CLEAN_METRICS)('does not inject foreign null fields into a %s metric', (_type, metric) => {
|
|
const parsed = updateSchema().parse({ id: 123, metrics: [metric] }) as Record<string, unknown>
|
|
const parsedMetric = (parsed.metrics as Record<string, unknown>[])[0]!
|
|
expect(injectedNullKeys(metric, parsedMetric)).toEqual([])
|
|
})
|
|
|
|
it('still preserves explicit nulls the caller sends', () => {
|
|
// conversion_window is a valid mean field; an explicit null must survive.
|
|
const metric = {
|
|
kind: 'ExperimentMetric',
|
|
metric_type: 'mean',
|
|
name: 'explicit null',
|
|
source: { kind: 'EventsNode', event: '$pageview', math: 'total' },
|
|
conversion_window: null,
|
|
}
|
|
const parsed = updateSchema().parse({ id: 123, metrics: [metric] }) as Record<string, unknown>
|
|
const parsedMetric = (parsed.metrics as Record<string, unknown>[])[0]!
|
|
expect(parsedMetric).toHaveProperty('conversion_window', null)
|
|
})
|
|
})
|