Files
kv/tests/unit/moduleapi/unsupported_features.tcl
Jacob MurphyandGitHub dd97d3133a Make modules opt-in to atomic slot migration and add server events (#2593)
As discussed in https://github.com/valkey-io/valkey/issues/2579

Notably, I am exposing this feature as "Atomic Slot Migration" to
modules. If we want to call it something else, we should consider that
now (e.g.. "Replication-Based Slot Migration"?)

Also note: I am exposing both target and source node in the event. It is
not guaranteed that either target or source would be the node the event
fires on (e.g. replicas will fire the event after replica containment is
introduced). Even though it could be potentially inferred from CLUSTER
SLOTS, it should help modules parse it this way. Modules should be able
to infer whether it is occurring on primary/replica from `ctx` flags, so
not duplicating that here.

Closes #2579

---------

Signed-off-by: Jacob Murphy <[email protected]>
2025-09-12 12:35:18 -07:00

32 lines
1.3 KiB
Tcl

start_cluster 3 0 {tags {logreqres:skip external:skip cluster} overrides {enable-module-command yes}} {
set testmodule [file normalize tests/modules/unsupported_features.so]
set node0_id [R 0 CLUSTER MYID]
set node1_id [R 1 CLUSTER MYID]
set node2_id [R 2 CLUSTER MYID]
test "ASM blocked by module source" {
assert_match "OK" [R 2 MODULE LOAD $testmodule]
assert_error "ERR The module unsupported_features does not support atomic slot migrations*" {R 2 CLUSTER MIGRATESLOTS SLOTSRANGE 16383 16383 NODE $node0_id}
assert_match "OK" [R 2 MODULE UNLOAD unsupported_features]
}
test "ASM blocked by module target" {
assert_match "OK" [R 0 MODULE LOAD $testmodule]
assert_match "OK" [R 2 CLUSTER MIGRATESLOTS SLOTSRANGE 16383 16383 NODE $node0_id]
wait_for_condition 50 100 {
[dict get [lindex [R 2 CLUSTER GETSLOTMIGRATIONS] 0] state] eq "failed"
} else {
fail "Slot migration did not fail despite target having module that did not support it"
}
assert_match "Received error during handshake to target: -ERR The module unsupported_features does not support atomic slot migrations*" [dict get [lindex [R 2 CLUSTER GETSLOTMIGRATIONS] 0] message]
assert_match "OK" [R 0 MODULE UNLOAD unsupported_features]
}
}