mirror of
https://github.com/hanzoai/metrics.git
synced 2026-10-30 20:03:39 +00:00
Max Kotliar
be3eddf425
The prompb and prompbmarshal share exactly the same models and provide
marshal and unmarshale capabilities for them. This creates duplication
(changes in one model has to be made in another, case with metadata) and
confusion where for example you compare same looking models but golang
says they are not the same (because of the type).
This commit merge prompbmarshal logic into prompb so the rest of the
code is aligned on prompb models.
Moves samplesPool and labelsPool to WriteRequestUnmarshaller.
Make WriteRequest struct clean from unmarshal logic.
The benchmark shows no significant changes:
$benchstat prompbmarshal.bench prompb2.bench
goos: darwin
goarch: arm64
pkg: github.com/VictoriaMetrics/VictoriaMetrics/lib/prompb
cpu: Apple M1 Pro
│ prompbmarshal.bench │ prompb2.bench │
│ sec/op │ sec/op vs base │
WriteRequestUnmarshalProtobuf-10 189.2µ ± 5% 190.8µ ± 8% ~ (p=0.579 n=10)
WriteRequestMarshalProtobuf-10 145.3µ ± 7% 143.6µ ± 2% ~ (p=0.143 n=10)
geomean 165.8µ 165.5µ -0.14%
│ prompbmarshal.bench │ prompb2.bench │
│ B/s │ B/s vs base │
WriteRequestUnmarshalProtobuf-10 50.42Mi ± 5% 49.99Mi ± 8% ~ (p=0.593 n=10)
WriteRequestMarshalProtobuf-10 65.64Mi ± 7% 66.39Mi ± 2% ~ (p=0.143 n=10)
geomean 57.53Mi 57.61Mi +0.14%
│ prompbmarshal.bench │ prompb2.bench │
│ B/op │ B/op vs base │
WriteRequestUnmarshalProtobuf-10 27.70Ki ± 4% 26.90Ki ± 7% ~ (p=0.190 n=10)
WriteRequestMarshalProtobuf-10 3.267Ki ± 12% 3.273Ki ± 12% ~ (p=0.971 n=10)
geomean 9.514Ki 9.383Ki -1.38%
│ prompbmarshal.bench │ prompb2.bench │
│ allocs/op │ allocs/op vs base │
WriteRequestUnmarshalProtobuf-10 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
WriteRequestMarshalProtobuf-10 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
geomean ² +0.00% ²
¹ all samples are equal
² summaries must be >0 to compute geomean
76 lines
2.1 KiB
Go
76 lines
2.1 KiB
Go
package datasource
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
|
|
"github.com/VictoriaMetrics/VictoriaMetrics/lib/prompb"
|
|
)
|
|
|
|
func TestPromInstant_UnmarshalPositive(t *testing.T) {
|
|
f := func(data string, exp []Metric) {
|
|
t.Helper()
|
|
var pi promInstant
|
|
err := pi.Unmarshal([]byte(data))
|
|
if err != nil {
|
|
t.Fatalf("unexpected unmarshal err %v; \n %v", err, string(data))
|
|
}
|
|
got, _ := pi.metrics()
|
|
if !reflect.DeepEqual(got, exp) {
|
|
t.Fatalf("expected to get:\n%v\ngot instead:\n%v", exp, got)
|
|
}
|
|
}
|
|
|
|
f(`[{"metric":{"__name__":"up"},"value":[1583780000,"42"]}]`, []Metric{
|
|
{
|
|
Labels: []prompb.Label{{Name: "__name__", Value: "up"}},
|
|
Timestamps: []int64{1583780000},
|
|
Values: []float64{42},
|
|
},
|
|
})
|
|
f(`[
|
|
{"metric":{"__name__":"up"},"value":[1583780000,"42"]},
|
|
{"metric":{"__name__":"foo"},"value":[1583780001,"7"]},
|
|
{"metric":{"__name__":"baz", "instance":"bar"},"value":[1583780002,"8"]}]`, []Metric{
|
|
{
|
|
Labels: []prompb.Label{{Name: "__name__", Value: "up"}},
|
|
Timestamps: []int64{1583780000},
|
|
Values: []float64{42},
|
|
},
|
|
{
|
|
Labels: []prompb.Label{{Name: "__name__", Value: "foo"}},
|
|
Timestamps: []int64{1583780001},
|
|
Values: []float64{7},
|
|
},
|
|
{
|
|
Labels: []prompb.Label{{Name: "__name__", Value: "baz"}, {Name: "instance", Value: "bar"}},
|
|
Timestamps: []int64{1583780002},
|
|
Values: []float64{8},
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestPromInstant_UnmarshalNegative(t *testing.T) {
|
|
f := func(data string) {
|
|
t.Helper()
|
|
var pi promInstant
|
|
err := pi.Unmarshal([]byte(data))
|
|
if err == nil {
|
|
t.Fatalf("expected to get an error; got nil instead")
|
|
}
|
|
}
|
|
f(``)
|
|
f(`foo`)
|
|
f(`[{"metric":{"__name__":"up"},"value":[1583780000,"42"]},`)
|
|
f(`[{"metric":{"__name__"},"value":[1583780000,"42"]},`)
|
|
// no `metric` object
|
|
f(`[{"value":[1583780000,"42"]}]`)
|
|
// no `value` object
|
|
f(`[{"metric":{"__name__":"up"}}]`)
|
|
// less than 2 values in `value` object
|
|
f(`[{"metric":{"__name__":"up"},"value":["42"]}]`)
|
|
f(`[{"metric":{"__name__":"up"},"value":[1583780000]}]`)
|
|
// non-numeric sample value
|
|
f(`[{"metric":{"__name__":"up"},"value":[1583780000,"foo"]}]`)
|
|
}
|