mirror of
https://github.com/hanzoai/metrics.git
synced 2026-10-30 20:03:39 +00:00
Benjamin Nichols-FarquharandGitHub
dd0bd05778
While server side copies when using the same backup origin and destination are always most efficient there are times when moving between backup locations is required. Right now vmbackup throws an error in these cases. While its true that a user could always do a fresh backup from a snapshot rather than copy an old backup, this requires access to storage data locations and a running vmstorage instance, something that is not _generally_ required for otherwise moving backups around in remote locations using vmbackup. This is a small change that makes the moving of backups from one location to another transparent to users, without having to consider if those locations are the same or different. This both simplifies backup migrations and unlocks using vmbackup for more complex operations. Specifically this came up in my use case because we want to orchestrate the down-scaling of EBS volumes backing our vmstorage cluster, which requires some complex backup operations, one of which being taking a backup from s3 to a local filesystem. Related PR https://github.com/VictoriaMetrics/VictoriaMetrics/pull/10401