mirror of
https://github.com/hanzoai/metrics.git
synced 2026-10-30 20:03:39 +00:00
Zakhar BessarabandGitHub
f55aa3ff43
### Describe Your Changes
Properly check precense of `/`, previously it was
ignoring a case where "/" would be at the beginning of the string.
This is a follow-up for 8c14dbe6
---------
Signed-off-by: Zakhar Bessarab <[email protected]>
70 lines
1.7 KiB
Go
70 lines
1.7 KiB
Go
package netutil
|
|
|
|
import (
|
|
"net"
|
|
"testing"
|
|
)
|
|
|
|
func TestIsErrMissingPort(t *testing.T) {
|
|
f := func(addr string, expected bool) {
|
|
t.Helper()
|
|
_, _, err := net.SplitHostPort(addr)
|
|
if IsErrMissingPort(err) != expected {
|
|
t.Fatalf("unexpected result for %q; got %v; want %v", addr, !expected, expected)
|
|
}
|
|
}
|
|
|
|
f("127.0.0.1", true)
|
|
f("http://127.0.0.1:8080", false)
|
|
|
|
f("[::1]", true)
|
|
f("http://[::1]:8080", false)
|
|
|
|
f("vmstorage-0", true)
|
|
f("vmstorage-0.svc.cluster.local.", true)
|
|
f("http://vmstorage-0:8080", false)
|
|
f("http://vmstorage-0.svc.cluster.local.:8080", false)
|
|
}
|
|
|
|
func TestNormalizeAddrSuccess(t *testing.T) {
|
|
f := func(addr string, defaultPort int, expected string) {
|
|
t.Helper()
|
|
result, err := NormalizeAddr(addr, defaultPort)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error for %q: %v", addr, err)
|
|
}
|
|
if result != expected {
|
|
t.Fatalf("unexpected result for %q; got %q; want %q", addr, result, expected)
|
|
}
|
|
}
|
|
|
|
f("127.0.0.1", 80, "127.0.0.1:80")
|
|
f("127.0.0.1:123", 80, "127.0.0.1:123")
|
|
f("[::1]", 80, "[::1]:80")
|
|
f("[::1]:123", 80, "[::1]:123")
|
|
f("vmstorage-0.svc.cluster.local.", 80, "vmstorage-0.svc.cluster.local.:80")
|
|
f("vmstorage-0.svc.cluster.local.:123", 80, "vmstorage-0.svc.cluster.local.:123")
|
|
}
|
|
|
|
func TestNormalizeAddrError(t *testing.T) {
|
|
f := func(addr string) {
|
|
t.Helper()
|
|
_, err := NormalizeAddr(addr, 80)
|
|
if err == nil {
|
|
t.Fatalf("expected error for %q, but got none", addr)
|
|
}
|
|
}
|
|
|
|
// Invalid number of octets in address
|
|
f("1:2:3:4:5:6:7:8:9:10")
|
|
// Invalid IPv6 address format
|
|
f("::1:2:3:4:5:6:7:8:9")
|
|
|
|
// Invalid address format
|
|
f("http://127.0.0.1")
|
|
f("http://127.0.0.1:80")
|
|
f("http://vmstorage-0.svc.cluster.local.")
|
|
f("http://vmstorage-0.svc.cluster.local.:80")
|
|
f("/vmstorage-0.svc.cluster.local.:80")
|
|
}
|