mirror of
https://github.com/hanzoai/metrics.git
synced 2026-10-30 20:03:39 +00:00
NikolayandGitHub
d3a8460eb9
Previously, for `^` aka pow function calls, VictoriaMetrics returned `1` if left arg was Nan. For example, given query=`(hour()==2)^1` returns 1 for NaN produced by hour() == 2 function. It added additional non-exist datapoints to the timeseries. This commit port bugfix from `metricql` package and adds test for it. Now, VictoriaMetrics correctly returns `NaN` for such cases. Related issue: https://github.com/VictoriaMetrics/VictoriaMetrics/issues/7359 Signed-off-by: f41gh7 <[email protected]>
131 lines
2.7 KiB
Go
131 lines
2.7 KiB
Go
package binaryop
|
|
|
|
import (
|
|
"math"
|
|
)
|
|
|
|
var nan = math.NaN()
|
|
|
|
// Eq returns true of left == right.
|
|
func Eq(left, right float64) bool {
|
|
// Special handling for nan == nan.
|
|
// See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/150 .
|
|
if math.IsNaN(left) {
|
|
return math.IsNaN(right)
|
|
}
|
|
return left == right
|
|
}
|
|
|
|
// Neq returns true of left != right.
|
|
func Neq(left, right float64) bool {
|
|
// Special handling for comparison with nan.
|
|
// See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/150 .
|
|
if math.IsNaN(left) {
|
|
return !math.IsNaN(right)
|
|
}
|
|
if math.IsNaN(right) {
|
|
return true
|
|
}
|
|
return left != right
|
|
}
|
|
|
|
// Gt returns true of left > right
|
|
func Gt(left, right float64) bool {
|
|
return left > right
|
|
}
|
|
|
|
// Lt returns true if left < right
|
|
func Lt(left, right float64) bool {
|
|
return left < right
|
|
}
|
|
|
|
// Gte returns true if left >= right
|
|
func Gte(left, right float64) bool {
|
|
return left >= right
|
|
}
|
|
|
|
// Lte returns true if left <= right
|
|
func Lte(left, right float64) bool {
|
|
return left <= right
|
|
}
|
|
|
|
// Plus returns left + right
|
|
func Plus(left, right float64) float64 {
|
|
return left + right
|
|
}
|
|
|
|
// Minus returns left - right
|
|
func Minus(left, right float64) float64 {
|
|
return left - right
|
|
}
|
|
|
|
// Mul returns left * right
|
|
func Mul(left, right float64) float64 {
|
|
return left * right
|
|
}
|
|
|
|
// Div returns left / right
|
|
func Div(left, right float64) float64 {
|
|
return left / right
|
|
}
|
|
|
|
// Mod returns mod(left, right)
|
|
func Mod(left, right float64) float64 {
|
|
return math.Mod(left, right)
|
|
}
|
|
|
|
// Pow returns pow(left, right) if left is not NaN. Otherwise NaN is returned.
|
|
func Pow(left, right float64) float64 {
|
|
// special case for NaN^any
|
|
// See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/7359
|
|
if math.IsNaN(left) {
|
|
return nan
|
|
}
|
|
return math.Pow(left, right)
|
|
}
|
|
|
|
// Atan2 returns atan2(left, right)
|
|
func Atan2(left, right float64) float64 {
|
|
return math.Atan2(left, right)
|
|
}
|
|
|
|
// Default returns left or right if left is NaN.
|
|
func Default(left, right float64) float64 {
|
|
if math.IsNaN(left) {
|
|
return right
|
|
}
|
|
return left
|
|
}
|
|
|
|
// If returns left if right is not NaN. Otherwise NaN is returned.
|
|
func If(left, right float64) float64 {
|
|
if math.IsNaN(right) {
|
|
return nan
|
|
}
|
|
return left
|
|
}
|
|
|
|
// Ifnot returns left if right is NaN. Otherwise NaN is returned.
|
|
func Ifnot(left, right float64) float64 {
|
|
if math.IsNaN(right) {
|
|
return left
|
|
}
|
|
return nan
|
|
}
|
|
|
|
// And return left if left and right is not NaN. Otherwise, NaN is returned.
|
|
func And(left, right float64) float64 {
|
|
if math.IsNaN(left) || math.IsNaN(right) {
|
|
return nan
|
|
}
|
|
return left
|
|
}
|
|
|
|
// Or return the first non-NaN item. If both left and right are NaN, it returns NaN.
|
|
func Or(left, right float64) float64 {
|
|
if !math.IsNaN(left) {
|
|
return left
|
|
}
|
|
return right
|
|
}
|