Files
mpc/cmd/mpcd/threshold_test.go
zeekayandHanzo Dev 293aa4be07 fix(mpcd): wire --threshold into CGGMP21 keygen degree (was silently 1-of-n)
hanzo/mpc builds its OWN cmd/mpcd (mirrors luxfi/mpc verbatim except for Hanzo
defaults), so luxfi's fix 1e1d318 did not reach this binary. Apply it here:
runNodeConsensus now viper.Set("mpc_threshold", keygenDegreeForThreshold(threshold))
so the CGGMP21 keygen degree (read via viper by pkg/eventconsumer) tracks the
operator-facing --threshold. degree = threshold-1: hanzo-mpc --threshold=2 ->
degree 1 -> genuine 2-of-3 (was degree 0 = 1-of-3, any single node could sign).
Named+unit-tested keygenDegreeForThreshold makes the off-by-one explicit.

Also regenerate go.sum for luxfi/* + hanzoai/* re-tag staleness (age, base, etc.)
so the binary builds; luxfi/mpc library stays at the proven v1.14.13.

Co-authored-by: Hanzo Dev <[email protected]>
2026-07-14 18:08:50 -07:00

41 lines
1.4 KiB
Go

package main
import "testing"
// TestKeygenDegreeForThreshold pins the security-critical off-by-one that keeps
// t-of-n keys honest on the Hanzo ring. Before this mapping was wired into
// runNodeConsensus (mirroring luxfi/mpc fix 1e1d318), the CGGMP21 keygen degree
// defaulted to 0 (1-of-n: any single share signs) because nothing connected the
// --threshold flag to viper key "mpc_threshold". hanzo-mpc runs --threshold=2,
// so the honest degree is 1 (2-of-3).
func TestKeygenDegreeForThreshold(t *testing.T) {
cases := []struct {
name string
threshold int // operator-facing --threshold = signers required (N in N-of-M)
wantDegree int // cmp.Keygen polynomial degree
wantSigners int // degree+1 = parties needed to sign
}{
{"hanzo-2-of-3", 2, 1, 2},
{"3-of-5", 3, 2, 3},
{"single-signer-dev", 1, 0, 1},
{"guard-zero", 0, 0, 0},
{"guard-negative", -1, 0, 0},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
got := keygenDegreeForThreshold(tc.threshold)
if got != tc.wantDegree {
t.Fatalf("keygenDegreeForThreshold(%d) = %d, want %d", tc.threshold, got, tc.wantDegree)
}
if tc.threshold >= 2 && got < 1 {
t.Fatalf("threshold=%d produced degree %d (1-of-n) — threshold security lost", tc.threshold, got)
}
if tc.threshold >= 1 {
if signers := got + 1; signers != tc.wantSigners {
t.Fatalf("threshold=%d: signers=%d, want %d", tc.threshold, signers, tc.wantSigners)
}
}
})
}
}