mirror of
https://github.com/hanzoai/next.js.git
synced 2026-09-24 17:00:51 +00:00
Tim NeutkensandGitHub
e860cec656
### What? Migrate remaining direct `next-webdriver` test callers that have a `NextInstance` to `next.browser()`, and expose the shared `Playwright` browser type from `e2e-utils`. ### Why? `NextInstance.browser` should be the supported browser-opening interface for test fixtures, with `next-webdriver` kept as the private implementation detail. ### How? Updated affected development, e2e, and production tests to call `next.browser()` directly, passing `baseUrl` where tests intentionally target a manually spawned or proxied server. Shared helpers now receive browser callbacks from the test context, and browser types import `Playwright` from `e2e-utils` instead of deriving from `next.browser` or importing from private paths. <!-- NEXT_JS_LLM_PR -->
76 lines
2.4 KiB
TypeScript
76 lines
2.4 KiB
TypeScript
import { join } from 'path'
|
|
import { FileRef, nextTestSetup } from 'e2e-utils'
|
|
import { fetchViaHTTP, renderViaHTTP } from 'next-test-utils'
|
|
|
|
describe.each([[''], ['/docs']])(
|
|
'misc basic dev tests, basePath: %p',
|
|
(basePath: string) => {
|
|
const { next } = nextTestSetup({
|
|
files: {
|
|
pages: new FileRef(join(__dirname, 'misc/pages')),
|
|
public: new FileRef(join(__dirname, 'misc/public')),
|
|
},
|
|
nextConfig: {
|
|
basePath,
|
|
},
|
|
})
|
|
|
|
it('should set process.env.NODE_ENV in development', async () => {
|
|
const browser = await next.browser(basePath + '/process-env')
|
|
const nodeEnv = await browser.elementByCss('#node-env').text()
|
|
expect(nodeEnv).toBe('development')
|
|
await browser.close()
|
|
})
|
|
|
|
it('should allow access to public files', async () => {
|
|
const data = await renderViaHTTP(next.url, basePath + '/data/data.txt')
|
|
expect(data).toBe('data')
|
|
|
|
const legacy = await renderViaHTTP(
|
|
next.url,
|
|
basePath + '/static/legacy.txt'
|
|
)
|
|
expect(legacy).toMatch(`new static folder`)
|
|
})
|
|
|
|
describe('With Security Related Issues', () => {
|
|
it('should not allow accessing files outside .next/static and .next/server directory', async () => {
|
|
const pathsToCheck = [
|
|
basePath + '/_next/static/../BUILD_ID',
|
|
basePath + '/_next/static/../routes-manifest.json',
|
|
]
|
|
for (const path of pathsToCheck) {
|
|
const res = await fetchViaHTTP(next.url, path)
|
|
const text = await res.text()
|
|
try {
|
|
expect(res.status).toBe(404)
|
|
expect(text).toMatch(/This page could not be found/)
|
|
} catch (err) {
|
|
throw new Error(`Path ${path} accessible from the browser`)
|
|
}
|
|
}
|
|
})
|
|
|
|
it('should handle encoded / value for trailing slash correctly', async () => {
|
|
const res = await fetchViaHTTP(
|
|
next.url,
|
|
basePath + '/%2fexample.com/',
|
|
undefined,
|
|
{
|
|
redirect: 'manual',
|
|
}
|
|
)
|
|
|
|
const { pathname, hostname } = new URL(
|
|
res.headers.get('location') || ''
|
|
)
|
|
expect(res.status).toBe(308)
|
|
expect(pathname).toBe(basePath + '/%2fexample.com')
|
|
expect(hostname).not.toBe('example.com')
|
|
const text = await res.text()
|
|
expect(text).toEqual(basePath + '/%2fexample.com')
|
|
})
|
|
})
|
|
}
|
|
)
|