mirror of
https://github.com/hanzoai/next.js.git
synced 2026-09-24 17:00:51 +00:00
Niklas MischkulnigandGitHub
7e0fc3b271
Closes PACK-5382
Previously, Turbopack validated every single module for route segment config, leading to false positives (on non-page files) and worse build performance. There were also three separate implementations of this logic.
Now, all of these cases are fatal errors, not just warnings.
Examples for errors
```
./bench/basic-app/app/export/inherit/page.tsx:1:28
Next.js can't recognize the exported `preferredRegion` field in route. It needs to be a static string or array of static strings.
> 1 | export { default, runtime, preferredRegion } from '../basic/foo'
| ^^^^^^^^^^^^^^^
The exported configuration object in a source file needs to have a very specific format from which some properties can be statically parsed at compiled-time.
https://nextjs.org/docs/app/api-reference/file-conventions/route-segment-config
```
This error message is slightly different now:
```
browser log: ./test/integration/app-dir-export/app/another/[slug]/page.js:6:8
Next.js can't recognize the exported `generateStaticParams` field in route. App pages cannot use both "use client" and export function "generateStaticParams()".
4 |
5 |
> 6 | export function generateStaticParams() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 7 | return [{ slug: 'first' }, { slug: 'second' }]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 8 | }
| ^^
9 |
10 | export default async function Page(props) {
11 | const params = await props.params
The exported configuration object in a source file needs to have a very specific format from which some properties can be statically parsed at compiled-time.
Import traces:
Client Component Browser:
./test/integration/app-dir-export/app/another/[slug]/page.js [Client Component Browser]
./test/integration/app-dir-export/app/another/[slug]/page.js [Server Component]
Client Component SSR:
./test/integration/app-dir-export/app/another/[slug]/page.js [Client Component SSR]
./test/integration/app-dir-export/app/another/[slug]/page.js [Server Component]
https://nextjs.org/docs/app/api-reference/file-conventions/route-segment-config
```
104 lines
3.0 KiB
TypeScript
104 lines
3.0 KiB
TypeScript
import { nextTestSetup } from 'e2e-utils'
|
|
import { check } from 'next-test-utils'
|
|
|
|
describe('app-dir edge SSR', () => {
|
|
const { next, skipped } = nextTestSetup({
|
|
files: __dirname,
|
|
skipDeployment: true,
|
|
})
|
|
|
|
if (skipped) {
|
|
return
|
|
}
|
|
|
|
it('should handle edge only routes', async () => {
|
|
const appHtml = await next.render('/edge/basic')
|
|
expect(appHtml).toContain('<p>Edge!</p>')
|
|
|
|
const pageHtml = await next.render('/pages-edge')
|
|
expect(pageHtml).toContain('<p>pages-edge-ssr</p>')
|
|
})
|
|
|
|
it('should retrieve cookies in a server component in the edge runtime', async () => {
|
|
const res = await next.fetch('/edge-apis/cookies')
|
|
expect(await res.text()).toInclude('Hello')
|
|
})
|
|
|
|
it('should treat process as object without polyfill in edge runtime', async () => {
|
|
const $ = await next.render$('/edge-apis/process')
|
|
expect(await $('#process').text()).toContain('object')
|
|
})
|
|
|
|
it('should handle /index routes correctly', async () => {
|
|
const appHtml = await next.render('/index')
|
|
expect(appHtml).toContain('the /index route')
|
|
})
|
|
|
|
if ((globalThis as any).isNextDev) {
|
|
it('should resolve module without error in edge runtime', async () => {
|
|
const logs = []
|
|
next.on('stderr', (log) => {
|
|
logs.push(log)
|
|
})
|
|
await next.render('/app-edge')
|
|
expect(logs.some((log) => log.includes(`Attempted import error:`))).toBe(
|
|
false
|
|
)
|
|
})
|
|
|
|
it('should resolve client component without error', async () => {
|
|
const logs = []
|
|
next.on('stderr', (log) => {
|
|
if (!log.includes('experimental edge runtime')) {
|
|
logs.push(log)
|
|
}
|
|
})
|
|
const html = await next.render('/with-client')
|
|
expect(html).toContain('My Button')
|
|
expect(logs).toEqual([])
|
|
})
|
|
|
|
it('should handle edge rsc hmr', async () => {
|
|
const pageFile = 'app/edge/basic/page.tsx'
|
|
const content = await next.readFile(pageFile)
|
|
|
|
// Update rendered content
|
|
const updatedContent = content.replace('Edge!', 'edge-hmr')
|
|
await next.patchFile(pageFile, updatedContent)
|
|
await check(async () => {
|
|
const html = await next.render('/edge/basic')
|
|
return html
|
|
}, /edge-hmr/)
|
|
|
|
// Revert
|
|
await next.patchFile(pageFile, content)
|
|
await check(async () => {
|
|
const html = await next.render('/edge/basic')
|
|
return html
|
|
}, /Edge!/)
|
|
})
|
|
} else {
|
|
// Production tests
|
|
it('should generate matchers correctly in middleware manifest', async () => {
|
|
const manifest = JSON.parse(
|
|
await next.readFile('.next/server/middleware-manifest.json')
|
|
)
|
|
if (process.env.IS_TURBOPACK_TEST) {
|
|
expect(manifest.functions['/(group)/group/page'].matchers).toEqual([
|
|
{
|
|
regexp: '^/group(?:/)?$',
|
|
originalSource: '/group',
|
|
},
|
|
])
|
|
} else {
|
|
expect(manifest.functions['/(group)/group/page'].matchers).toEqual([
|
|
{
|
|
regexp: '^/group$',
|
|
originalSource: '/group',
|
|
},
|
|
])
|
|
}
|
|
})
|
|
}
|
|
})
|