mirror of
https://github.com/hanzoai/next.js.git
synced 2026-09-24 17:00:51 +00:00
The React Server Components transform validates route segment configs (rejecting `runtime`, `dynamic`, `revalidate`, and friends under Cache Components) only for `page`, `layout`, and `route` entries, so metadata convention files slipped past the check. Because these files compile to route handlers and accept the same configs, this change extends the match to `icon`, `apple-icon`, `opengraph-image`, `twitter-image`, `sitemap`, `robots`, and `manifest`. Exporting `runtime = 'edge'` (or any other unsupported config) from one of them is now a compile-time error that matches the behavior for regular routes, instead of surfacing later as a confusing bundling failure. The `metadata-font` suite, which intentionally builds edge-runtime image routes, joins the other edge metadata suites that are excluded from the Cache Components test run.
174 lines
6.4 KiB
TypeScript
174 lines
6.4 KiB
TypeScript
import { nextTestSetup } from 'e2e-utils'
|
|
import {
|
|
retry,
|
|
waitForRedbox,
|
|
getRedboxDescription,
|
|
getRedboxSource,
|
|
} from 'next-test-utils'
|
|
|
|
describe('cache-components-segment-configs', () => {
|
|
const { next, skipped, isNextDev, isTurbopack } = nextTestSetup({
|
|
files: __dirname + '/fixtures/default',
|
|
skipStart: true,
|
|
skipDeployment: true,
|
|
})
|
|
|
|
if (skipped) {
|
|
return
|
|
}
|
|
|
|
it("it should error when using segment configs that aren't supported by cacheComponents", async () => {
|
|
try {
|
|
await next.start()
|
|
} catch {
|
|
// we expect the build to fail
|
|
}
|
|
|
|
if (isNextDev) {
|
|
const browser = await next.browser('/revalidate')
|
|
await waitForRedbox(browser)
|
|
const redbox = {
|
|
description: await getRedboxDescription(browser),
|
|
source: await getRedboxSource(browser),
|
|
}
|
|
|
|
if (isTurbopack) {
|
|
expect(redbox.description).toMatchInlineSnapshot(
|
|
`"Route segment config "revalidate" is not compatible with \`nextConfig.cacheComponents\`. Please remove it."`
|
|
)
|
|
} else {
|
|
expect(redbox.description).toMatchInlineSnapshot(
|
|
`" x Route segment config "revalidate" is not compatible with \`nextConfig.cacheComponents\`. Please remove it."`
|
|
)
|
|
}
|
|
expect(redbox.source).toContain(
|
|
'"revalidate" is not compatible with `nextConfig.cacheComponents`. Please remove it.'
|
|
)
|
|
} else {
|
|
expect(next.cliOutput).toContain('./app/dynamic-params/[slug]/page.tsx')
|
|
expect(next.cliOutput).toContain(
|
|
'"dynamicParams" is not compatible with `nextConfig.cacheComponents`. Please remove it.'
|
|
)
|
|
expect(next.cliOutput).toContain('./app/dynamic/nested/page.tsx')
|
|
expect(next.cliOutput).toContain('./app/dynamic/page.tsx')
|
|
expect(next.cliOutput).toContain(
|
|
'"dynamic" is not compatible with `nextConfig.cacheComponents`. Please remove it.'
|
|
)
|
|
|
|
expect(next.cliOutput).toContain('./app/fetch-cache/page.tsx')
|
|
expect(next.cliOutput).toContain(
|
|
'"fetchCache" is not compatible with `nextConfig.cacheComponents`. Please remove it.'
|
|
)
|
|
|
|
expect(next.cliOutput).toContain('./app/revalidate/page.tsx')
|
|
expect(next.cliOutput).toContain(
|
|
'"revalidate" is not compatible with `nextConfig.cacheComponents`. Please remove it.'
|
|
)
|
|
|
|
// The remaining fixtures opt into `export const runtime = 'edge'` (the
|
|
// `runtime` page and the metadata convention files, which compile to
|
|
// route handlers and accept the same route segment configs). `next build`
|
|
// prints only the first five webpack errors and appends the edge
|
|
// compiler's errors last, so the five Node-runtime page errors above fill
|
|
// that limit and these edge-runtime errors are truncated from webpack's
|
|
// output. They're only asserted under Turbopack, which reports every
|
|
// build error.
|
|
if (isTurbopack) {
|
|
expect(next.cliOutput).toContain('./app/runtime/page.tsx')
|
|
|
|
expect(next.cliOutput).toContain('./app/metadata/icon.tsx')
|
|
expect(next.cliOutput).toContain('./app/metadata/apple-icon.tsx')
|
|
expect(next.cliOutput).toContain('./app/metadata/opengraph-image.tsx')
|
|
expect(next.cliOutput).toContain('./app/metadata/twitter-image.tsx')
|
|
expect(next.cliOutput).toContain('./app/metadata/sitemap.ts')
|
|
|
|
// Emitted once for each fixture that exports `runtime`:
|
|
// `runtime/page.tsx`, `multiple/page.tsx`, and the five `metadata/*`
|
|
// convention files.
|
|
expect(next.cliOutput).toIncludeRepeated(
|
|
'"runtime" is not compatible with `nextConfig.cacheComponents`. Please remove it.',
|
|
7
|
|
)
|
|
}
|
|
}
|
|
})
|
|
|
|
it('should propagate configurations from layouts to pages', async () => {
|
|
// patch the root layout. We expect the "dynamic" segment config to now be part of
|
|
// each sub-page that uses this layout.
|
|
await next.patchFile(
|
|
'app/layout.tsx',
|
|
(content) => {
|
|
return `
|
|
export const runtime = 'nodejs';
|
|
${content}
|
|
`
|
|
},
|
|
async () => {
|
|
try {
|
|
await next.start()
|
|
} catch {
|
|
// we expect the build to fail
|
|
}
|
|
|
|
if (isNextDev) {
|
|
const browser = await next.browser('/revalidate')
|
|
await waitForRedbox(browser)
|
|
const redbox = {
|
|
description: await getRedboxDescription(browser),
|
|
source: await getRedboxSource(browser),
|
|
}
|
|
|
|
if (isTurbopack) {
|
|
// The page-level error is shown first in the redbox, but
|
|
// the layout error is also present in the CLI output.
|
|
expect(redbox.description).toMatchInlineSnapshot(
|
|
`"Route segment config "revalidate" is not compatible with \`nextConfig.cacheComponents\`. Please remove it."`
|
|
)
|
|
} else {
|
|
expect(redbox.description).toMatchInlineSnapshot(
|
|
`" x Route segment config "runtime" is not compatible with \`nextConfig.cacheComponents\`. Please remove it."`
|
|
)
|
|
}
|
|
expect(redbox.source).toContain(
|
|
'is not compatible with `nextConfig.cacheComponents`. Please remove it.'
|
|
)
|
|
// Verify that the "runtime" error from the layout propagation
|
|
// is present in the CLI output even if it's not the first error
|
|
// shown in the redbox.
|
|
expect(next.cliOutput).toContain(
|
|
'"runtime" is not compatible with `nextConfig.cacheComponents`. Please remove it.'
|
|
)
|
|
} else {
|
|
await retry(async () => {
|
|
expect(next.cliOutput).toContain(
|
|
'"runtime" is not compatible with `nextConfig.cacheComponents`. Please remove it.'
|
|
)
|
|
|
|
// the stack trace is different between turbopack/webpack
|
|
if (isTurbopack) {
|
|
expectLinesToAppearTogether(next.cliOutput, [
|
|
'./app/layout.tsx:2:24',
|
|
])
|
|
} else {
|
|
expectLinesToAppearTogether(next.cliOutput, [
|
|
'Import trace for requested module:',
|
|
'./app/fetch-cache/page.tsx',
|
|
'./app/layout.tsx',
|
|
])
|
|
}
|
|
})
|
|
}
|
|
}
|
|
)
|
|
})
|
|
})
|
|
|
|
function expectLinesToAppearTogether(output: string, lines: string[]) {
|
|
const escapedLines = lines.map((line) =>
|
|
line.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')
|
|
)
|
|
const pattern = new RegExp(escapedLines.join('\\s*'), 's')
|
|
expect(output).toMatch(pattern)
|
|
}
|