mirror of
https://github.com/hanzoai/next.js.git
synced 2026-09-24 17:00:51 +00:00
Hendrik LiebauandGitHub
cfc9349332
Errors thrown while collecting page data, such as an empty `generateStaticParams` under Cache Components, printed a source-mapped stack in the build output but no code frame, unlike prerender errors from the export worker which show the offending source lines. The static worker exposes both `isPageStatic` and `exportPages`, but only `exportPages` called `installCodeFrameSupport`, so when `isPageStatic` ran the code-frame renderer was never registered and the frame was dropped even though the stack itself was already source-mapped. This installs the native bindings and code-frame support in the static worker entry (`build/worker.ts`) by wrapping the exposed `isPageStatic`, mirroring what `exportPages` already does. It is deliberately not done in `build/utils.ts`: that module is reachable from `next-server` through the dev server, so importing the code-frame installer there pulls the devtools renderer (`next-devtools/server/shared`) into the production server's file trace, which the `next-server-nft` test rightly rejects. The worker entry is only loaded by build workers, so the renderer stays out of the runtime server. Both installs are idempotent. With the renderer registered, a build error thrown from `generateStaticParams` now prints the same code frame as a prerender error, pointing at the offending line. The frame is only rendered when the source map carries source content, which happens under `--debug-prerender` (and otherwise `serverSourceMaps`), so normal minified production builds are unaffected. The `empty-generate-static-params` end-to-end test is updated to assert the code frame that now appears in the build error for both the literal and the computed empty array cases.
147 lines
5.8 KiB
TypeScript
147 lines
5.8 KiB
TypeScript
import { nextTestSetup } from 'e2e-utils'
|
|
|
|
describe('empty-generate-static-params', () => {
|
|
const { next, isNextDev, isTurbopack, skipped } = nextTestSetup({
|
|
files: __dirname,
|
|
skipStart: true,
|
|
skipDeployment: true,
|
|
})
|
|
|
|
if (skipped) {
|
|
return
|
|
}
|
|
|
|
function errorBlock(cliOutput: string) {
|
|
return cliOutput.slice(
|
|
cliOutput.indexOf('When using Cache Components'),
|
|
cliOutput.indexOf('Build error occurred')
|
|
)
|
|
}
|
|
|
|
if (isNextDev) {
|
|
beforeAll(() => next.start())
|
|
|
|
it('points the redbox at a literal empty array', async () => {
|
|
const browser = await next.browser('/foo')
|
|
await expect(browser).toDisplayRedbox(`
|
|
{
|
|
"code": "E394",
|
|
"description": "When using Cache Components, all \`generateStaticParams\` functions must return at least one result. This is to ensure that we can perform build-time validation that there is no other dynamic accesses that would cause a runtime error.
|
|
|
|
Learn more: https://nextjs.org/docs/messages/empty-generate-static-params",
|
|
"environmentLabel": null,
|
|
"label": "Runtime Error",
|
|
"source": "app/[slug]/page.tsx (10:10) @ generateStaticParams
|
|
> 10 | return []
|
|
| ^",
|
|
"stack": [
|
|
"generateStaticParams app/[slug]/page.tsx (10:10)",
|
|
],
|
|
}
|
|
`)
|
|
})
|
|
|
|
it('points the redbox at the declaration for a computed empty array', async () => {
|
|
const browser = await next.browser('/computed/foo')
|
|
await expect(browser).toDisplayRedbox(`
|
|
{
|
|
"code": "E394",
|
|
"description": "When using Cache Components, all \`generateStaticParams\` functions must return at least one result. This is to ensure that we can perform build-time validation that there is no other dynamic accesses that would cause a runtime error.
|
|
|
|
Learn more: https://nextjs.org/docs/messages/empty-generate-static-params",
|
|
"environmentLabel": null,
|
|
"label": "Runtime Error",
|
|
"source": "app/computed/[slug]/page.tsx (9:8) @ generateStaticParams
|
|
> 9 | export async function generateStaticParams() {
|
|
| ^",
|
|
"stack": [
|
|
"generateStaticParams app/computed/[slug]/page.tsx (9:8)",
|
|
],
|
|
}
|
|
`)
|
|
})
|
|
} else {
|
|
// Build one page at a time so each route's build error is isolated and can
|
|
// be asserted individually.
|
|
async function buildPage(page: string) {
|
|
const { exitCode, cliOutput } = await next.build({
|
|
args: ['--debug-prerender', '--debug-build-paths', page],
|
|
})
|
|
expect(exitCode).not.toBe(0)
|
|
return errorBlock(cliOutput)
|
|
}
|
|
|
|
it('points the literal empty array build error at the array', async () => {
|
|
const block = await buildPage('app/[slug]/page.tsx')
|
|
if (isTurbopack) {
|
|
expect(block).toMatchInlineSnapshot(`
|
|
"When using Cache Components, all \`generateStaticParams\` functions must return at least one result. This is to ensure that we can perform build-time validation that there is no other dynamic accesses that would cause a runtime error.
|
|
|
|
Learn more: https://nextjs.org/docs/messages/empty-generate-static-params
|
|
at generateStaticParams (app/[slug]/page.tsx:10:10)
|
|
8 |
|
|
9 | export async function generateStaticParams() {
|
|
> 10 | return []
|
|
| ^
|
|
11 | }
|
|
12 |
|
|
|
|
> "
|
|
`)
|
|
} else {
|
|
expect(block).toMatchInlineSnapshot(`
|
|
"When using Cache Components, all \`generateStaticParams\` functions must return at least one result. This is to ensure that we can perform build-time validation that there is no other dynamic accesses that would cause a runtime error.
|
|
|
|
Learn more: https://nextjs.org/docs/messages/empty-generate-static-params
|
|
at generateStaticParams (webpack:///app/[slug]/page.tsx:10:10)
|
|
8 |
|
|
9 | export async function generateStaticParams() {
|
|
> 10 | return []
|
|
| ^
|
|
11 | }
|
|
12 |
|
|
|
|
> "
|
|
`)
|
|
}
|
|
})
|
|
|
|
it('points the computed empty array build error at the declaration', async () => {
|
|
const block = await buildPage('app/computed/[slug]/page.tsx')
|
|
if (isTurbopack) {
|
|
expect(block).toMatchInlineSnapshot(`
|
|
"When using Cache Components, all \`generateStaticParams\` functions must return at least one result. This is to ensure that we can perform build-time validation that there is no other dynamic accesses that would cause a runtime error.
|
|
|
|
Learn more: https://nextjs.org/docs/messages/empty-generate-static-params
|
|
at generateStaticParams (app/computed/[slug]/page.tsx:9:8)
|
|
7 | }
|
|
8 |
|
|
> 9 | export async function generateStaticParams() {
|
|
| ^
|
|
10 | // Empty at runtime but not statically analyzable, so it falls back to the
|
|
11 | // factory stack anchored at the declaration.
|
|
12 | const items: string[] = []
|
|
|
|
> "
|
|
`)
|
|
} else {
|
|
expect(block).toMatchInlineSnapshot(`
|
|
"When using Cache Components, all \`generateStaticParams\` functions must return at least one result. This is to ensure that we can perform build-time validation that there is no other dynamic accesses that would cause a runtime error.
|
|
|
|
Learn more: https://nextjs.org/docs/messages/empty-generate-static-params
|
|
at generateStaticParams (webpack:///app/computed/[slug]/page.tsx:9:8)
|
|
7 | }
|
|
8 |
|
|
> 9 | export async function generateStaticParams() {
|
|
| ^
|
|
10 | // Empty at runtime but not statically analyzable, so it falls back to the
|
|
11 | // factory stack anchored at the declaration.
|
|
12 | const items: string[] = []
|
|
|
|
> "
|
|
`)
|
|
}
|
|
})
|
|
}
|
|
})
|