mirror of
https://github.com/hanzoai/next.js.git
synced 2026-09-24 17:00:51 +00:00
Aurora ScharffandGitHub
18d2e2da5f
## Summary
The instant / blocking-prerender insight console errors printed a docs
URL under each fix option (two or three anchors per message). This
collapses them to a single `Learn more:` link at the end of each
message, while keeping the `[stream]`/`[cache]`/`[block]` fix-option
labels. It restores the single-link format these builders originally
shipped with.
**Before:**
```
Ways to fix this:
- [stream] Provide a placeholder with `<Suspense fallback={...}>` around the data access
https://nextjs.org/docs/messages/blocking-prerender-runtime#wrap-in-or-move-into-suspense
- [block] Set `export const instant = false` to allow a blocking route
https://nextjs.org/docs/messages/blocking-prerender-runtime#allow-blocking-route
```
**After:**
```
Ways to fix this:
- [stream] Provide a placeholder with `<Suspense fallback={...}>` around the data access
- [block] Set `export const instant = false` to allow a blocking route
Learn more: https://nextjs.org/docs/messages/blocking-prerender-runtime
```
Covers all 16 insight-kind errors, across `blocking-route-messages.ts`,
`sync-io-messages.ts`, `dynamic-rendering-utils.ts`, and
`instant-messages.ts`.
Because the dev overlay classified these errors by the `#`-anchored docs
URL, `getBlockingRouteErrorDetails` is updated to match the anchor-less
`Learn more:` URL. Console-message snapshots and the guidance-data
extraction test are updated to the new format. The dev-overlay fix-card
data (`instant-guidance-data.ts`) keeps its per-card links, since those
are the overlay UI rather than the console message.
## Verification
- `pnpm --filter=next types`
- Snapshots regenerated with `jest -u` for the affected suites
<!-- NEXT_JS_LLM -->
94 lines
3.0 KiB
TypeScript
94 lines
3.0 KiB
TypeScript
import { nextTestSetup } from 'e2e-utils'
|
|
import { expectBuildValidationSkipped } from 'e2e-utils/instant-validation'
|
|
import { waitForNoErrorToast } from '../../../lib/next-test-utils'
|
|
|
|
// This fixture intentionally omits `experimental.instantInsights` from
|
|
// next.config.ts. It pins the framework default for `validationLevel` —
|
|
// the framework should resolve the default to `'warning'`, which means
|
|
// implicit validation fires on bare pages in dev. If the framework default
|
|
// ever changes, this test should fail, alerting whoever changes it.
|
|
//
|
|
// For exhaustive coverage of explicit levels and per-segment overrides,
|
|
// see the sibling `instant-validation-level-{warning,manual-warning,error,
|
|
// manual-error}` fixtures.
|
|
describe('instant validation - default level', () => {
|
|
const { next, skipped, isNextDev, isNextStart, isTurbopack } = nextTestSetup({
|
|
files: __dirname,
|
|
skipStart: true,
|
|
skipDeployment: true,
|
|
env: {
|
|
NEXT_TEST_LOG_VALIDATION: '1',
|
|
},
|
|
})
|
|
if (skipped) return
|
|
|
|
if (isNextStart && !isTurbopack) {
|
|
it.skip('TODO: snapshot tests for webpack', () => {})
|
|
return
|
|
}
|
|
|
|
if (isNextStart) {
|
|
beforeAll(async () => {
|
|
await next.build({ args: ['--experimental-build-mode', 'compile'] })
|
|
})
|
|
afterEach(async () => {
|
|
await next.stop()
|
|
})
|
|
} else {
|
|
beforeAll(async () => {
|
|
await next.start()
|
|
})
|
|
}
|
|
|
|
const prerender = async (pathname: string) => {
|
|
return await next.build({
|
|
args: [
|
|
'--experimental-build-mode',
|
|
'generate',
|
|
'--debug-build-paths',
|
|
`app${pathname}/page.tsx`,
|
|
],
|
|
})
|
|
}
|
|
|
|
if (isNextDev) {
|
|
describe('dev', () => {
|
|
it('bare page: framework default matches `warning`, implicit validation fires', async () => {
|
|
const browser = await next.browser('/bare')
|
|
await expect(browser).toDisplayCollapsedRedbox(`
|
|
{
|
|
"code": "E1437",
|
|
"description": "Next.js encountered uncached data during a navigation.",
|
|
"environmentLabel": "Server",
|
|
"label": "Instant",
|
|
"source": "app/bare/page.tsx (10:19) @ Page
|
|
> 10 | await connection()
|
|
| ^",
|
|
"stack": [
|
|
"Page app/bare/page.tsx (10:19)",
|
|
],
|
|
}
|
|
`)
|
|
})
|
|
|
|
it('explicit-false page: per-segment opt-out still works under default', async () => {
|
|
const browser = await next.browser('/explicit-false')
|
|
await browser.elementByCss('main')
|
|
await waitForNoErrorToast(browser, { waitInMs: 500 })
|
|
})
|
|
})
|
|
} else {
|
|
describe('build', () => {
|
|
it('bare page: framework default is dev-only, build skips validation', async () => {
|
|
const result = await prerender('/bare')
|
|
expectBuildValidationSkipped(result)
|
|
})
|
|
|
|
it('explicit-false page: per-segment opt-out keeps build clean', async () => {
|
|
const result = await prerender('/explicit-false')
|
|
expectBuildValidationSkipped(result)
|
|
})
|
|
})
|
|
}
|
|
})
|