Files
Tim NeutkensandGitHub 8141dcf12e Convert test/integration to isolated tests (#93247)
### What?

Converts every test under `test/integration/` to an isolated test
running through `nextTestSetup` (under `test/e2e/`, `test/production/`,
`test/development/`, or `test/unit/`), then deletes `test/integration/`
along with the legacy CI orchestration that was specific to it.

- `test/integration/` removed entirely (~327 test suites)
- New isolated suites added across the existing folders:
  - `test/e2e/` — 175
  - `test/production/` — 130
  - `test/development/` — 43
  - `test/unit/` — 1
- `.github/workflows/build_and_test.yml` and `run-tests.js` no longer
have any `integration` branches
- `nextTestSetup` gained a `baseUrl` option on `next.browser()` so a
small number of tests that drive their own proxy/static-export server
can keep using `next.browser(...)` instead of importing `next-webdriver`
directly

### Why?

`test/integration/` predated `nextTestSetup` and ran tests directly
against the source checkout via custom helpers (`launchApp`,
`nextBuild`, `nextStart`, `runNextCommand`, `webdriver`, `fetchViaHTTP`,
…). Each suite hand-rolled its own dev/start/build orchestration,
fixture mutation, and process management.

The isolated test model used by the rest of the repo gives each suite an
isolated working directory containing a packed `next.tgz` install, a
uniform `next.start()` / `next.build()` / `next.fetch()` /
`next.browser()` API, and the same lifecycle for dev, start, and deploy
modes — so a single set of assertions covers all three. Deploy-mode
skips and per-feature gates are expressed declaratively
(`skipDeployment`, `disableAutoSkewProtection`, `if (skipped) return`)
instead of branching on `process.env`.

Removing `test/integration/` lets us:

- Delete the bespoke orchestration code in the CI workflow and
`run-tests.js`
- Run every converted suite consistently in dev, start, and deploy modes
(where applicable)
- Reproduce every test locally with the same `pnpm
test-{dev,start}-{turbo,webpack}` commands; no separate `integration`
path
- Open the door to running `test/production` against deployments in the
future (the converted suites already declare `skipDeployment` so they
can be flipped on)

### How?

Mechanical conversion per suite, with targeted clean-ups:

1. **Per-suite conversion.** Each
`test/integration/<name>/test/index.test.{js,ts}` was rewritten into a
single `<name>.test.ts` under the right folder based on what the
original exercised:
   - `launchApp` / dev-only assertions → `test/development/`
- `nextBuild` + `nextStart` / start-only assertions → `test/production/`
   - Both → `test/e2e/`
- The one pure jsdom render check (`link-without-router`) → `test/unit/`

2. **API mapping.** Custom helpers were replaced by `nextTestSetup`
equivalents: `launchApp` → `next.start()`, `nextBuild` → `next.build()`,
`runNextCommand` → `next.runCommand`, `fetchViaHTTP` → `next.fetch`,
`webdriver(...)` → `next.browser(...)`. Fixture mutations switched from
raw `fs.writeFile`/`fs.rename` to `next.patchFile` (with the 3-arg
`runWithTempContent` callback when the change has a defined scope) and
`next.deleteFile`.

3. **Deploy-mode handling.** Suites that can't run in deploy mode (use
`patchFile` / `next.build()` / depend on local CLI output) declare
`skipDeployment: true` and early-return on the `skipped` boolean. Suites
where Vercel's edge mutates URLs (`&dpl=`, immutable assets) declare
`disableAutoSkewProtection: true`.

4. **`next.browser({ baseUrl })`.** A handful of tests
(`prerender-export`, `cdn-cache-busting`, `preload-viewport`, both
`react-virtualized` suites) need to drive a separate server (a
static-export server or an `http-proxy` instance) rather than the
Next.js process. Instead of importing `next-webdriver` directly, those
tests now pass `{ baseUrl: <port|url> }` to `next.browser()`. For the
proxy cases, the proxy was moved into `server.js` inside the fixture and
`http-proxy` declared via the `dependencies` option of `nextTestSetup`,
so the test runs with a fully isolated dependency graph.

5. **CI clean-up.** With `test/integration` gone, the `test
integration*` jobs and `integration-tests-manifest`-related logic in
`.github/workflows/build_and_test.yml` were removed, and `run-tests.js`
no longer has the `integration` test-folder branch.

6. **Validation.** The PR was iterated against multiple full CI runs;
the remaining failures on the latest run are pre-existing flakes
(segment-cache 60s `act` timeouts in turbopack-prod) or transient
infrastructure issues unrelated to the conversion.
2026-05-11 13:55:47 +02:00

190 lines
5.3 KiB
TypeScript

import type * as Playwright from 'playwright'
import type { ChildProcess } from 'child_process'
import type { Server } from 'http'
import { createRouterAct } from 'router-act'
import { findPort } from 'next-test-utils'
import { isNextDeploy, isNextDev, nextTestSetup } from 'e2e-utils'
import { createFakeCDN } from './server.mjs'
describe('segment cache (CDN cache busting)', () => {
if (isNextDev || isNextDeploy) {
test('should not run during dev or deploy test runs', () => {})
return
}
const { next } = nextTestSetup({
files: __dirname,
skipStart: true,
})
// TODO(runtime-ppr): add tests for runtime prefetches
// To debug these tests locally, run:
// node start.mjs
//
// This will start the Next app and also a proxy server that simulates a CDN.
// Like certain real-world CDNs, our fake CDN doesn't respect the Vary header.
// It only uses the URL.
let nextChild: ChildProcess | undefined
let nextExit: Promise<any> | undefined
let cdnServer: Server
let port: number
beforeAll(async () => {
await next.build()
const nextPort = await findPort()
const proxyPort = (port = await findPort())
let resolveReady!: () => void
const readyPromise = new Promise<void>((r) => (resolveReady = r))
nextExit = next
.runCommand(['start', '-p', String(nextPort)], {
onStdout(msg) {
if (/Ready/.test(msg)) resolveReady()
},
instance(p) {
nextChild = p
},
})
.finally(() => resolveReady())
await readyPromise
cdnServer = await createFakeCDN(nextPort)
await new Promise<void>((resolve, reject) => {
cdnServer.on('error', reject)
cdnServer.listen(proxyPort, () => resolve())
})
})
afterAll(async () => {
if (cdnServer) {
await new Promise<void>((resolve) => cdnServer.close(() => resolve()))
}
nextChild?.kill()
await nextExit?.catch(() => {})
})
it(
"perform fully prefetched navigation with a CDN that doesn't respect " +
'the Vary header',
async () => {
let act
const browser = await next.browser('/', {
baseUrl: port,
beforePageLoad(p: Playwright.Page) {
act = createRouterAct(p)
},
})
await act(
async () => {
const linkToggle = await browser.elementByCss(
'[data-link-accordion="/target-page"]'
)
await linkToggle.click()
},
{
includes: 'Target page',
}
)
await act(async () => {
const link = await browser.elementByCss('a[href="/target-page"]')
await link.click()
const div = await browser.elementById('target-page')
expect(await div.text()).toBe('Target page')
}, 'no-requests')
}
)
it(
'prevent cache poisoning attacks by responding with a redirect to correct ' +
'cache busting query param if a custom header is sent during a prefetch ' +
'without a corresponding cache-busting search param',
async () => {
const browser = await next.browser('/', { baseUrl: port })
const { status, responseUrl, redirected } = await browser.eval(
async () => {
const res = await fetch('/target-page', {
headers: {
rsc: '1',
'next-router-prefetch': '1',
'next-router-segment-prefetch': '/_tree',
},
})
return {
status: res.status,
responseUrl: res.url,
redirected: res.redirected,
}
}
)
expect(status).toBe(200)
expect(responseUrl).toContain('_rsc=')
expect(redirected).toBe(true)
}
)
it('ignores invalid RSC header values when serving a document request', async () => {
const url = new URL(`http://localhost:${port}/target-page`)
url.searchParams.set('test', 'invalid-rsc-header')
const invalidHeaderRes = await fetch(url, {
headers: {
rsc: '0',
},
})
expect(invalidHeaderRes.status).toBe(200)
expect(invalidHeaderRes.headers.get('content-type')).toContain('text/html')
expect(await invalidHeaderRes.text()).toContain(
'<div id="target-page">Target page</div>'
)
const htmlRes = await fetch(url)
expect(htmlRes.status).toBe(200)
expect(htmlRes.headers.get('content-type')).toContain('text/html')
expect(await htmlRes.text()).toContain(
'<div id="target-page">Target page</div>'
)
})
it(
'perform fully prefetched navigation when a third-party proxy ' +
'performs a redirect',
async () => {
let act
const browser = await next.browser('/', {
baseUrl: port,
beforePageLoad(p: Playwright.Page) {
act = createRouterAct(p)
},
})
await act(
async () => {
const linkToggle = await browser.elementByCss(
'[data-link-accordion="/redirect-to-target-page"]'
)
await linkToggle.click()
},
{
includes: 'Target page',
}
)
await act(async () => {
const link = await browser.elementByCss(
'a[href="/redirect-to-target-page"]'
)
await link.click()
const div = await browser.elementById('target-page')
expect(await div.text()).toBe('Target page')
}, 'no-requests')
}
)
})