mirror of
https://github.com/hanzoai/next.js.git
synced 2026-10-30 14:46:38 +00:00
Hendrik LiebauandGitHub
b420536fe8
Overriding the `default` `cacheLife` profile with a short cache life (the built-in `expire` is `INFINITE_CACHE`) makes every `'use cache'` without an inline `cacheLife()` inherit that short life. In this configuration the nested-`'use cache'` error, in both its short-`expire` and zero-`revalidate` variants, fired in two cases where it should not have. The error exists to catch a nested cache silently shortening an outer cache that has no explicit `cacheLife`, degrading it to a dynamic hole the developer did not choose. But with a short default profile, a single non-nested `'use cache'` already resolves to a short life with nothing nested, so the error fired with no nesting at all: in production this killed the build, and in development it threw on the request. And even for a genuinely nested cache, the warning is pointless here, because the default profile already makes every cache a dynamic hole, so there is no silent degradation to surprise the developer. The throw condition keyed on a short life that was not set through an inline `cacheLife()`, and a value inherited from the `default` profile is non-explicit, so it matched. This change additionally requires that a dynamic nested cache actually propagated its short life upward (`dynamicNestedCacheError` is set) and that the `default` profile is itself prerenderable. Otherwise the short-lived entry is omitted as a dynamic hole instead, exactly as an inline short `cacheLife()` already was. Genuine nesting under a prerenderable default profile still errors. The nesting condition also subsumes the dev-only private-cache exclusion: a private cache's `revalidate: 0` is forced by us rather than by a nested cache and never carries a nested error, so the explicit `kind !== 'private'` check is no longer needed.
21 lines
689 B
TypeScript
21 lines
689 B
TypeScript
import { Suspense } from 'react'
|
|
|
|
// A single, non-nested `'use cache'` with no inline `cacheLife()`. It inherits
|
|
// the app's `default` profile, which is configured with `expire: 0`. That must
|
|
// be treated exactly like an inline `cacheLife({ expire: 0 })`: a dynamic hole
|
|
// excluded from the prerender, not a nested-cache misconfiguration. There is no
|
|
// outer cache here, so the "nested inside another use cache" error must not
|
|
// fire.
|
|
async function CachedValue() {
|
|
'use cache'
|
|
return <p id="value">{new Date().toISOString()}</p>
|
|
}
|
|
|
|
export default function Page() {
|
|
return (
|
|
<Suspense fallback={<p id="fallback">Loading...</p>}>
|
|
<CachedValue />
|
|
</Suspense>
|
|
)
|
|
}
|