mirror of
https://github.com/hanzoai/next.js.git
synced 2026-09-24 17:00:51 +00:00
### What? Migrate remaining direct `next-webdriver` test callers that have a `NextInstance` to `next.browser()`, and expose the shared `Playwright` browser type from `e2e-utils`. ### Why? `NextInstance.browser` should be the supported browser-opening interface for test fixtures, with `next-webdriver` kept as the private implementation detail. ### How? Updated affected development, e2e, and production tests to call `next.browser()` directly, passing `baseUrl` where tests intentionally target a manually spawned or proxied server. Shared helpers now receive browser callbacks from the test context, and browser types import `Playwright` from `e2e-utils` instead of deriving from `next.browser` or importing from private paths. <!-- NEXT_JS_LLM_PR -->
159 lines
5.5 KiB
TypeScript
159 lines
5.5 KiB
TypeScript
import { nextTestSetup } from 'e2e-utils'
|
|
import { check, renderViaHTTP, retry } from 'next-test-utils'
|
|
|
|
describe('basePath', () => {
|
|
const basePath = '/docs'
|
|
|
|
const { next, isNextDeploy } = nextTestSetup({
|
|
files: __dirname,
|
|
nextConfig: {
|
|
basePath,
|
|
onDemandEntries: {
|
|
// Make sure entries are not getting disposed.
|
|
maxInactiveAge: 1000 * 60 * 60,
|
|
},
|
|
},
|
|
})
|
|
|
|
describe('client-side navigation', () => {
|
|
it('should navigate to /404 correctly client-side', async () => {
|
|
const browser = await next.browser(`${basePath}/slug-1`)
|
|
await check(
|
|
() => browser.eval('document.documentElement.innerHTML'),
|
|
/slug-1/
|
|
)
|
|
|
|
await browser.eval('next.router.push("/404", "/slug-2")')
|
|
await check(
|
|
() => browser.eval('document.documentElement.innerHTML'),
|
|
/page could not be found/
|
|
)
|
|
expect(await browser.eval('location.pathname')).toBe(`${basePath}/slug-2`)
|
|
})
|
|
|
|
it('should navigate to /_error correctly client-side', async () => {
|
|
const browser = await next.browser(`${basePath}/slug-1`)
|
|
await check(
|
|
() => browser.eval('document.documentElement.innerHTML'),
|
|
/slug-1/
|
|
)
|
|
|
|
await browser.eval('next.router.push("/_error", "/slug-2")')
|
|
await check(
|
|
() => browser.eval('document.documentElement.innerHTML'),
|
|
/page could not be found/
|
|
)
|
|
expect(await browser.eval('location.pathname')).toBe(`${basePath}/slug-2`)
|
|
})
|
|
})
|
|
|
|
if (process.env.BROWSER_NAME === 'safari') {
|
|
// currently only testing the above tests in safari
|
|
// we can investigate testing more cases below if desired
|
|
return
|
|
}
|
|
|
|
it('should not update URL for a 404', async () => {
|
|
const browser = await next.browser('/missing')
|
|
|
|
// the custom 404 only shows inside of the basePath so this
|
|
// could be a platform default 404 page on deploy
|
|
if (!isNextDeploy) {
|
|
const pathname = await browser.eval(() => window.location.pathname)
|
|
expect(await browser.eval(() => (window as any).next.router.asPath)).toBe(
|
|
'/missing'
|
|
)
|
|
expect(pathname).toBe('/missing')
|
|
}
|
|
})
|
|
|
|
it('should handle 404 urls that start with basePath', async () => {
|
|
const browser = await next.browser(`${basePath}hello`)
|
|
|
|
// the custom 404 only shows inside of the basePath so this
|
|
// could be a platform default 404 page on deploy
|
|
if (!isNextDeploy) {
|
|
expect(await browser.eval(() => (window as any).next.router.asPath)).toBe(
|
|
`${basePath}hello`
|
|
)
|
|
expect(await browser.eval(() => window.location.pathname)).toBe(
|
|
`${basePath}hello`
|
|
)
|
|
}
|
|
})
|
|
|
|
// TODO: this test has been passing incorrectly since the below check
|
|
// wasn't being awaited. We need to investigate if this test is
|
|
// correct or not.
|
|
it.skip('should navigate back to a non-basepath 404 that starts with basepath', async () => {
|
|
const browser = await next.browser(`${basePath}hello`)
|
|
await browser.eval(() => ((window as any).navigationMarker = true))
|
|
await browser.eval(() => (window as any).next.router.push('/hello'))
|
|
await browser.waitForElementByCss('#pathname')
|
|
await browser.back()
|
|
await check(
|
|
() => browser.eval(() => window.location.pathname),
|
|
`${basePath}hello`
|
|
)
|
|
expect(await browser.eval(() => (window as any).next.router.asPath)).toBe(
|
|
`${basePath}hello`
|
|
)
|
|
expect(await browser.eval(() => (window as any).navigationMarker)).toBe(
|
|
true
|
|
)
|
|
})
|
|
|
|
describe('manually added basePath in application logic', () => {
|
|
it('should 404 when manually adding basePath with <Link>', async () => {
|
|
const browser = await next.browser(`${basePath}/invalid-manual-basepath`)
|
|
await browser.eval('window.beforeNav = "hi"')
|
|
await browser.elementByCss('#other-page-link').click()
|
|
|
|
await retry(async () => {
|
|
expect(await browser.eval('window.beforeNav')).not.toEqual('hi')
|
|
})
|
|
|
|
await check(
|
|
() => browser.eval('document.documentElement.innerHTML'),
|
|
/This page could not be found/
|
|
)
|
|
})
|
|
|
|
it('should 404 when manually adding basePath with router.push', async () => {
|
|
const browser = await next.browser(`${basePath}/hello`)
|
|
await browser.eval('window.beforeNav = "hi"')
|
|
await browser.eval(`window.next.router.push("${basePath}/other-page")`)
|
|
|
|
await retry(async () => {
|
|
expect(await browser.eval('window.beforeNav')).not.toEqual('hi')
|
|
})
|
|
|
|
const html = await browser.eval('document.documentElement.innerHTML')
|
|
expect(html).toContain('This page could not be found')
|
|
})
|
|
|
|
it('should 404 when manually adding basePath with router.replace', async () => {
|
|
const browser = await next.browser(`${basePath}/hello`)
|
|
await browser.eval('window.beforeNav = "hi"')
|
|
await browser.eval(`window.next.router.replace("${basePath}/other-page")`)
|
|
|
|
await retry(async () => {
|
|
expect(await browser.eval('window.beforeNav')).not.toEqual('hi')
|
|
})
|
|
|
|
const html = await browser.eval('document.documentElement.innerHTML')
|
|
expect(html).toContain('This page could not be found')
|
|
})
|
|
})
|
|
|
|
it('should show 404 for page not under the /docs prefix', async () => {
|
|
const text = await renderViaHTTP(next.url, '/hello')
|
|
expect(text).not.toContain('Hello World')
|
|
// the custom 404 only shows inside of the basePath so this
|
|
// could be a platform default 404 page on deploy
|
|
if (!isNextDeploy) {
|
|
expect(text).toContain('This page could not be found')
|
|
}
|
|
})
|
|
})
|