mirror of
https://github.com/hanzoai/next.js.git
synced 2026-09-24 17:00:51 +00:00
Tim NeutkensandGitHub
8141dcf12e
### What?
Converts every test under `test/integration/` to an isolated test
running through `nextTestSetup` (under `test/e2e/`, `test/production/`,
`test/development/`, or `test/unit/`), then deletes `test/integration/`
along with the legacy CI orchestration that was specific to it.
- `test/integration/` removed entirely (~327 test suites)
- New isolated suites added across the existing folders:
- `test/e2e/` — 175
- `test/production/` — 130
- `test/development/` — 43
- `test/unit/` — 1
- `.github/workflows/build_and_test.yml` and `run-tests.js` no longer
have any `integration` branches
- `nextTestSetup` gained a `baseUrl` option on `next.browser()` so a
small number of tests that drive their own proxy/static-export server
can keep using `next.browser(...)` instead of importing `next-webdriver`
directly
### Why?
`test/integration/` predated `nextTestSetup` and ran tests directly
against the source checkout via custom helpers (`launchApp`,
`nextBuild`, `nextStart`, `runNextCommand`, `webdriver`, `fetchViaHTTP`,
…). Each suite hand-rolled its own dev/start/build orchestration,
fixture mutation, and process management.
The isolated test model used by the rest of the repo gives each suite an
isolated working directory containing a packed `next.tgz` install, a
uniform `next.start()` / `next.build()` / `next.fetch()` /
`next.browser()` API, and the same lifecycle for dev, start, and deploy
modes — so a single set of assertions covers all three. Deploy-mode
skips and per-feature gates are expressed declaratively
(`skipDeployment`, `disableAutoSkewProtection`, `if (skipped) return`)
instead of branching on `process.env`.
Removing `test/integration/` lets us:
- Delete the bespoke orchestration code in the CI workflow and
`run-tests.js`
- Run every converted suite consistently in dev, start, and deploy modes
(where applicable)
- Reproduce every test locally with the same `pnpm
test-{dev,start}-{turbo,webpack}` commands; no separate `integration`
path
- Open the door to running `test/production` against deployments in the
future (the converted suites already declare `skipDeployment` so they
can be flipped on)
### How?
Mechanical conversion per suite, with targeted clean-ups:
1. **Per-suite conversion.** Each
`test/integration/<name>/test/index.test.{js,ts}` was rewritten into a
single `<name>.test.ts` under the right folder based on what the
original exercised:
- `launchApp` / dev-only assertions → `test/development/`
- `nextBuild` + `nextStart` / start-only assertions → `test/production/`
- Both → `test/e2e/`
- The one pure jsdom render check (`link-without-router`) → `test/unit/`
2. **API mapping.** Custom helpers were replaced by `nextTestSetup`
equivalents: `launchApp` → `next.start()`, `nextBuild` → `next.build()`,
`runNextCommand` → `next.runCommand`, `fetchViaHTTP` → `next.fetch`,
`webdriver(...)` → `next.browser(...)`. Fixture mutations switched from
raw `fs.writeFile`/`fs.rename` to `next.patchFile` (with the 3-arg
`runWithTempContent` callback when the change has a defined scope) and
`next.deleteFile`.
3. **Deploy-mode handling.** Suites that can't run in deploy mode (use
`patchFile` / `next.build()` / depend on local CLI output) declare
`skipDeployment: true` and early-return on the `skipped` boolean. Suites
where Vercel's edge mutates URLs (`&dpl=`, immutable assets) declare
`disableAutoSkewProtection: true`.
4. **`next.browser({ baseUrl })`.** A handful of tests
(`prerender-export`, `cdn-cache-busting`, `preload-viewport`, both
`react-virtualized` suites) need to drive a separate server (a
static-export server or an `http-proxy` instance) rather than the
Next.js process. Instead of importing `next-webdriver` directly, those
tests now pass `{ baseUrl: <port|url> }` to `next.browser()`. For the
proxy cases, the proxy was moved into `server.js` inside the fixture and
`http-proxy` declared via the `dependencies` option of `nextTestSetup`,
so the test runs with a fully isolated dependency graph.
5. **CI clean-up.** With `test/integration` gone, the `test
integration*` jobs and `integration-tests-manifest`-related logic in
`.github/workflows/build_and_test.yml` were removed, and `run-tests.js`
no longer has the `integration` test-folder branch.
6. **Validation.** The PR was iterated against multiple full CI runs;
the remaining failures on the latest run are pre-existing flakes
(segment-cache 60s `act` timeouts in turbopack-prod) or transient
infrastructure issues unrelated to the conversion.
237 lines
5.7 KiB
JavaScript
237 lines
5.7 KiB
JavaScript
import Link from 'next/link'
|
|
import { useRouter } from 'next/router'
|
|
|
|
if (typeof window !== 'undefined') {
|
|
window.caughtWarns = []
|
|
const origWarn = window.console.warn
|
|
window.console.warn = function (...args) {
|
|
window.caughtWarns.push(args)
|
|
origWarn(...args)
|
|
}
|
|
}
|
|
|
|
const Page = () => {
|
|
return (
|
|
<div>
|
|
<h3>My blog</h3>
|
|
<Link href="/[name]" as="/post-1" id="view-post-1">
|
|
View post 1
|
|
</Link>
|
|
<br />
|
|
<Link href="/[name]" as="/post-1#my-hash" id="view-post-1-hash-1">
|
|
View post 1 (hash)
|
|
</Link>
|
|
<br />
|
|
<Link href="/post-1#my-hash" id="view-post-1-hash-1-href-only">
|
|
View post 1 (hash only href)
|
|
</Link>
|
|
<br />
|
|
<Link
|
|
href="/post-1?hidden=value"
|
|
as="/post-1"
|
|
id="view-post-1-hidden-query"
|
|
>
|
|
View post 1 (href query)
|
|
</Link>
|
|
<br />
|
|
<Link
|
|
href={{
|
|
hash: 'my-hash',
|
|
pathname: '/[name]',
|
|
query: { name: 'post-1' },
|
|
}}
|
|
id="view-post-1-hash-1-interpolated"
|
|
>
|
|
View post 1 (hash interpolated)
|
|
</Link>
|
|
<br />
|
|
<Link href="/post-1" id="view-post-1-no-as">
|
|
View post 1 (no as)
|
|
</Link>
|
|
<br />
|
|
<Link
|
|
href={{
|
|
pathname: '/[name]',
|
|
query: { name: 'post-1' },
|
|
}}
|
|
id="view-post-1-interpolated"
|
|
>
|
|
View post 1 (interpolated)
|
|
</Link>
|
|
<br />
|
|
<Link
|
|
href={{
|
|
pathname: '/[name]',
|
|
query: { another: 'value' },
|
|
}}
|
|
id="view-post-1-interpolated-incorrectly"
|
|
>
|
|
View post 1 (interpolated incorrectly)
|
|
</Link>
|
|
<br />
|
|
<Link
|
|
href={{
|
|
pathname: '/[name]',
|
|
query: { name: 'post-1', another: 'value' },
|
|
}}
|
|
id="view-post-1-interpolated-more-query"
|
|
>
|
|
View post 1 (interpolated additional query)
|
|
</Link>
|
|
<br />
|
|
<Link
|
|
href="/[name]/comments"
|
|
as="/post-1/comments"
|
|
id="view-post-1-comments"
|
|
>
|
|
View post 1 comments
|
|
</Link>
|
|
<br />
|
|
<Link
|
|
href="/[name]/[comment]"
|
|
as="/post-1/comment-1"
|
|
id="view-post-1-comment-1"
|
|
>
|
|
View comment 1 on post 1
|
|
</Link>
|
|
<br />
|
|
<Link href="/post-1/comment-1" id="view-post-1-comment-1-no-as">
|
|
View comment 1 on post 1 (no as)
|
|
</Link>
|
|
<br />
|
|
<Link
|
|
href={{
|
|
pathname: '/[name]/[comment]',
|
|
query: { name: 'post-1', comment: 'comment-1' },
|
|
}}
|
|
id="view-post-1-comment-1-interpolated"
|
|
>
|
|
View comment 1 on post 1 (interpolated)
|
|
</Link>
|
|
<br />
|
|
<Link href="/added-later/first" id="added-later-link">
|
|
/added-later/first
|
|
</Link>
|
|
<br />
|
|
<Link
|
|
href="/blog/[post]/comment/[id]"
|
|
as="/blog/321/comment/123"
|
|
id="view-nested-dynamic-cmnt"
|
|
>
|
|
View comment 123 on blog post 321
|
|
</Link>
|
|
<br />
|
|
<Link
|
|
href="/[name]?fromHome=true"
|
|
as="/post-1?fromHome=true"
|
|
id="view-post-1-with-query"
|
|
>
|
|
View post 1 with query
|
|
</Link>
|
|
<br />
|
|
<Link
|
|
href="/on-mount/[post]"
|
|
as="/on-mount/test-w-hash#item-400"
|
|
id="view-dynamic-with-hash"
|
|
>
|
|
View test with hash
|
|
</Link>
|
|
<br />
|
|
<Link
|
|
href="/p1/p2/all-ssr/[...rest]"
|
|
as="/p1/p2/all-ssr/hello"
|
|
id="catch-all-single"
|
|
>
|
|
Catch-all route (single)
|
|
</Link>
|
|
<br />
|
|
<Link
|
|
href="/p1/p2/all-ssr/[...rest]"
|
|
as="/p1/p2/all-ssr/hello1/hello2"
|
|
id="catch-all-multi"
|
|
>
|
|
Catch-all route (multi)
|
|
</Link>
|
|
<br />
|
|
<Link
|
|
href="/p1/p2/all-ssr/[...rest]"
|
|
as="/p1/p2/all-ssr/hello1%2F/he%2Fllo2"
|
|
id="catch-all-enc"
|
|
>
|
|
Catch-all route (encoded)
|
|
</Link>
|
|
<br />
|
|
<Link
|
|
href="/p1/p2/all-ssr/[...rest]"
|
|
as="/p1/p2/all-ssr/:42"
|
|
id="catch-all-colonnumber"
|
|
>
|
|
Catch-all route :42
|
|
</Link>
|
|
<br />
|
|
<Link
|
|
href="/p1/p2/all-ssg/[...rest]"
|
|
as="/p1/p2/all-ssg/hello"
|
|
id="ssg-catch-all-single"
|
|
>
|
|
Catch-all route (single)
|
|
</Link>
|
|
<br />
|
|
<Link
|
|
href={{
|
|
pathname: '/p1/p2/all-ssg/[...rest]',
|
|
query: { rest: ['hello'] },
|
|
}}
|
|
id="ssg-catch-all-single-interpolated"
|
|
>
|
|
Catch-all route (single interpolated)
|
|
</Link>
|
|
<br />
|
|
<Link
|
|
href="/p1/p2/all-ssg/[...rest]"
|
|
as="/p1/p2/all-ssg/hello1/hello2"
|
|
id="ssg-catch-all-multi"
|
|
>
|
|
Catch-all route (multi)
|
|
</Link>
|
|
<br />
|
|
<Link href="/p1/p2/all-ssg/hello1/hello2" id="ssg-catch-all-multi-no-as">
|
|
Catch-all route (multi)
|
|
</Link>
|
|
<br />
|
|
<Link
|
|
href={{
|
|
pathname: '/p1/p2/all-ssg/[...rest]',
|
|
query: { rest: ['hello1', 'hello2'] },
|
|
}}
|
|
id="ssg-catch-all-multi-interpolated"
|
|
>
|
|
Catch-all route (multi interpolated)
|
|
</Link>
|
|
<br />
|
|
<Link
|
|
href="/p1/p2/nested-all-ssg/[...rest]"
|
|
as="/p1/p2/nested-all-ssg/hello"
|
|
id="nested-ssg-catch-all-single"
|
|
>
|
|
Nested Catch-all route (single)
|
|
</Link>
|
|
<br />
|
|
<Link
|
|
href="/p1/p2/nested-all-ssg/[...rest]"
|
|
as="/p1/p2/nested-all-ssg/hello1/hello2"
|
|
id="nested-ssg-catch-all-multi"
|
|
>
|
|
Nested Catch-all route (multi)
|
|
</Link>
|
|
<br />
|
|
<Link href="/d/dynamic-1" id="dynamic-route-no-as">
|
|
Dynamic route no as
|
|
</Link>
|
|
<p id="query">{JSON.stringify(Object.keys(useRouter().query))}</p>
|
|
</div>
|
|
)
|
|
}
|
|
|
|
export default Page
|