mirror of
https://github.com/hanzoai/next.js.git
synced 2026-09-24 17:00:51 +00:00
### What?
Converts every test under `test/integration/` to an isolated test
running through `nextTestSetup` (under `test/e2e/`, `test/production/`,
`test/development/`, or `test/unit/`), then deletes `test/integration/`
along with the legacy CI orchestration that was specific to it.
- `test/integration/` removed entirely (~327 test suites)
- New isolated suites added across the existing folders:
- `test/e2e/` — 175
- `test/production/` — 130
- `test/development/` — 43
- `test/unit/` — 1
- `.github/workflows/build_and_test.yml` and `run-tests.js` no longer
have any `integration` branches
- `nextTestSetup` gained a `baseUrl` option on `next.browser()` so a
small number of tests that drive their own proxy/static-export server
can keep using `next.browser(...)` instead of importing `next-webdriver`
directly
### Why?
`test/integration/` predated `nextTestSetup` and ran tests directly
against the source checkout via custom helpers (`launchApp`,
`nextBuild`, `nextStart`, `runNextCommand`, `webdriver`, `fetchViaHTTP`,
…). Each suite hand-rolled its own dev/start/build orchestration,
fixture mutation, and process management.
The isolated test model used by the rest of the repo gives each suite an
isolated working directory containing a packed `next.tgz` install, a
uniform `next.start()` / `next.build()` / `next.fetch()` /
`next.browser()` API, and the same lifecycle for dev, start, and deploy
modes — so a single set of assertions covers all three. Deploy-mode
skips and per-feature gates are expressed declaratively
(`skipDeployment`, `disableAutoSkewProtection`, `if (skipped) return`)
instead of branching on `process.env`.
Removing `test/integration/` lets us:
- Delete the bespoke orchestration code in the CI workflow and
`run-tests.js`
- Run every converted suite consistently in dev, start, and deploy modes
(where applicable)
- Reproduce every test locally with the same `pnpm
test-{dev,start}-{turbo,webpack}` commands; no separate `integration`
path
- Open the door to running `test/production` against deployments in the
future (the converted suites already declare `skipDeployment` so they
can be flipped on)
### How?
Mechanical conversion per suite, with targeted clean-ups:
1. **Per-suite conversion.** Each
`test/integration/<name>/test/index.test.{js,ts}` was rewritten into a
single `<name>.test.ts` under the right folder based on what the
original exercised:
- `launchApp` / dev-only assertions → `test/development/`
- `nextBuild` + `nextStart` / start-only assertions → `test/production/`
- Both → `test/e2e/`
- The one pure jsdom render check (`link-without-router`) → `test/unit/`
2. **API mapping.** Custom helpers were replaced by `nextTestSetup`
equivalents: `launchApp` → `next.start()`, `nextBuild` → `next.build()`,
`runNextCommand` → `next.runCommand`, `fetchViaHTTP` → `next.fetch`,
`webdriver(...)` → `next.browser(...)`. Fixture mutations switched from
raw `fs.writeFile`/`fs.rename` to `next.patchFile` (with the 3-arg
`runWithTempContent` callback when the change has a defined scope) and
`next.deleteFile`.
3. **Deploy-mode handling.** Suites that can't run in deploy mode (use
`patchFile` / `next.build()` / depend on local CLI output) declare
`skipDeployment: true` and early-return on the `skipped` boolean. Suites
where Vercel's edge mutates URLs (`&dpl=`, immutable assets) declare
`disableAutoSkewProtection: true`.
4. **`next.browser({ baseUrl })`.** A handful of tests
(`prerender-export`, `cdn-cache-busting`, `preload-viewport`, both
`react-virtualized` suites) need to drive a separate server (a
static-export server or an `http-proxy` instance) rather than the
Next.js process. Instead of importing `next-webdriver` directly, those
tests now pass `{ baseUrl: <port|url> }` to `next.browser()`. For the
proxy cases, the proxy was moved into `server.js` inside the fixture and
`http-proxy` declared via the `dependencies` option of `nextTestSetup`,
so the test runs with a fully isolated dependency graph.
5. **CI clean-up.** With `test/integration` gone, the `test
integration*` jobs and `integration-tests-manifest`-related logic in
`.github/workflows/build_and_test.yml` were removed, and `run-tests.js`
no longer has the `integration` test-folder branch.
6. **Validation.** The PR was iterated against multiple full CI runs;
the remaining failures on the latest run are pre-existing flakes
(segment-cache 60s `act` timeouts in turbopack-prod) or transient
infrastructure issues unrelated to the conversion.
106 lines
2.9 KiB
TypeScript
106 lines
2.9 KiB
TypeScript
import { nextTestSetup } from 'e2e-utils'
|
|
import { shouldUseTurbopack } from 'next-test-utils'
|
|
import path from 'node:path'
|
|
import type { ChildProcess } from 'node:child_process'
|
|
import { existsSync, readFileSync } from 'node:fs'
|
|
|
|
describe('next experimental-analyze', () => {
|
|
if (!shouldUseTurbopack()) {
|
|
// Test suites require at least one test
|
|
it('skips in non-Turbopack tests', () => {})
|
|
return
|
|
}
|
|
|
|
const { next, skipped } = nextTestSetup({
|
|
files: __dirname,
|
|
skipStart: true,
|
|
skipDeployment: true,
|
|
})
|
|
|
|
if (skipped) {
|
|
// Test suites require at least one test
|
|
it('is skipped', () => {})
|
|
return
|
|
}
|
|
|
|
it('runs successfully without errors', async () => {
|
|
let serveProcess: ChildProcess | undefined
|
|
let stdoutBuffer = ''
|
|
let resolveUrl!: (url: string) => void
|
|
let rejectUrl!: (err: Error) => void
|
|
const urlPromise = new Promise<string>((resolve, reject) => {
|
|
resolveUrl = resolve
|
|
rejectUrl = reject
|
|
})
|
|
|
|
const timeout = setTimeout(() => {
|
|
rejectUrl(new Error('Server did not start within timeout'))
|
|
}, 30000)
|
|
|
|
const exit = next
|
|
.runCommand(['experimental-analyze', '--port', '0'], {
|
|
onStdout(msg) {
|
|
stdoutBuffer += msg
|
|
const urlMatch = stdoutBuffer.match(/http:\/\/[^\s]+/)
|
|
if (urlMatch) {
|
|
resolveUrl(urlMatch[0])
|
|
}
|
|
},
|
|
instance(p) {
|
|
serveProcess = p
|
|
},
|
|
})
|
|
.finally(() => {
|
|
clearTimeout(timeout)
|
|
})
|
|
|
|
try {
|
|
const url = await urlPromise
|
|
const response = await fetch(url)
|
|
expect(response.status).toBe(200)
|
|
expect(await response.text()).toContain(
|
|
'<title>Next.js Bundle Analyzer</title>'
|
|
)
|
|
} finally {
|
|
serveProcess?.kill()
|
|
await exit.catch(() => {})
|
|
}
|
|
})
|
|
;['-o', '--output'].forEach((flag) => {
|
|
describe(`with ${flag} flag`, () => {
|
|
it('writes output to .next/diagnostics/analyze path', async () => {
|
|
const defaultOutputPath = path.join(
|
|
next.testDir,
|
|
'.next/diagnostics/analyze'
|
|
)
|
|
|
|
const { exitCode, stderr, stdout } = await next.runCommand([
|
|
'experimental-analyze',
|
|
flag,
|
|
])
|
|
|
|
expect(exitCode).toBe(0)
|
|
expect(stderr).not.toContain('Error')
|
|
expect(stdout).toContain('.next/diagnostics/analyze')
|
|
|
|
expect(existsSync(defaultOutputPath)).toBe(true)
|
|
for (const file of [
|
|
'index.html',
|
|
'data/routes.json',
|
|
'data/modules.data',
|
|
'data/analyze.data',
|
|
]) {
|
|
expect(existsSync(path.join(defaultOutputPath, file))).toBe(true)
|
|
}
|
|
|
|
const routesJson = readFileSync(
|
|
path.join(defaultOutputPath, 'data', 'routes.json'),
|
|
'utf-8'
|
|
)
|
|
const routes = JSON.parse(routesJson)
|
|
expect(routes).toEqual(['/', '/_not-found'])
|
|
})
|
|
})
|
|
})
|
|
})
|