mirror of
https://github.com/hanzoai/next.js.git
synced 2026-09-24 17:00:51 +00:00
### What?
Converts every test under `test/integration/` to an isolated test
running through `nextTestSetup` (under `test/e2e/`, `test/production/`,
`test/development/`, or `test/unit/`), then deletes `test/integration/`
along with the legacy CI orchestration that was specific to it.
- `test/integration/` removed entirely (~327 test suites)
- New isolated suites added across the existing folders:
- `test/e2e/` — 175
- `test/production/` — 130
- `test/development/` — 43
- `test/unit/` — 1
- `.github/workflows/build_and_test.yml` and `run-tests.js` no longer
have any `integration` branches
- `nextTestSetup` gained a `baseUrl` option on `next.browser()` so a
small number of tests that drive their own proxy/static-export server
can keep using `next.browser(...)` instead of importing `next-webdriver`
directly
### Why?
`test/integration/` predated `nextTestSetup` and ran tests directly
against the source checkout via custom helpers (`launchApp`,
`nextBuild`, `nextStart`, `runNextCommand`, `webdriver`, `fetchViaHTTP`,
…). Each suite hand-rolled its own dev/start/build orchestration,
fixture mutation, and process management.
The isolated test model used by the rest of the repo gives each suite an
isolated working directory containing a packed `next.tgz` install, a
uniform `next.start()` / `next.build()` / `next.fetch()` /
`next.browser()` API, and the same lifecycle for dev, start, and deploy
modes — so a single set of assertions covers all three. Deploy-mode
skips and per-feature gates are expressed declaratively
(`skipDeployment`, `disableAutoSkewProtection`, `if (skipped) return`)
instead of branching on `process.env`.
Removing `test/integration/` lets us:
- Delete the bespoke orchestration code in the CI workflow and
`run-tests.js`
- Run every converted suite consistently in dev, start, and deploy modes
(where applicable)
- Reproduce every test locally with the same `pnpm
test-{dev,start}-{turbo,webpack}` commands; no separate `integration`
path
- Open the door to running `test/production` against deployments in the
future (the converted suites already declare `skipDeployment` so they
can be flipped on)
### How?
Mechanical conversion per suite, with targeted clean-ups:
1. **Per-suite conversion.** Each
`test/integration/<name>/test/index.test.{js,ts}` was rewritten into a
single `<name>.test.ts` under the right folder based on what the
original exercised:
- `launchApp` / dev-only assertions → `test/development/`
- `nextBuild` + `nextStart` / start-only assertions → `test/production/`
- Both → `test/e2e/`
- The one pure jsdom render check (`link-without-router`) → `test/unit/`
2. **API mapping.** Custom helpers were replaced by `nextTestSetup`
equivalents: `launchApp` → `next.start()`, `nextBuild` → `next.build()`,
`runNextCommand` → `next.runCommand`, `fetchViaHTTP` → `next.fetch`,
`webdriver(...)` → `next.browser(...)`. Fixture mutations switched from
raw `fs.writeFile`/`fs.rename` to `next.patchFile` (with the 3-arg
`runWithTempContent` callback when the change has a defined scope) and
`next.deleteFile`.
3. **Deploy-mode handling.** Suites that can't run in deploy mode (use
`patchFile` / `next.build()` / depend on local CLI output) declare
`skipDeployment: true` and early-return on the `skipped` boolean. Suites
where Vercel's edge mutates URLs (`&dpl=`, immutable assets) declare
`disableAutoSkewProtection: true`.
4. **`next.browser({ baseUrl })`.** A handful of tests
(`prerender-export`, `cdn-cache-busting`, `preload-viewport`, both
`react-virtualized` suites) need to drive a separate server (a
static-export server or an `http-proxy` instance) rather than the
Next.js process. Instead of importing `next-webdriver` directly, those
tests now pass `{ baseUrl: <port|url> }` to `next.browser()`. For the
proxy cases, the proxy was moved into `server.js` inside the fixture and
`http-proxy` declared via the `dependencies` option of `nextTestSetup`,
so the test runs with a fully isolated dependency graph.
5. **CI clean-up.** With `test/integration` gone, the `test
integration*` jobs and `integration-tests-manifest`-related logic in
`.github/workflows/build_and_test.yml` were removed, and `run-tests.js`
no longer has the `integration` test-folder branch.
6. **Validation.** The PR was iterated against multiple full CI runs;
the remaining failures on the latest run are pre-existing flakes
(segment-cache 60s `act` timeouts in turbopack-prod) or transient
infrastructure issues unrelated to the conversion.
152 lines
4.5 KiB
TypeScript
152 lines
4.5 KiB
TypeScript
import { nextTestSetup, isNextDev } from 'e2e-utils'
|
|
import {
|
|
waitForRedbox,
|
|
waitForNoRedbox,
|
|
getRedboxHeader,
|
|
getDeploymentId,
|
|
retry,
|
|
} from 'next-test-utils'
|
|
|
|
describe('Image Component basePath Tests', () => {
|
|
const { next, skipped } = nextTestSetup({
|
|
files: __dirname,
|
|
disableAutoSkewProtection: true,
|
|
// Image URL assertions construct expected URLs via
|
|
// `getDeploymentId(next.testDir, ...)`, which reads the local
|
|
// `.next/required-server-files.json`. In deploy mode that file lives on
|
|
// Vercel's infrastructure (not on disk locally), so the constructed
|
|
// expected URL omits the `&dpl=...` query that Vercel injects at
|
|
// runtime. The assertions are about local-build URL shape, not deploy
|
|
// CDN URLs, so skip in deploy.
|
|
skipDeployment: true,
|
|
})
|
|
if (skipped) return
|
|
|
|
let dpl: string
|
|
beforeAll(() => {
|
|
dpl = getDeploymentId(next.testDir, isNextDev).getDeploymentIdQuery(true)
|
|
})
|
|
|
|
async function getImageUrls(browser) {
|
|
return await Promise.all(
|
|
(await browser.elementsByCss('img')).map(async (link) =>
|
|
new URL(await link.getAttribute('src'), next.url).toString()
|
|
)
|
|
)
|
|
}
|
|
|
|
async function getComputed(browser, id, prop) {
|
|
const val = await browser.eval(`document.getElementById('${id}').${prop}`)
|
|
if (typeof val === 'number') {
|
|
return val
|
|
}
|
|
if (typeof val === 'string') {
|
|
const v = parseInt(val, 10)
|
|
if (isNaN(v)) {
|
|
return val
|
|
}
|
|
return v
|
|
}
|
|
return null
|
|
}
|
|
|
|
function getRatio(width, height) {
|
|
return height / width
|
|
}
|
|
|
|
it('should load the images', async () => {
|
|
const browser = await next.browser('/docs')
|
|
|
|
await retry(async () => {
|
|
const result = await browser.eval(
|
|
`document.getElementById('basic-image').naturalWidth`
|
|
)
|
|
expect(result).not.toBe(0)
|
|
})
|
|
|
|
expect(await getImageUrls(browser)).toContain(
|
|
`${next.url}/docs/_next/image?url=%2Fdocs%2Ftest.jpg&w=828&q=75${dpl}`
|
|
)
|
|
})
|
|
|
|
it('should update the image on src change', async () => {
|
|
const browser = await next.browser('/docs/update')
|
|
|
|
await retry(async () => {
|
|
const src = await browser.eval(
|
|
`document.getElementById("update-image").src`
|
|
)
|
|
expect(src).toMatch(/test\.jpg/)
|
|
})
|
|
|
|
await browser.eval(`document.getElementById("toggle").click()`)
|
|
|
|
await retry(async () => {
|
|
const src = await browser.eval(
|
|
`document.getElementById("update-image").src`
|
|
)
|
|
expect(src).toMatch(/test\.png/)
|
|
})
|
|
})
|
|
|
|
it('should work when using flexbox', async () => {
|
|
const browser = await next.browser('/docs/flex')
|
|
await retry(async () => {
|
|
const result = await browser.eval(
|
|
`document.getElementById('basic-image').width`
|
|
)
|
|
expect(result).not.toBe(0)
|
|
})
|
|
})
|
|
|
|
if (isNextDev) {
|
|
it('should show missing src error', async () => {
|
|
const browser = await next.browser('/docs/missing-src')
|
|
|
|
await waitForNoRedbox(browser)
|
|
|
|
await retry(async () => {
|
|
const logs = (await browser.log()).map((log) => log.message).join('\n')
|
|
expect(logs).toMatch(/Image is missing required "src" property/gm)
|
|
})
|
|
})
|
|
|
|
it('should show invalid src error', async () => {
|
|
const browser = await next.browser('/docs/invalid-src')
|
|
|
|
await waitForRedbox(browser)
|
|
expect(await getRedboxHeader(browser)).toContain(
|
|
'Invalid src prop (https://google.com/test.png) on `next/image`, hostname "google.com" is not configured under images in your `next.config.js`'
|
|
)
|
|
})
|
|
|
|
it('should show invalid src error when protocol-relative', async () => {
|
|
const browser = await next.browser('/docs/invalid-src-proto-relative')
|
|
|
|
await waitForRedbox(browser)
|
|
expect(await getRedboxHeader(browser)).toContain(
|
|
'Failed to parse src "//assets.example.com/img.jpg" on `next/image`, protocol-relative URL (//) must be changed to an absolute URL (http:// or https://)'
|
|
)
|
|
})
|
|
}
|
|
|
|
it('should correctly ignore prose styles', async () => {
|
|
const browser = await next.browser('/docs/prose')
|
|
|
|
const id = 'prose-image'
|
|
|
|
await retry(async () => {
|
|
const result = await browser.eval(
|
|
`document.getElementById(${JSON.stringify(id)}).naturalWidth`
|
|
)
|
|
expect(result).toBeGreaterThan(0)
|
|
})
|
|
|
|
await new Promise((resolve) => setTimeout(resolve, 1000))
|
|
|
|
const computedWidth = await getComputed(browser, id, 'width')
|
|
const computedHeight = await getComputed(browser, id, 'height')
|
|
expect(getRatio(computedWidth, computedHeight)).toBeCloseTo(1, 1)
|
|
})
|
|
})
|