mirror of
https://github.com/hanzoai/next.js.git
synced 2026-09-24 17:00:51 +00:00
## Summary - upgrade `@rspack/core` to `2.0.0-rc.0` - sync the in-tree next rspack Rust binding/toolchain with newer rspack releases - align Next server runtime selection so `NEXT_RSPACK` uses the turbo-like app runtime path - include missing compiled `@next/react-refresh-utils` output in `ncc-compiled` ## What is done - `@next/rspack` Rust binding builds locally - `packages/next` builds locally - rspack-related tests are running and have been reduced to deeper runtime compatibility failures ## Rspack test investigation Latest checked CI run: `build-and-test` run `27129243230` at head `484e7bf1b30655a9f94d0855b9e00774b4b38cd0`. Confirmed Rspack / webpack parity gaps: - `test/e2e/edge-runtime-configurable-guards/edge-runtime-configurable-guards.test.ts`: Rspack does not expose the webpack parser hooks used by `MiddlewarePlugin`. The current Rspack path falls back to SWC analysis in `finishModules`, which can report diagnostics but cannot apply the parser-time transforms that wrap `eval` / `new Function`, track `InnerGraph` usage for used vs unused dynamic code, or apply `unstable_allowDynamic` with webpack parity. Dev therefore misses the expected dynamic-code runtime warnings and also reports false `process.cwd` Edge warnings from Next internals; prod fails allowed/unused dynamic-code cases. - `test/development/middleware-overrides-node.js-api/middleware-overrides-node.js-api.test.ts`: same parser-hook limitation. Webpack can observe that `process.cwd` is overwritten before use, while the Rspack SWC fallback statically flags `process.cwd` as an unsupported Edge Node API. - `test/production/css-features/css-compilation.test.ts`: the CSS is minified and prefixed as expected, but the Rspack lightningcss path currently does not expose/control source map generation the way this test expects, so emitted CSS has no `sourceMappingURL` comment or `.map` file to assert. - `test/e2e/app-dir/server-source-maps/server-source-maps.test.ts`: invalid source maps are not handled with the same graceful diagnostic as webpack/Node source-map handling. Rspack logs the raw `webpack-internal` frame for the damaged map case instead of surfacing the expected `Invalid source map. Only conformant source maps...` message with the cause. - `test/e2e/app-dir/parallel-routes-revalidation/parallel-routes-revalidation.test.ts`: raw CI output observed a dev-mode timeout waiting for `networkidle` after refresh/back/forward lazy fetching. This was not the final structured failure in the latest run, but it remains a Rspack dev parity follow-up around router cache lazy fetches and network settling. - `test/e2e/middleware-src/middleware-src.test.ts`: after the test adds root middleware files, Rspack dev still lets `src/middleware` participate; the expected behavior is that only the root middleware runs. - `test/e2e/env-config/env-config.test.ts`: changing `.env` logs `Reload env:` but the client keeps the previous `NEXT_PUBLIC_` value, pointing at an Rspack dev env invalidation/HMR gap. - `test/e2e/app-dir/use-cache-without-experimental-flag/use-cache-without-experimental-flag.test.ts`: after enabling the `useCache` flag, the dev server does not finish restarting, pointing at build-error recovery/restart parity. - `test/development/app-dir/server-navigation-error/server-navigation-error.test.ts`: middleware navigation-error cases hit `ERR_CONNECTION_REFUSED`, consistent with the Rspack dev server exiting or restarting unexpectedly during those error flows. - `test/e2e/opentelemetry/instrumentation/opentelemetry.test.ts`: the custom-server dev process exits before the SDK handle is initialized, then cleanup fails on `shutdown`; this needs follow-up in Rspack dev/custom-server startup. - `test/e2e/next-image-new/app-dir/app-dir.test.ts`: after toggling image source, `onLoadingComplete` still reports the previous image dimensions/source, pointing at an Rspack dev image/HMR or asset invalidation parity issue. - `test/e2e/node-cli-args/node-cli-args.test.ts`: on Node `20.19.x`, `node --experimental-network-inspection` resolves instead of rejecting. This looks like a Node-version behavior change rather than an Rspack compiler issue. Not attributed to this Rspack upgrade: - `test/e2e/app-dir/instant-navigation-testing-api/instant-navigation-testing-api.test.ts` was marked by `scripts/pr-status.js` as a known flaky test across branches. - `test/production/app-dir/build-output-prerender/build-output-prerender.test.ts` ran in the webpack prod job and only differs by prerender error ordering in the inline snapshot. <!-- NEXT_JS_LLM_PR --> --------- Co-authored-by: Benjamin Woodruff <[email protected]>
327 lines
9.7 KiB
TypeScript
327 lines
9.7 KiB
TypeScript
import type { ChildProcess } from 'child_process'
|
|
import path from 'path'
|
|
import fs from 'fs-extra'
|
|
import { nextTestSetup } from 'e2e-utils'
|
|
import { findPort, killApp, renderViaHTTP, retry } from 'next-test-utils'
|
|
|
|
describe('page features telemetry', () => {
|
|
const { next, isTurbopack, isRspack, isNextStart, skipped } = nextTestSetup({
|
|
files: __dirname,
|
|
skipStart: true,
|
|
// Calls `next.build()` directly which is not supported on `NextDeployInstance`.
|
|
skipDeployment: true,
|
|
})
|
|
if (skipped) return
|
|
|
|
async function launchDevServer(
|
|
port: number,
|
|
opts: {
|
|
env?: Record<string, string>
|
|
onStderr?: (msg: string) => void
|
|
onStdout?: (msg: string) => void
|
|
} = {}
|
|
): Promise<{ child: ChildProcess; exit: Promise<any> }> {
|
|
let child!: ChildProcess
|
|
let ready = false
|
|
let resolveReady!: () => void
|
|
const readyPromise = new Promise<void>((r) => {
|
|
resolveReady = () => {
|
|
if (!ready) {
|
|
ready = true
|
|
r()
|
|
}
|
|
}
|
|
})
|
|
|
|
const readyPattern = /- Local:|✓ Ready/i
|
|
const exit = next
|
|
.runCommand(['dev', next.testDir, '-p', String(port)], {
|
|
env: opts.env,
|
|
onStdout(msg) {
|
|
opts.onStdout?.(msg)
|
|
if (readyPattern.test(msg)) resolveReady()
|
|
},
|
|
onStderr(msg) {
|
|
opts.onStderr?.(msg)
|
|
if (readyPattern.test(msg)) resolveReady()
|
|
},
|
|
instance: (p) => {
|
|
child = p
|
|
},
|
|
})
|
|
.finally(() => {
|
|
resolveReady()
|
|
})
|
|
|
|
await readyPromise
|
|
return { child, exit }
|
|
}
|
|
|
|
if (isTurbopack) {
|
|
it('detects --turbo correctly for `next dev`', async () => {
|
|
const port = await findPort()
|
|
let stderr = ''
|
|
|
|
const { child, exit } = await launchDevServer(port, {
|
|
onStderr(msg) {
|
|
stderr += msg
|
|
},
|
|
env: {
|
|
NEXT_TELEMETRY_DEBUG: '1',
|
|
},
|
|
})
|
|
await retry(async () => {
|
|
expect(stderr).toMatch(/NEXT_CLI_SESSION_STARTED/)
|
|
})
|
|
await renderViaHTTP(port, '/hello')
|
|
|
|
if (child) {
|
|
await killApp(child)
|
|
}
|
|
await exit.catch(() => {})
|
|
|
|
try {
|
|
expect(stderr).toContain('NEXT_CLI_SESSION_STARTED')
|
|
const event1 = /NEXT_CLI_SESSION_STARTED[\s\S]+?{([\s\S]+?)}/
|
|
.exec(stderr)
|
|
.pop()
|
|
|
|
expect(event1).toMatch(/"pagesDir": true/)
|
|
expect(event1).toMatch(/"turboFlag": true/)
|
|
} catch (err) {
|
|
require('console').error('failing stderr', stderr, err)
|
|
throw err
|
|
}
|
|
})
|
|
|
|
it('detects --turbo correctly for `next dev` stopped', async () => {
|
|
const port = await findPort()
|
|
let stderr = ''
|
|
|
|
const { child, exit } = await launchDevServer(port, {
|
|
onStderr(msg) {
|
|
stderr += msg
|
|
},
|
|
env: {
|
|
NEXT_TELEMETRY_DEBUG: '1',
|
|
},
|
|
})
|
|
|
|
await retry(async () => {
|
|
expect(stderr).toMatch(/NEXT_CLI_SESSION_STARTED/)
|
|
})
|
|
await renderViaHTTP(port, '/hello')
|
|
|
|
if (child) {
|
|
await killApp(child, 'SIGTERM')
|
|
}
|
|
await exit.catch(() => {})
|
|
await retry(async () => {
|
|
expect(stderr).toMatch(/NEXT_CLI_SESSION_STOPPED/)
|
|
})
|
|
|
|
expect(stderr).toContain('NEXT_CLI_SESSION_STOPPED')
|
|
const event1 = /NEXT_CLI_SESSION_STOPPED[\s\S]+?{([\s\S]+?)}/
|
|
.exec(stderr)
|
|
.pop()
|
|
|
|
expect(event1).toMatch(/"pagesDir": true/)
|
|
expect(event1).toMatch(/"turboFlag": true/)
|
|
|
|
expect(
|
|
await fs.pathExists(path.join(next.testDir, '.next/_events.json'))
|
|
).toBe(false)
|
|
})
|
|
} else {
|
|
it('detects correctly for `next dev` stopped (no turbo)', async () => {
|
|
const port = await findPort()
|
|
// Rspack startup can take longer while restoring persistent cache state,
|
|
// so give telemetry events a wider retry window.
|
|
const retryDuration = isRspack ? 10_000 : 3_000
|
|
let stderr = ''
|
|
|
|
const { child, exit } = await launchDevServer(port, {
|
|
onStderr(msg) {
|
|
stderr += msg
|
|
},
|
|
env: {
|
|
NEXT_TELEMETRY_DEBUG: '1',
|
|
},
|
|
})
|
|
|
|
await retry(async () => {
|
|
expect(stderr).toMatch(/NEXT_CLI_SESSION_STARTED/)
|
|
}, retryDuration)
|
|
await renderViaHTTP(port, '/hello')
|
|
|
|
if (child) {
|
|
await killApp(child, 'SIGTERM')
|
|
}
|
|
await exit.catch(() => {})
|
|
|
|
await retry(async () => {
|
|
expect(stderr).toMatch(/NEXT_CLI_SESSION_STOPPED/)
|
|
}, retryDuration)
|
|
|
|
expect(stderr).toContain('NEXT_CLI_SESSION_STOPPED')
|
|
const event1 = /NEXT_CLI_SESSION_STOPPED[\s\S]+?{([\s\S]+?)}/
|
|
.exec(stderr)
|
|
.pop()
|
|
|
|
expect(event1).toMatch(/"turboFlag": false/)
|
|
expect(event1).toMatch(/"pagesDir": true/)
|
|
expect(event1).toMatch(/"appDir": true/)
|
|
|
|
expect(
|
|
await fs.pathExists(path.join(next.testDir, '.next/_events.json'))
|
|
).toBe(false)
|
|
})
|
|
;(isNextStart ? describe : describe.skip)('production mode', () => {
|
|
it('should detect app page counts', async () => {
|
|
await fs.ensureFile(path.join(next.testDir, 'app/ssr/page.js'))
|
|
await fs.writeFile(
|
|
path.join(next.testDir, 'app/ssr/page.js'),
|
|
`
|
|
export const revalidate = 0
|
|
export default function Page() {
|
|
return <p>ssr page</p>
|
|
}
|
|
`
|
|
)
|
|
await fs.ensureFile(path.join(next.testDir, 'app/edge-ssr/page.js'))
|
|
await fs.writeFile(
|
|
path.join(next.testDir, 'app/edge-ssr/page.js'),
|
|
`
|
|
export const runtime = 'edge'
|
|
export default function Page() {
|
|
return <p>edge-ssr page</p>
|
|
}
|
|
`
|
|
)
|
|
await fs.ensureFile(
|
|
path.join(next.testDir, 'app/app-ssg/[slug]/page.js')
|
|
)
|
|
await fs.writeFile(
|
|
path.join(next.testDir, 'app/app-ssg/[slug]/page.js'),
|
|
`
|
|
export function generateStaticParams() {
|
|
return [
|
|
{ slug: 'post-1' },
|
|
{ slug: 'post-2' },
|
|
]
|
|
}
|
|
export default function Page() {
|
|
return <p>ssg page</p>
|
|
}
|
|
`
|
|
)
|
|
const { cliOutput } = await next.build({
|
|
env: { NEXT_TELEMETRY_DEBUG: '1' },
|
|
})
|
|
|
|
try {
|
|
expect(cliOutput).toContain('NEXT_BUILD_OPTIMIZED')
|
|
const event1 = /NEXT_BUILD_OPTIMIZED[\s\S]+?{([\s\S]+?)}/
|
|
.exec(cliOutput)
|
|
.pop()
|
|
expect(event1).toMatch(/"staticPropsPageCount": 2/)
|
|
expect(event1).toMatch(/"serverPropsPageCount": 2/)
|
|
expect(event1).toMatch(/"ssrPageCount": 3/)
|
|
expect(event1).toMatch(/"staticPageCount": 5/)
|
|
expect(event1).toMatch(/"totalPageCount": 12/)
|
|
expect(event1).toMatch(/"totalAppPagesCount": 6/)
|
|
expect(event1).toMatch(/"serverAppPagesCount": 2/)
|
|
expect(event1).toMatch(/"edgeRuntimeAppCount": 1/)
|
|
expect(event1).toMatch(/"edgeRuntimePagesCount": 2/)
|
|
|
|
expect(cliOutput).toContain('NEXT_BUILD_COMPLETED')
|
|
const event2 = /NEXT_BUILD_COMPLETED[\s\S]+?{([\s\S]+?)}/
|
|
.exec(cliOutput)
|
|
.pop()
|
|
|
|
expect(event2).toMatch(/"totalAppPagesCount": 6/)
|
|
} catch (err) {
|
|
require('console').error('failing cliOutput', cliOutput, err)
|
|
throw err
|
|
}
|
|
})
|
|
|
|
it('detects reportWebVitals with no _app correctly for `next build`', async () => {
|
|
const { cliOutput } = await next.build({
|
|
env: { NEXT_TELEMETRY_DEBUG: '1' },
|
|
})
|
|
|
|
expect(cliOutput).toContain('NEXT_BUILD_OPTIMIZED')
|
|
const event1 = /NEXT_BUILD_OPTIMIZED[\s\S]+?{([\s\S]+?)}/
|
|
.exec(cliOutput)
|
|
.pop()
|
|
expect(event1).toMatch(/hasReportWebVitals.*?false/)
|
|
})
|
|
|
|
it('detect with reportWebVitals correctly for `next build`', async () => {
|
|
await fs.utimes(
|
|
path.join(next.testDir, 'pages', '_app_withreportwebvitals.empty'),
|
|
new Date(),
|
|
new Date()
|
|
)
|
|
await fs.rename(
|
|
path.join(next.testDir, 'pages', '_app_withreportwebvitals.empty'),
|
|
path.join(next.testDir, 'pages', '_app.js')
|
|
)
|
|
|
|
const { cliOutput } = await next.build({
|
|
env: { NEXT_TELEMETRY_DEBUG: '1' },
|
|
})
|
|
|
|
await fs.rename(
|
|
path.join(next.testDir, 'pages', '_app.js'),
|
|
path.join(next.testDir, 'pages', '_app_withreportwebvitals.empty')
|
|
)
|
|
|
|
try {
|
|
expect(cliOutput).toContain('NEXT_BUILD_OPTIMIZED')
|
|
const event1 = /NEXT_BUILD_OPTIMIZED[\s\S]+?{([\s\S]+?)}/
|
|
.exec(cliOutput)
|
|
.pop()
|
|
expect(event1).toMatch(/hasReportWebVitals.*?true/)
|
|
} catch (err) {
|
|
require('console').error(cliOutput)
|
|
throw err
|
|
}
|
|
})
|
|
|
|
it('detect without reportWebVitals correctly for `next build`', async () => {
|
|
await fs.utimes(
|
|
path.join(next.testDir, 'pages', '_app_withoutreportwebvitals.empty'),
|
|
new Date(),
|
|
new Date()
|
|
)
|
|
await fs.rename(
|
|
path.join(next.testDir, 'pages', '_app_withoutreportwebvitals.empty'),
|
|
path.join(next.testDir, 'pages', '_app.js')
|
|
)
|
|
|
|
const { cliOutput } = await next.build({
|
|
env: { NEXT_TELEMETRY_DEBUG: '1' },
|
|
})
|
|
|
|
await fs.rename(
|
|
path.join(next.testDir, 'pages', '_app.js'),
|
|
path.join(next.testDir, 'pages', '_app_withoutreportwebvitals.empty')
|
|
)
|
|
|
|
try {
|
|
expect(cliOutput).toContain('NEXT_BUILD_OPTIMIZED')
|
|
const event1 = /NEXT_BUILD_OPTIMIZED[\s\S]+?{([\s\S]+?)}/
|
|
.exec(cliOutput)
|
|
.pop()
|
|
expect(event1).toMatch(/hasReportWebVitals.*?false/)
|
|
} catch (err) {
|
|
require('console').error(cliOutput)
|
|
throw err
|
|
}
|
|
})
|
|
})
|
|
}
|
|
})
|