mirror of
https://github.com/hanzoai/next.js.git
synced 2026-09-24 17:00:51 +00:00
### What?
Converts every test under `test/integration/` to an isolated test
running through `nextTestSetup` (under `test/e2e/`, `test/production/`,
`test/development/`, or `test/unit/`), then deletes `test/integration/`
along with the legacy CI orchestration that was specific to it.
- `test/integration/` removed entirely (~327 test suites)
- New isolated suites added across the existing folders:
- `test/e2e/` — 175
- `test/production/` — 130
- `test/development/` — 43
- `test/unit/` — 1
- `.github/workflows/build_and_test.yml` and `run-tests.js` no longer
have any `integration` branches
- `nextTestSetup` gained a `baseUrl` option on `next.browser()` so a
small number of tests that drive their own proxy/static-export server
can keep using `next.browser(...)` instead of importing `next-webdriver`
directly
### Why?
`test/integration/` predated `nextTestSetup` and ran tests directly
against the source checkout via custom helpers (`launchApp`,
`nextBuild`, `nextStart`, `runNextCommand`, `webdriver`, `fetchViaHTTP`,
…). Each suite hand-rolled its own dev/start/build orchestration,
fixture mutation, and process management.
The isolated test model used by the rest of the repo gives each suite an
isolated working directory containing a packed `next.tgz` install, a
uniform `next.start()` / `next.build()` / `next.fetch()` /
`next.browser()` API, and the same lifecycle for dev, start, and deploy
modes — so a single set of assertions covers all three. Deploy-mode
skips and per-feature gates are expressed declaratively
(`skipDeployment`, `disableAutoSkewProtection`, `if (skipped) return`)
instead of branching on `process.env`.
Removing `test/integration/` lets us:
- Delete the bespoke orchestration code in the CI workflow and
`run-tests.js`
- Run every converted suite consistently in dev, start, and deploy modes
(where applicable)
- Reproduce every test locally with the same `pnpm
test-{dev,start}-{turbo,webpack}` commands; no separate `integration`
path
- Open the door to running `test/production` against deployments in the
future (the converted suites already declare `skipDeployment` so they
can be flipped on)
### How?
Mechanical conversion per suite, with targeted clean-ups:
1. **Per-suite conversion.** Each
`test/integration/<name>/test/index.test.{js,ts}` was rewritten into a
single `<name>.test.ts` under the right folder based on what the
original exercised:
- `launchApp` / dev-only assertions → `test/development/`
- `nextBuild` + `nextStart` / start-only assertions → `test/production/`
- Both → `test/e2e/`
- The one pure jsdom render check (`link-without-router`) → `test/unit/`
2. **API mapping.** Custom helpers were replaced by `nextTestSetup`
equivalents: `launchApp` → `next.start()`, `nextBuild` → `next.build()`,
`runNextCommand` → `next.runCommand`, `fetchViaHTTP` → `next.fetch`,
`webdriver(...)` → `next.browser(...)`. Fixture mutations switched from
raw `fs.writeFile`/`fs.rename` to `next.patchFile` (with the 3-arg
`runWithTempContent` callback when the change has a defined scope) and
`next.deleteFile`.
3. **Deploy-mode handling.** Suites that can't run in deploy mode (use
`patchFile` / `next.build()` / depend on local CLI output) declare
`skipDeployment: true` and early-return on the `skipped` boolean. Suites
where Vercel's edge mutates URLs (`&dpl=`, immutable assets) declare
`disableAutoSkewProtection: true`.
4. **`next.browser({ baseUrl })`.** A handful of tests
(`prerender-export`, `cdn-cache-busting`, `preload-viewport`, both
`react-virtualized` suites) need to drive a separate server (a
static-export server or an `http-proxy` instance) rather than the
Next.js process. Instead of importing `next-webdriver` directly, those
tests now pass `{ baseUrl: <port|url> }` to `next.browser()`. For the
proxy cases, the proxy was moved into `server.js` inside the fixture and
`http-proxy` declared via the `dependencies` option of `nextTestSetup`,
so the test runs with a fully isolated dependency graph.
5. **CI clean-up.** With `test/integration` gone, the `test
integration*` jobs and `integration-tests-manifest`-related logic in
`.github/workflows/build_and_test.yml` were removed, and `run-tests.js`
no longer has the `integration` test-folder branch.
6. **Validation.** The PR was iterated against multiple full CI runs;
the remaining failures on the latest run are pre-existing flakes
(segment-cache 60s `act` timeouts in turbopack-prod) or transient
infrastructure issues unrelated to the conversion.
200 lines
4.7 KiB
TypeScript
200 lines
4.7 KiB
TypeScript
/**
|
|
* @fileoverview
|
|
*
|
|
* This file contains utilities for `create-next-app` testing.
|
|
*/
|
|
|
|
import { execSync, spawn, SpawnOptions } from 'child_process'
|
|
import { existsSync } from 'fs'
|
|
import { join, resolve } from 'path'
|
|
import glob from 'glob'
|
|
import Conf from 'next/dist/compiled/conf'
|
|
|
|
import {
|
|
getProjectSetting,
|
|
mapSrcFiles,
|
|
projectSpecification,
|
|
} from './specification'
|
|
import {
|
|
CustomTemplateOptions,
|
|
DefaultTemplateOptions,
|
|
ProjectDeps,
|
|
ProjectFiles,
|
|
} from './types'
|
|
import { serializeTestPkgPathsEnv } from './test-pkg-paths'
|
|
|
|
const cli = require.resolve('create-next-app/dist/index.js')
|
|
|
|
/**
|
|
* Run the built version of `create-next-app` with the given arguments.
|
|
*/
|
|
export const createNextApp = (
|
|
args: string[],
|
|
options?: SpawnOptions,
|
|
testVersion?: string,
|
|
clearPreferences: boolean = true
|
|
) => {
|
|
const conf = new Conf({ projectName: 'create-next-app' })
|
|
if (clearPreferences) {
|
|
conf.clear()
|
|
}
|
|
|
|
console.log(`[TEST] $ ${cli} ${args.join(' ')}`, { options })
|
|
|
|
const cloneEnv = { ...process.env }
|
|
// unset CI env as this skips the auto-install behavior
|
|
// being tested
|
|
delete cloneEnv.CI
|
|
delete cloneEnv.CIRCLECI
|
|
delete cloneEnv.GITHUB_ACTIONS
|
|
delete cloneEnv.CONTINUOUS_INTEGRATION
|
|
delete cloneEnv.RUN_ID
|
|
delete cloneEnv.BUILD_NUMBER
|
|
|
|
cloneEnv.NEXT_PRIVATE_TEST_VERSION = testVersion || 'canary'
|
|
// Forward all packed workspace tarballs so CNA can install siblings
|
|
// (`next-rspack`, `eslint-config-next`, ...) from their own tarballs
|
|
// when running tests directly (without `run-tests.js`).
|
|
const pkgPathsEnv = serializeTestPkgPathsEnv()
|
|
if (pkgPathsEnv) {
|
|
cloneEnv.NEXT_TEST_PKG_PATHS = pkgPathsEnv
|
|
}
|
|
|
|
return spawn('node', [cli].concat(args), {
|
|
...options,
|
|
env: {
|
|
...cloneEnv,
|
|
...options.env,
|
|
},
|
|
})
|
|
}
|
|
|
|
export const projectShouldHaveNoGitChanges = ({
|
|
cwd,
|
|
projectName,
|
|
}: DefaultTemplateOptions) => {
|
|
const projectDirname = join(cwd, projectName)
|
|
|
|
try {
|
|
execSync('git diff --quiet', { cwd: projectDirname })
|
|
} catch {
|
|
execSync('git status', { cwd: projectDirname, stdio: 'inherit' })
|
|
execSync('git --no-pager diff', { cwd: projectDirname, stdio: 'inherit' })
|
|
|
|
throw new Error('Found unexpected git changes.')
|
|
}
|
|
}
|
|
|
|
export const projectFilesShouldExist = ({
|
|
cwd,
|
|
projectName,
|
|
files,
|
|
}: ProjectFiles) => {
|
|
const projectRoot = resolve(cwd, projectName)
|
|
for (const file of files) {
|
|
try {
|
|
expect(existsSync(resolve(projectRoot, file))).toBe(true)
|
|
} catch (err) {
|
|
require('console').error(
|
|
`missing expected file ${file}`,
|
|
glob.sync('**/*', { cwd, ignore: '**/node_modules/**' }),
|
|
files
|
|
)
|
|
throw err
|
|
}
|
|
}
|
|
}
|
|
|
|
export const projectFilesShouldNotExist = ({
|
|
cwd,
|
|
projectName,
|
|
files,
|
|
}: ProjectFiles) => {
|
|
const projectRoot = resolve(cwd, projectName)
|
|
for (const file of files) {
|
|
try {
|
|
expect(existsSync(resolve(projectRoot, file))).toBe(false)
|
|
} catch (err) {
|
|
require('console').error(
|
|
`unexpected file present ${file}`,
|
|
glob.sync('**/*', { cwd, ignore: '**/node_modules/**' }),
|
|
files
|
|
)
|
|
throw err
|
|
}
|
|
}
|
|
}
|
|
|
|
export const projectDepsShouldBe = ({
|
|
cwd,
|
|
projectName,
|
|
type,
|
|
deps,
|
|
}: ProjectDeps) => {
|
|
const projectRoot = resolve(cwd, projectName)
|
|
const pkgJson = require(resolve(projectRoot, 'package.json'))
|
|
expect(Object.keys(pkgJson[type] || {}).sort()).toEqual(deps.sort())
|
|
}
|
|
|
|
export const shouldBeTemplateProject = ({
|
|
cwd,
|
|
projectName,
|
|
template,
|
|
mode,
|
|
srcDir,
|
|
}: CustomTemplateOptions) => {
|
|
projectFilesShouldExist({
|
|
cwd,
|
|
projectName,
|
|
files: getProjectSetting({ template, mode, setting: 'files', srcDir }),
|
|
})
|
|
|
|
// Tailwind templates share the same files (tailwind.config.mjs, postcss.config.mjs)
|
|
if (
|
|
!['app-tw', 'app-tw-empty', 'default-tw', 'default-tw-empty'].includes(
|
|
template
|
|
)
|
|
) {
|
|
projectFilesShouldNotExist({
|
|
cwd,
|
|
projectName,
|
|
files: mapSrcFiles(
|
|
projectSpecification[template][mode === 'js' ? 'ts' : 'js'].files,
|
|
srcDir
|
|
),
|
|
})
|
|
}
|
|
|
|
projectDepsShouldBe({
|
|
type: 'dependencies',
|
|
cwd,
|
|
projectName,
|
|
deps: getProjectSetting({ template, mode, setting: 'deps' }),
|
|
})
|
|
|
|
projectDepsShouldBe({
|
|
type: 'devDependencies',
|
|
cwd,
|
|
projectName,
|
|
deps: getProjectSetting({ template, mode, setting: 'devDeps' }),
|
|
})
|
|
}
|
|
|
|
export const shouldBeJavascriptProject = ({
|
|
cwd,
|
|
projectName,
|
|
template,
|
|
srcDir,
|
|
}: Omit<CustomTemplateOptions, 'mode'>) => {
|
|
shouldBeTemplateProject({ cwd, projectName, template, mode: 'js', srcDir })
|
|
}
|
|
|
|
export const shouldBeTypescriptProject = ({
|
|
cwd,
|
|
projectName,
|
|
template,
|
|
srcDir,
|
|
}: Omit<CustomTemplateOptions, 'mode'>) => {
|
|
shouldBeTemplateProject({ cwd, projectName, template, mode: 'ts', srcDir })
|
|
}
|