mirror of
https://github.com/hanzoai/next.js.git
synced 2026-09-24 17:00:51 +00:00
## Enable synchronous access to native bindings ## What? This PR refactors the SWC bindings loading mechanism to support synchronous access to bindings after they've been loaded. It introduces new functions `installBindings()` and `getBindingsSync()` to properly manage the bindings lifecycle. `installBindings` is called early by tools that rely on them. There were of course a few complexities: * webpack loaders need to defensively install bindings to support being run by webpack * the hacky `loadNativeSync` method used by `transformSync` remains required due to the jest-transformer API (i didn't see a clear initialization location). * the `experimental.useWasmBinary` configuration is broken by design * if the config is `next.config.ts` when we load SWC to transpile it, but that requires the native bindings, so we might load native bindings even when you ask for wasm. I added a warning message for this case and the workaround is to use the node native transpilation support. * this should probably be a command line flag if it is important * we need to lazily load the `swc/index.ts` module since it transitively loads `react` which reads `NODE_ENV` and various next entrypoints might modify that. ## Why? This makes it clearer that we are correctly applying the `useWasmBinary` option and can simplify some code paths that now don't need to be `async`. This will be important in a future PR where i move some parts of issue formatting into rust/wasm. Having those APIs be async will decrease their usability.
137 lines
5.3 KiB
TypeScript
137 lines
5.3 KiB
TypeScript
/* eslint-env jest */
|
|
import { transform } from 'next/dist/build/swc'
|
|
import { installBindings } from 'next/dist/build/swc/install-bindings'
|
|
import path from 'path'
|
|
import fsp from 'fs/promises'
|
|
|
|
const swc = async (code) => {
|
|
let output = await transform(code)
|
|
return output.code
|
|
}
|
|
|
|
const trim = (s) => s.join('\n').trim().replace(/^\s+/gm, '')
|
|
|
|
describe('next/swc', () => {
|
|
beforeAll(async () => {
|
|
await installBindings()
|
|
})
|
|
describe('hook_optimizer', () => {
|
|
it('should leave alone array destructuring of hooks', async () => {
|
|
const output = await swc(
|
|
trim`
|
|
import { useState } from 'react';
|
|
const [count, setCount] = useState(0);
|
|
`
|
|
)
|
|
|
|
expect(output).toMatchInlineSnapshot(`
|
|
"function _array_like_to_array(arr, len) {
|
|
if (len == null || len > arr.length) len = arr.length;
|
|
for(var i = 0, arr2 = new Array(len); i < len; i++)arr2[i] = arr[i];
|
|
return arr2;
|
|
}
|
|
function _array_with_holes(arr) {
|
|
if (Array.isArray(arr)) return arr;
|
|
}
|
|
function _iterable_to_array_limit(arr, i) {
|
|
var _i = arr == null ? null : typeof Symbol !== "undefined" && arr[Symbol.iterator] || arr["@@iterator"];
|
|
if (_i == null) return;
|
|
var _arr = [];
|
|
var _n = true;
|
|
var _d = false;
|
|
var _s, _e;
|
|
try {
|
|
for(_i = _i.call(arr); !(_n = (_s = _i.next()).done); _n = true){
|
|
_arr.push(_s.value);
|
|
if (i && _arr.length === i) break;
|
|
}
|
|
} catch (err) {
|
|
_d = true;
|
|
_e = err;
|
|
} finally{
|
|
try {
|
|
if (!_n && _i["return"] != null) _i["return"]();
|
|
} finally{
|
|
if (_d) throw _e;
|
|
}
|
|
}
|
|
return _arr;
|
|
}
|
|
function _non_iterable_rest() {
|
|
throw new TypeError("Invalid attempt to destructure non-iterable instance.\\\\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method.");
|
|
}
|
|
function _sliced_to_array(arr, i) {
|
|
return _array_with_holes(arr) || _iterable_to_array_limit(arr, i) || _unsupported_iterable_to_array(arr, i) || _non_iterable_rest();
|
|
}
|
|
function _unsupported_iterable_to_array(o, minLen) {
|
|
if (!o) return;
|
|
if (typeof o === "string") return _array_like_to_array(o, minLen);
|
|
var n = Object.prototype.toString.call(o).slice(8, -1);
|
|
if (n === "Object" && o.constructor) n = o.constructor.name;
|
|
if (n === "Map" || n === "Set") return Array.from(n);
|
|
if (n === "Arguments" || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(n)) return _array_like_to_array(o, minLen);
|
|
}
|
|
import { useState } from 'react';
|
|
var _useState = _sliced_to_array(useState(0), 2), count = _useState[0], setCount = _useState[1];
|
|
"
|
|
`)
|
|
})
|
|
|
|
it('should leave alone array spread of hooks', async () => {
|
|
const output = await swc(
|
|
trim`
|
|
import { useState } from 'react';
|
|
const [...copy] = useState(0);
|
|
`
|
|
)
|
|
|
|
expect(output).toMatchInlineSnapshot(`
|
|
"function _array_like_to_array(arr, len) {
|
|
if (len == null || len > arr.length) len = arr.length;
|
|
for(var i = 0, arr2 = new Array(len); i < len; i++)arr2[i] = arr[i];
|
|
return arr2;
|
|
}
|
|
function _array_with_holes(arr) {
|
|
if (Array.isArray(arr)) return arr;
|
|
}
|
|
function _iterable_to_array(iter) {
|
|
if (typeof Symbol !== "undefined" && iter[Symbol.iterator] != null || iter["@@iterator"] != null) return Array.from(iter);
|
|
}
|
|
function _non_iterable_rest() {
|
|
throw new TypeError("Invalid attempt to destructure non-iterable instance.\\\\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method.");
|
|
}
|
|
function _to_array(arr) {
|
|
return _array_with_holes(arr) || _iterable_to_array(arr) || _unsupported_iterable_to_array(arr) || _non_iterable_rest();
|
|
}
|
|
function _unsupported_iterable_to_array(o, minLen) {
|
|
if (!o) return;
|
|
if (typeof o === "string") return _array_like_to_array(o, minLen);
|
|
var n = Object.prototype.toString.call(o).slice(8, -1);
|
|
if (n === "Object" && o.constructor) n = o.constructor.name;
|
|
if (n === "Map" || n === "Set") return Array.from(n);
|
|
if (n === "Arguments" || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(n)) return _array_like_to_array(o, minLen);
|
|
}
|
|
import { useState } from 'react';
|
|
var _useState = _to_array(useState(0)), copy = _useState.slice(0);
|
|
"
|
|
`)
|
|
})
|
|
})
|
|
|
|
describe('private env replacement', () => {
|
|
it('__NEXT_REQUIRED_NODE_VERSION_RANGE is replaced', async () => {
|
|
const pkgDir = path.dirname(require.resolve('next/package.json'))
|
|
const nextEntryContent = await fsp.readFile(
|
|
path.join(pkgDir, 'dist/bin/next'),
|
|
'utf8'
|
|
)
|
|
expect(nextEntryContent).not.toContain(
|
|
'__NEXT_REQUIRED_NODE_VERSION_RANGE'
|
|
)
|
|
expect(nextEntryContent).toMatch(
|
|
/For Next.js, Node.js version "\$\{">=\d+\.\d+\.\d*"\}" is required./
|
|
)
|
|
})
|
|
})
|
|
})
|