mirror of
https://github.com/hanzoai/next.js.git
synced 2026-10-30 14:46:38 +00:00
1287f9a027
### What?
Changes Turbopack's error overlay to show specific SWC diagnostic
messages as the error title instead of generic messages like "Parsing
ecmascript source code failed" or "Ecmascript file had an error".
### Why?
Previously, all SWC parse/analysis errors in Turbopack showed a generic
title (e.g. "Parsing ecmascript source code failed") in the redbox
header, with the actual specific error message buried in the description
below the code frame. This made it harder for developers to quickly
understand what went wrong.
**Before:**
```
Parsing ecmascript source code failed
> 1 | export default () => <div/
| ^
Expected '>', got '<eof>'
```
**After:**
```
Expected '>', got '<eof>'
> 1 | export default () => <div/
| ^
Parsing ecmascript source code failed
```
### How?
**Core change** in
`turbopack/crates/turbopack-swc-utils/src/emitter.rs`:
When the `IssueEmitter` has a `self.title` set (the generic title like
"Parsing ecmascript source code failed"), the SWC diagnostic message is
now used as the issue title, and the generic title is demoted to the
description. When `self.title` is not set, the existing behavior is
preserved (first line of message becomes title, rest becomes
description).
**Test updates** across ~15 test files:
Updated all `isTurbopack` branches in test expectations to reflect the
swapped title/description. Only Turbopack-specific branches were
modified; webpack and rspack expectations are unchanged.
**New test suite** (`test/development/app-dir/ecmascript-error-title/`):
Dedicated tests verifying that both syntax errors (e.g. `Expected '>',
got '<eof>'`) and analysis errors (e.g. `the name 'Table' is defined
multiple times`) show the specific SWC message as the redbox title.
**Turbopack snapshot updates:**
4 snapshot files renamed to reflect new titles (e.g. `Parsing ecmascript
source code failed-*.txt` → `Expression expected-*.txt`).
---------
Co-authored-by: Claude <[email protected]>
76 lines
3.1 KiB
TypeScript
76 lines
3.1 KiB
TypeScript
import { nextTestSetup } from 'e2e-utils'
|
||
import {
|
||
waitForRedbox,
|
||
getRedboxDescription,
|
||
getRedboxSource,
|
||
} from 'next-test-utils'
|
||
|
||
describe('app-dir - server-component-next-dynamic-ssr-false', () => {
|
||
const { next } = nextTestSetup({
|
||
files: __dirname,
|
||
})
|
||
|
||
it('should error when use dynamic ssr:false in server component', async () => {
|
||
const browser = await next.browser('/')
|
||
await waitForRedbox(browser)
|
||
const redbox = {
|
||
description: await getRedboxDescription(browser),
|
||
source: await getRedboxSource(browser),
|
||
}
|
||
|
||
if (process.env.IS_TURBOPACK_TEST) {
|
||
expect(redbox.description).toMatchInlineSnapshot(
|
||
`"\`ssr: false\` is not allowed with \`next/dynamic\` in Server Components. Please move it into a Client Component."`
|
||
)
|
||
expect(redbox.source).toMatchInlineSnapshot(`
|
||
"./app/page.js (3:23)
|
||
\`ssr: false\` is not allowed with \`next/dynamic\` in Server Components. Please move it into a Client Component.
|
||
1 | import dynamic from 'next/dynamic'
|
||
2 |
|
||
> 3 | const DynamicClient = dynamic(() => import('./client'), { ssr: false })
|
||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||
4 |
|
||
5 | export default function Page() {
|
||
6 | return <DynamicClient />
|
||
|
||
Ecmascript file had an error"
|
||
`)
|
||
} else if (process.env.NEXT_RSPACK) {
|
||
expect(redbox.description).toMatchInlineSnapshot(
|
||
`" ╰─▶ × Error: x \`ssr: false\` is not allowed with \`next/dynamic\` in Server Components. Please move it into a Client Component."`
|
||
)
|
||
expect(redbox.source).toMatchInlineSnapshot(`
|
||
"./app/page.js
|
||
╰─▶ × Error: x \`ssr: false\` is not allowed with \`next/dynamic\` in Server Components. Please move it into a Client Component.
|
||
│ ,-[3:1]
|
||
│ 1 | import dynamic from 'next/dynamic'
|
||
│ 2 |
|
||
│ 3 | const DynamicClient = dynamic(() => import('./client'), { ssr: false })
|
||
│ : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||
│ 4 |
|
||
│ 5 | export default function Page() {
|
||
│ 6 | return <DynamicClient />
|
||
│ \`----
|
||
│"
|
||
`)
|
||
} else {
|
||
expect(redbox.description).toMatchInlineSnapshot(
|
||
`" x \`ssr: false\` is not allowed with \`next/dynamic\` in Server Components. Please move it into a Client Component."`
|
||
)
|
||
expect(redbox.source).toMatchInlineSnapshot(`
|
||
"./app/page.js
|
||
Error: x \`ssr: false\` is not allowed with \`next/dynamic\` in Server Components. Please move it into a Client Component.
|
||
,-[3:1]
|
||
1 | import dynamic from 'next/dynamic'
|
||
2 |
|
||
3 | const DynamicClient = dynamic(() => import('./client'), { ssr: false })
|
||
: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||
4 |
|
||
5 | export default function Page() {
|
||
6 | return <DynamicClient />
|
||
\`----"
|
||
`)
|
||
}
|
||
})
|
||
})
|