mirror of
https://github.com/hanzoai/next.js.git
synced 2026-10-30 14:46:38 +00:00
JJ KasperandGitHub
aa3ba7ed15
TypeScript 6 treats `moduleResolution: "node"` as deprecated (`node10`) and can fail builds with `TS5107`. This update keeps Next.js tsconfig defaults compatible with modern TypeScript by preferring `moduleResolution: "bundler"` for modern module modes, while preserving `"node"` for `commonjs`/`amd` configs where `bundler` is invalid. Also updates the related tests/snapshots to match the new defaults.
68 lines
1.8 KiB
TypeScript
68 lines
1.8 KiB
TypeScript
import { createNext } from 'e2e-utils'
|
|
import { check } from 'next-test-utils'
|
|
import { NextInstance } from 'e2e-utils'
|
|
|
|
describe('correct tsconfig.json defaults', () => {
|
|
let next: NextInstance
|
|
|
|
beforeAll(async () => {
|
|
next = await createNext({
|
|
files: {
|
|
'pages/index.tsx': 'export default function Page() {}',
|
|
},
|
|
skipStart: true,
|
|
dependencies: {
|
|
typescript: 'latest',
|
|
'@types/react': 'latest',
|
|
'@types/node': 'latest',
|
|
},
|
|
})
|
|
})
|
|
afterAll(() => next.destroy())
|
|
|
|
it('should add `moduleResolution` when generating tsconfig.json in dev', async () => {
|
|
try {
|
|
expect(
|
|
await next.readFile('tsconfig.json').catch(() => false)
|
|
).toBeFalse()
|
|
|
|
await next.start()
|
|
|
|
let content: string
|
|
// wait for tsconfig to be written
|
|
await check(async () => {
|
|
content = await next.readFile('tsconfig.json')
|
|
return content && content !== '{}' ? 'ready' : 'retry'
|
|
}, 'ready')
|
|
|
|
const tsconfig = JSON.parse(content)
|
|
expect(next.cliOutput).not.toContain('moduleResolution')
|
|
|
|
expect(tsconfig.compilerOptions).toEqual(
|
|
expect.objectContaining({ moduleResolution: 'bundler' })
|
|
)
|
|
} finally {
|
|
await next.stop()
|
|
}
|
|
})
|
|
|
|
it('should not warn for `moduleResolution` when already present and valid', async () => {
|
|
try {
|
|
expect(
|
|
await next.readFile('tsconfig.json').catch(() => false)
|
|
).toBeTruthy()
|
|
|
|
await next.start()
|
|
|
|
const tsconfig = JSON.parse(await next.readFile('tsconfig.json'))
|
|
|
|
expect(tsconfig.compilerOptions).toEqual(
|
|
expect.objectContaining({ moduleResolution: 'bundler' })
|
|
)
|
|
expect(next.cliOutput).not.toContain('moduleResolution')
|
|
} finally {
|
|
await next.stop()
|
|
}
|
|
})
|
|
})
|