mirror of
https://github.com/hanzoai/next.js.git
synced 2026-10-30 14:46:38 +00:00
Zack TannerandGitHub
06d45e7de8
When navigating away from a page due to an MPA navigation or browser refresh, we were aborting any pending RSC requests. However, in the case where the abort was due to an MPA navigation, the browser would restore the execution context via the built-in bfcache, and the aborted fetch would cause React to get in an errored state, leading to "BodyStreamBuffer was aborted". Rather than aborting the pending requests, we instead mark that we would have aborted due to the page unloading. That still solves the original reason the flag was added (suppressing the fetch errors that get logged) Fixes NAR-519
34 lines
1.4 KiB
TypeScript
34 lines
1.4 KiB
TypeScript
import { nextTestSetup } from 'e2e-utils'
|
|
|
|
const describeHeaded = process.env.HEADLESS ? describe.skip : describe
|
|
|
|
describeHeaded('fetch-abort-on-refresh', () => {
|
|
const { next } = nextTestSetup({
|
|
files: __dirname,
|
|
})
|
|
|
|
it('should not show abort error in global error boundary when restoring from bfcache', async () => {
|
|
// This test ensures that when restoring a page from the browser bfcache that was pending RSC data,
|
|
// that the abort does not propagate to a user's error boundary.
|
|
const browser = await next.browser('/', { headless: false })
|
|
|
|
await browser.elementById('trigger-navigation').click()
|
|
|
|
await browser.waitForElementByCss('#root-2')
|
|
|
|
// Go back to trigger bfcache restoration
|
|
// we overwrite the typical waitUntil: 'load' option here as the event is never being triggered if we hit the bfcache
|
|
await browser.back({ waitUntil: 'commit' })
|
|
|
|
// Check that we're back on the slow page (the page that was first redirected to, before the MPA, not the error boundary)
|
|
// We use element checks instead of eval() because eval() triggers waitForLoadState which times out with bfcache
|
|
const hasSlowPage = await browser.hasElementByCss('#slow-page')
|
|
const hasGlobalError = await browser.hasElementByCss(
|
|
'h2:has-text("Something went wrong!")'
|
|
)
|
|
|
|
expect(hasSlowPage).toBe(true)
|
|
expect(hasGlobalError).toBe(false)
|
|
})
|
|
})
|