mirror of
https://github.com/hanzoai/next.js.git
synced 2026-09-24 17:00:51 +00:00
430e71a38d
### What? Update docker examples to correctly set HOSTNAME env variable for standalone output Related to PR: https://github.com/vercel/next.js/pull/52804 ### Why? ### TL;DR The dockerfiile examples need to modified as that contains HOSTNAME setting that apparently is not working as expected. Related to Issue: https://github.com/vercel/next.js/issues/58657 Affected examples: https://github.com/vercel/next.js/tree/canary/examples/with-docker https://github.com/vercel/next.js/tree/canary/examples/with-docker-multi-env ### Longer explanations Based on [Docker document](https://docs.docker.com/engine/reference/builder/#environment-replacement): > You can also use environment variables with RUN, CMD, and ENTRYPOINT instructions, but in those cases the variable substitution is handled by the command shell, not the builder. It means that when executing the last CMD ( `node server.js` ) in Dockerfile samples, the HOSTNAME defined by prior `ENV` instruction is simply ignored. This causes problems typically when the host process sets HOSTNAME - e.g. for instance when using AWS Fargate for deployment [we can't have control over HOSTNAME](https://stackoverflow.com/a/52871552) set by the host process. (also refer to the issue #58657 above) ### How? Updated Dockerfilie samples, by setting HOSTNAME directly in CMD instruction that launches nextjs server, not in the builder process. Used this setting at my end (with AWS Fargate) to confirm that it fixes the network problem. Closes NEXT- Fixes #58657 Co-authored-by: Sam Ko <[email protected]>
52 lines
1.5 KiB
Docker
52 lines
1.5 KiB
Docker
FROM node:18-alpine AS base
|
|
|
|
# 1. Install dependencies only when needed
|
|
FROM base AS deps
|
|
# Check https://github.com/nodejs/docker-node/tree/b4117f9333da4138b03a546ec926ef50a31506c3#nodealpine to understand why libc6-compat might be needed.
|
|
RUN apk add --no-cache libc6-compat
|
|
|
|
WORKDIR /app
|
|
|
|
# Install dependencies based on the preferred package manager
|
|
COPY package.json yarn.lock* package-lock.json* pnpm-lock.yaml* ./
|
|
RUN \
|
|
if [ -f yarn.lock ]; then yarn --frozen-lockfile; \
|
|
elif [ -f package-lock.json ]; then npm ci; \
|
|
elif [ -f pnpm-lock.yaml ]; then corepack enable pnpm && pnpm i; \
|
|
else echo "Lockfile not found." && exit 1; \
|
|
fi
|
|
|
|
# 2. Rebuild the source code only when needed
|
|
FROM base AS builder
|
|
WORKDIR /app
|
|
COPY --from=deps /app/node_modules ./node_modules
|
|
COPY . .
|
|
# This will do the trick, use the corresponding env file for each environment.
|
|
COPY .env.development.sample .env.production
|
|
RUN npm run build
|
|
|
|
# 3. Production image, copy all the files and run next
|
|
FROM base AS runner
|
|
WORKDIR /app
|
|
|
|
ENV NODE_ENV=production
|
|
|
|
RUN addgroup -g 1001 -S nodejs
|
|
RUN adduser -S nextjs -u 1001
|
|
|
|
COPY --from=builder /app/public ./public
|
|
|
|
# Automatically leverage output traces to reduce image size
|
|
# https://nextjs.org/docs/advanced-features/output-file-tracing
|
|
COPY --from=builder --chown=nextjs:nodejs /app/.next/standalone ./
|
|
COPY --from=builder --chown=nextjs:nodejs /app/.next/static ./.next/static
|
|
|
|
|
|
USER nextjs
|
|
|
|
EXPOSE 3000
|
|
|
|
ENV PORT 3000
|
|
|
|
CMD HOSTNAME=localhost node server.js
|