mirror of
https://github.com/hanzoai/next.js.git
synced 2026-09-24 17:00:51 +00:00
Zack TannerandGitHub
1dffd3c02a
This removes the client-side polling logic that we're doing on every HMR tick in favor of events like `addedPage` / `removedPage`. It was leading to a lot of misc issues & confusion surrounding error/404 pages being polled needlessly. Instead this updates `addedPage` / `removedPage` to be emitted on the server, so that we can leverage those hooks to reload when necessary. Fixes #10024 Fixes #51132 Closes NEXT-1372 related discussion: https://github.com/vercel/next.js/discussions/40000 ---------
97 lines
3.0 KiB
TypeScript
97 lines
3.0 KiB
TypeScript
import { createNextDescribe } from 'e2e-utils'
|
|
import { check, waitFor } from 'next-test-utils'
|
|
|
|
const envFile = '.env.development.local'
|
|
|
|
createNextDescribe(
|
|
`app-dir-hmr`,
|
|
{
|
|
files: __dirname,
|
|
},
|
|
({ next }) => {
|
|
describe('filesystem changes', () => {
|
|
it('should not continously poll when hitting a not found page', async () => {
|
|
let requestCount = 0
|
|
|
|
const browser = await next.browser('/does-not-exist', {
|
|
beforePageLoad(page) {
|
|
page.on('request', (request) => {
|
|
const url = new URL(request.url())
|
|
if (url.pathname === '/does-not-exist') {
|
|
requestCount++
|
|
}
|
|
})
|
|
},
|
|
})
|
|
const body = await browser.elementByCss('body').text()
|
|
expect(body).toContain('404')
|
|
|
|
await waitFor(3000)
|
|
|
|
expect(requestCount).toBe(1)
|
|
})
|
|
|
|
it('should not break when renaming a folder', async () => {
|
|
const browser = await next.browser('/folder')
|
|
const text = await browser.elementByCss('h1').text()
|
|
expect(text).toBe('Hello')
|
|
|
|
// Rename folder
|
|
await next.renameFolder('app/folder', 'app/folder-renamed')
|
|
|
|
try {
|
|
// Should be 404 in a few seconds
|
|
await check(async () => {
|
|
const body = await browser.elementByCss('body').text()
|
|
expect(body).toContain('404')
|
|
return 'success'
|
|
}, 'success')
|
|
|
|
// The new page should be rendered
|
|
const newHTML = await next.render('/folder-renamed')
|
|
expect(newHTML).toContain('Hello')
|
|
} finally {
|
|
// Rename it back
|
|
await next.renameFolder('app/folder-renamed', 'app/folder')
|
|
}
|
|
})
|
|
|
|
it('should update server components pages when env files is changed (nodejs)', async () => {
|
|
const envContent = await next.readFile(envFile)
|
|
const browser = await next.browser('/env/node')
|
|
expect(await browser.elementByCss('p').text()).toBe('mac')
|
|
await next.patchFile(envFile, 'MY_DEVICE="ipad"')
|
|
|
|
try {
|
|
await check(async () => {
|
|
expect(await browser.elementByCss('p').text()).toBe('ipad')
|
|
return 'success'
|
|
}, /success/)
|
|
} finally {
|
|
await next.patchFile(envFile, envContent)
|
|
}
|
|
})
|
|
|
|
it('should update server components pages when env files is changed (edge)', async () => {
|
|
const envContent = await next.readFile(envFile)
|
|
const browser = await next.browser('/env/edge')
|
|
expect(await browser.elementByCss('p').text()).toBe('mac')
|
|
await next.patchFile(envFile, 'MY_DEVICE="ipad"')
|
|
|
|
try {
|
|
await check(async () => {
|
|
expect(await browser.elementByCss('p').text()).toBe('ipad')
|
|
return 'success'
|
|
}, /success/)
|
|
} finally {
|
|
await next.patchFile(envFile, envContent)
|
|
}
|
|
})
|
|
|
|
it('should have no unexpected action error for hmr', async () => {
|
|
expect(next.cliOutput).not.toContain('Unexpected action')
|
|
})
|
|
})
|
|
}
|
|
)
|