mirror of
https://github.com/hanzoai/next.js.git
synced 2026-09-24 17:00:51 +00:00
Tim NeutkensandGitHub
e169e73b45
## What? As @leerob and I found in-person when opening #57230 the `hasRedBox()` helper was incorrectly passing when it shouldn't pass in both the true and false case. This PR uses a different approach by waiting 7 seconds before checking, this leaves enough room for HMR / reloads to apply, it doesn't meaningfully slow down the test suite and increases reliability of the check as you can see below in the tests that were previously passing that are no longer passing. I've moved these to skipped tests for landing this PR as I want to avoid further issues being introduced while we fix them. @huozhi will investigate these next week 👍 Failing tests that are temporarily skipped: - https://github.com/vercel/next.js/pull/60522/files#diff-513b477050bf1a620697b4d16bc1e6850282cb54e0609bdc5fd34307bfa9e471R9 - https://github.com/vercel/next.js/pull/60522/files#diff-fa7d7c8c40914005c138d852eaf6a69ac0df51ec77bec548cbc5f0bfbdc8ebc5R25 - https://github.com/vercel/next.js/pull/60522/files#diff-6f9f7dc131416cb17938311939a56d8c0e685a8fe6e8fc0cf5cd04939c74f388R41 - https://github.com/vercel/next.js/pull/60522/files#diff-439830e340a320c56645e9d00aaf0fd0b492ddb90b6d7f9db89458ccc5158eb7R8 - https://github.com/vercel/next.js/pull/60522/files#diff-62938bf5cd4d84f96dde8b6bcb2c8e18099e6dfca269c4302229b79175c0250cR18 - https://github.com/vercel/next.js/pull/60522/files#diff-513b477050bf1a620697b4d16bc1e6850282cb54e0609bdc5fd34307bfa9e471R9 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Closes NEXT-2059
96 lines
3.6 KiB
TypeScript
96 lines
3.6 KiB
TypeScript
import { getRedboxHeader, hasRedbox } from 'next-test-utils'
|
|
import { createNextDescribe } from 'e2e-utils'
|
|
|
|
async function testDev(browser, errorRegex) {
|
|
expect(await hasRedbox(browser)).toBe(true)
|
|
expect(await getRedboxHeader(browser)).toMatch(errorRegex)
|
|
}
|
|
|
|
createNextDescribe(
|
|
'app dir - global error',
|
|
{
|
|
files: __dirname,
|
|
},
|
|
({ next, isNextDev }) => {
|
|
it('should trigger error component when an error happens during rendering', async () => {
|
|
const browser = await next.browser('/client')
|
|
await browser
|
|
.waitForElementByCss('#error-trigger-button')
|
|
.elementByCss('#error-trigger-button')
|
|
.click()
|
|
|
|
if (isNextDev) {
|
|
await testDev(browser, /Error: Client error/)
|
|
} else {
|
|
await browser
|
|
expect(await browser.elementByCss('#error').text()).toBe(
|
|
'Global error: Client error'
|
|
)
|
|
}
|
|
})
|
|
|
|
it('should render global error for error in server components', async () => {
|
|
const browser = await next.browser('/ssr/server')
|
|
|
|
if (isNextDev) {
|
|
await testDev(browser, /Error: server page error/)
|
|
} else {
|
|
expect(await browser.elementByCss('h1').text()).toBe('Global Error')
|
|
expect(await browser.elementByCss('#error').text()).toBe(
|
|
'Global error: An error occurred in the Server Components render. The specific message is omitted in production builds to avoid leaking sensitive details. A digest property is included on this error instance which may provide additional details about the nature of the error.'
|
|
)
|
|
expect(await browser.elementByCss('#digest').text()).toMatch(/\w+/)
|
|
}
|
|
})
|
|
|
|
it('should render global error for error in client components', async () => {
|
|
const browser = await next.browser('/ssr/client')
|
|
|
|
if (isNextDev) {
|
|
await testDev(browser, /Error: client page error/)
|
|
} else {
|
|
expect(await browser.elementByCss('h1').text()).toBe('Global Error')
|
|
expect(await browser.elementByCss('#error').text()).toBe(
|
|
'Global error: client page error'
|
|
)
|
|
|
|
expect(await browser.hasElementByCssSelector('#digest')).toBeFalsy()
|
|
}
|
|
})
|
|
|
|
it('should catch metadata error in error boundary if presented', async () => {
|
|
const browser = await next.browser('/metadata-error-with-boundary')
|
|
|
|
expect(await browser.elementByCss('#error').text()).toBe(
|
|
'Local error boundary'
|
|
)
|
|
expect(await browser.hasElementByCssSelector('#digest')).toBeFalsy()
|
|
})
|
|
|
|
it('should catch metadata error in global-error if no error boundary is presented', async () => {
|
|
const browser = await next.browser('/metadata-error-without-boundary')
|
|
|
|
if (isNextDev) {
|
|
await testDev(browser, /Error: Metadata error/)
|
|
} else {
|
|
expect(await browser.elementByCss('h1').text()).toBe('Global Error')
|
|
expect(await browser.elementByCss('#error').text()).toBe(
|
|
'Global error: An error occurred in the Server Components render. The specific message is omitted in production builds to avoid leaking sensitive details. A digest property is included on this error instance which may provide additional details about the nature of the error.'
|
|
)
|
|
}
|
|
})
|
|
|
|
it('should catch the client error thrown in the nested routes', async () => {
|
|
const browser = await next.browser('/nested/nested')
|
|
if (isNextDev) {
|
|
await testDev(browser, /Error: nested error/)
|
|
} else {
|
|
expect(await browser.elementByCss('h1').text()).toBe('Global Error')
|
|
expect(await browser.elementByCss('#error').text()).toBe(
|
|
'Global error: nested error'
|
|
)
|
|
}
|
|
})
|
|
}
|
|
)
|