mirror of
https://github.com/hanzoai/next.js.git
synced 2026-09-24 17:00:51 +00:00
Andrew ClarkandGitHub
3de2d1a213
Removes the "allow-runtime" prefetch config, and turns its behavior on implicitly wherever Partial Prefetching is enabled. The original motivation for "allow-runtime" was to give apps more control over server costs triggered by prefetches. Until a route explicitly opts in, prefetches would only be served from the CDN, not from the server. The problem, though, was it was very confusing to know when to add or remove this configuration. The incentive for many apps was to add it everywhere, with no clear signal for when to remove it. Our updated thinking is that Partial Prefetching itself already provides sufficient protection against runaway prefetching costs: per-link prefetches only happen on Link components that explicitly opt in with the prefetch prop. The optimizations landed earlier in this stack also make allow-runtime less necessary: on pages where all the content is statically renderable, prefetches are served from the static cache and no runtime request is ever issued; only a page that accesses non-static data is prefetched at runtime. The upshot of this decision is that runtime versus static becomes an internal optimization; the same content gets prefetched regardless of whether or how Next.js is able to optimize it.
73 lines
1.5 KiB
TypeScript
73 lines
1.5 KiB
TypeScript
import type { Instant } from 'next'
|
|
import assert from 'node:assert/strict'
|
|
|
|
import { Suspense } from 'react'
|
|
|
|
export const instant: Instant = {
|
|
level: 'experimental-error',
|
|
unstable_samples: [
|
|
{
|
|
searchParams: {
|
|
// TODO(instant-validation-build): specify and test escaping behavior for spaces etc
|
|
single: 'test',
|
|
multiple: ['a', 'b'],
|
|
missing: null,
|
|
},
|
|
},
|
|
],
|
|
}
|
|
export const prefetch = 'partial'
|
|
|
|
type SearchParams = Record<string, string | string[]>
|
|
|
|
export default async function Page({
|
|
searchParams,
|
|
}: {
|
|
searchParams: Promise<{ foo?: string | string[] }>
|
|
}) {
|
|
return (
|
|
<main>
|
|
<p>
|
|
When validated in build, the page should receive the search params
|
|
specified in the sample.
|
|
</p>
|
|
<Suspense fallback={<div>Loading...</div>}>
|
|
<TestSearchParams searchParams={searchParams} />
|
|
</Suspense>
|
|
</main>
|
|
)
|
|
}
|
|
|
|
async function TestSearchParams({
|
|
searchParams,
|
|
}: {
|
|
searchParams: Promise<SearchParams>
|
|
}) {
|
|
const search = await searchParams
|
|
|
|
assert.equal(
|
|
search.single,
|
|
'test',
|
|
`Unexpected search param value for 'single'`
|
|
)
|
|
|
|
assert.deepStrictEqual(
|
|
search.multiple,
|
|
['a', 'b'],
|
|
`Unexpected search param value for 'multiple'`
|
|
)
|
|
|
|
assert.equal(
|
|
search.missing,
|
|
undefined,
|
|
`search param 'missing' should not be defined`
|
|
)
|
|
assert.equal(
|
|
'missing' in search,
|
|
false,
|
|
`search param 'missing' should not be in the keys of searchParams`
|
|
)
|
|
|
|
return null
|
|
}
|